Re: [PATCH v5] extcon: add Maxim MAX3355 driver

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver
Date: Sun, 20 Dec 2015 17:15:00 +0000	[thread overview]
Message-ID: <5676E214.2040009@cogentembedded.com> (raw)
In-Reply-To: <CAGTfZH34rfMfjsAFgyPeNue74-5iCi6ZwrdN26_jwOXE6R=hwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hello.

On 12/20/2015 05:31 PM, Chanwoo Choi wrote:

> This patch depend on GPIOLIB configuration as following:
> I modified it with following diff and applied it.
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index ba4db7d..3d89e60 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>
>   config EXTCON_MAX3355
>          tristate "Maxim MAX3355 USB OTG EXTCON Support"
> +       depends on GPIOLIB || COMPILE_TEST

    If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
    And no, it shouldn't depend on gpiolib. It has empty stubs for the case of 
CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll 
look into it.

[...]

> Thanks,
> Chanwoo Choi

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)

From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver
Date: Sun, 20 Dec 2015 20:15:00 +0300	[thread overview]
Message-ID: <5676E214.2040009@cogentembedded.com> (raw)
In-Reply-To: <CAGTfZH34rfMfjsAFgyPeNue74-5iCi6ZwrdN26_jwOXE6R=hwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hello.

On 12/20/2015 05:31 PM, Chanwoo Choi wrote:

> This patch depend on GPIOLIB configuration as following:
> I modified it with following diff and applied it.
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index ba4db7d..3d89e60 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>
>   config EXTCON_MAX3355
>          tristate "Maxim MAX3355 USB OTG EXTCON Support"
> +       depends on GPIOLIB || COMPILE_TEST

    If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
    And no, it shouldn't depend on gpiolib. It has empty stubs for the case of 
CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll 
look into it.

[...]

> Thanks,
> Chanwoo Choi

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: cw00.choi@samsung.com
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver
Date: Sun, 20 Dec 2015 20:15:00 +0300	[thread overview]
Message-ID: <5676E214.2040009@cogentembedded.com> (raw)
In-Reply-To: <CAGTfZH34rfMfjsAFgyPeNue74-5iCi6ZwrdN26_jwOXE6R=hwg@mail.gmail.com>

Hello.

On 12/20/2015 05:31 PM, Chanwoo Choi wrote:

> This patch depend on GPIOLIB configuration as following:
> I modified it with following diff and applied it.
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index ba4db7d..3d89e60 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>
>   config EXTCON_MAX3355
>          tristate "Maxim MAX3355 USB OTG EXTCON Support"
> +       depends on GPIOLIB || COMPILE_TEST

    If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
    And no, it shouldn't depend on gpiolib. It has empty stubs for the case of 
CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll 
look into it.

[...]

> Thanks,
> Chanwoo Choi

MBR, Sergei

next prev parent reply	other threads:[~2015-12-20 17:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 23:17 [PATCH v5] extcon: add Maxim MAX3355 driver Sergei Shtylyov
2015-12-18 23:17 ` Sergei Shtylyov
2015-12-20 14:31 ` Chanwoo Choi
2015-12-20 14:31   ` Chanwoo Choi
     [not found]   ` <CAGTfZH34rfMfjsAFgyPeNue74-5iCi6ZwrdN26_jwOXE6R=hwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-20 17:15     ` Sergei Shtylyov [this message]
2015-12-20 17:15       ` Sergei Shtylyov
2015-12-20 17:15       ` Sergei Shtylyov
2015-12-21  2:38       ` Chanwoo Choi
2015-12-21  2:38         ` Chanwoo Choi
2015-12-21 11:01         ` Sergei Shtylyov
2015-12-21 11:01           ` Sergei Shtylyov
2015-12-21 19:38           ` Sergei Shtylyov
2015-12-21 19:38             ` Sergei Shtylyov
2015-12-22  1:13           ` Chanwoo Choi
2015-12-22  1:13             ` Chanwoo Choi
     [not found]             ` <5678A3BE.3040701-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-12-22 11:15               ` Sergei Shtylyov
2015-12-22 11:15                 ` Sergei Shtylyov
2015-12-22 11:15                 ` Sergei Shtylyov
2015-12-23  2:17                 ` Chanwoo Choi
2015-12-23  2:17                   ` Chanwoo Choi
     [not found]                   ` <567A0456.7090400-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-12-23 19:56                     ` Sergei Shtylyov
2015-12-23 19:56                       ` Sergei Shtylyov
2015-12-23 19:56                       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5676E214.2040009@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.