From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens
Date: Mon, 21 Dec 2015 09:18:42 -0700 [thread overview]
Message-ID: <56782662.9000502@redhat.com> (raw)
In-Reply-To: <1450714014-16849-2-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> Adds new methods to allow querying the length of the cipher
> key, block size and initialization vectors.
In the subject line, I read 'lens' as a synonym for 'viewports', not
'lengths'. But I don't know if avoiding the abbreviation is worth it,
because the subject line is already bordering on long. Maybe avoiding
it altogether is easier?
crypto: Add additional query accessors
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> crypto/cipher.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++
> include/crypto/cipher.h | 37 +++++++++++++++++++++++++++++++++++
> tests/test-crypto-cipher.c | 10 ++++++++++
> 3 files changed, 95 insertions(+)
>
But no problems with the actual patch, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-21 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 16:06 [Qemu-devel] [PATCH 0/6] Misc enhancements to crypto APIs Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens Daniel P. Berrange
2015-12-21 16:18 ` Eric Blake [this message]
2015-12-23 10:52 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 2/6] crypto: add ability to query hash digest len Daniel P. Berrange
2015-12-21 16:22 ` Eric Blake
2015-12-23 10:52 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 3/6] crypto: move QCryptoHashAlgorithm enum definition into QAPI Daniel P. Berrange
2015-12-21 16:27 ` Eric Blake
2015-12-22 15:50 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions " Daniel P. Berrange
2015-12-21 16:29 ` Eric Blake
2015-12-21 16:06 ` [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules Daniel P. Berrange
2015-12-21 16:32 ` Eric Blake
2015-12-22 15:53 ` Daniel P. Berrange
2015-12-21 16:06 ` [Qemu-devel] [PATCH 6/6] crypto: fix transposed arguments in cipher error message Daniel P. Berrange
2015-12-21 16:33 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56782662.9000502@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.