Re: [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> The rebuild of qapi-types.c/h is not correctly triggered
> when qapi/crypto.json is changed because it was missing
> from the list of files in the qapi-modules variable.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index af3e5f1..82b2fc8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -271,7 +271,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
>  
>  qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
>                 $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \
> -               $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json
> +               $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json \
> +               $(SRC_PATH)/qapi/crypto.json

Wonder if a wildcard for qapi/*.json would be any smarter.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]