Re: [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions into QAPI

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> The QCryptoCipherAlgorithm and QCryptoCipherMode enums are
> defined in the crypto/cipher.h header. In the future some
> QAPI types will want to reference the hash enums, so move
> the enum definition into QAPI too.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  crypto/cipher.c         |  8 ++++----
>  include/crypto/cipher.h | 17 ++---------------
>  qapi/crypto.json        | 30 ++++++++++++++++++++++++++++++
>  3 files changed, 36 insertions(+), 19 deletions(-)
> 
> diff --git a/crypto/cipher.c b/crypto/cipher.c
> index d02bb32..e92d49a 100644
> --- a/crypto/cipher.c
> +++ b/crypto/cipher.c
> @@ -21,21 +21,21 @@
>  #include "crypto/cipher.h"
>  
>  
> -static size_t alg_key_len[QCRYPTO_CIPHER_ALG_LAST] = {
> +static size_t alg_key_len[QCRYPTO_CIPHER_ALG_MAX] = {

Will need rebasing, now that commit 7fb1cf1 has landed and renamed it
QCRYPTO_CIPHER_ALG__MAX.

Otherwise looks fine.
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]