All of lore.kernel.org
 help / color / mirror / Atom feed
From: majun258@huawei.com (majun (F))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
Date: Tue, 22 Dec 2015 10:46:56 +0800	[thread overview]
Message-ID: <5678B9A0.8050506@huawei.com> (raw)
In-Reply-To: <20151221104358.18734bc3@why.wild-wind.fr.eu.org>



? 2015/12/21 18:43, Marc Zyngier ??:
> On Mon, 21 Dec 2015 11:18:25 +0800
> MaJun <majun258@huawei.com> wrote:
> 
>> From: Ma Jun <majun258@huawei.com>
>>
>> The current MSI framework can only support 256 platform MSIs.
>>
>> But on Hisilicon platform, some network related devices has about 500
>> wired interrupts.
>>
>> To support these devices, we need a new maximum value more than 256.
>>
>> Signed-off-by: Ma Jun <majun258@huawei.com>
>> ---
>>  drivers/base/platform-msi.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
>> index a203896..9c00d3f 100644
>> --- a/drivers/base/platform-msi.c
>> +++ b/drivers/base/platform-msi.c
>> @@ -24,7 +24,7 @@
>>  #include <linux/msi.h>
>>  #include <linux/slab.h>
>>  
>> -#define DEV_ID_SHIFT	24
>> +#define DEV_ID_SHIFT	22
>>  #define MAX_DEV_MSIS	(1 << (32 - DEV_ID_SHIFT))
>>  
>>  /*
> 
> If we bother doing that, why not directly aligning it with MSI-X and
> allow up to 2048 interrupts per device? It is only an extra bit, and
> that still leaves 21 bits worth of device IDs, while still having
> hwirq as an unsigned long (32bit on 32bit architectures).
> 

Ok, I'll changed this value to 2048

Thanks
Ma Jun
> Thanks,
> 
> 	M.
> 

WARNING: multiple messages have this Message-ID (diff)
From: "majun (F)" <majun258@huawei.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: <Catalin.Marinas@arm.com>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <Will.Deacon@arm.com>,
	<mark.rutland@arm.com>, <jason@lakedaemon.net>,
	<tglx@linutronix.de>, <lizefan@huawei.com>, <huxinwei@huawei.com>,
	<dingtianhong@huawei.com>, <zhaojunhua@hisilicon.com>,
	<liguozhu@hisilicon.com>, <xuwei5@hisilicon.com>,
	<wei.chenwei@hisilicon.com>, <guohanjun@huawei.com>
Subject: Re: [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
Date: Tue, 22 Dec 2015 10:46:56 +0800	[thread overview]
Message-ID: <5678B9A0.8050506@huawei.com> (raw)
In-Reply-To: <20151221104358.18734bc3@why.wild-wind.fr.eu.org>



在 2015/12/21 18:43, Marc Zyngier 写道:
> On Mon, 21 Dec 2015 11:18:25 +0800
> MaJun <majun258@huawei.com> wrote:
> 
>> From: Ma Jun <majun258@huawei.com>
>>
>> The current MSI framework can only support 256 platform MSIs.
>>
>> But on Hisilicon platform, some network related devices has about 500
>> wired interrupts.
>>
>> To support these devices, we need a new maximum value more than 256.
>>
>> Signed-off-by: Ma Jun <majun258@huawei.com>
>> ---
>>  drivers/base/platform-msi.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
>> index a203896..9c00d3f 100644
>> --- a/drivers/base/platform-msi.c
>> +++ b/drivers/base/platform-msi.c
>> @@ -24,7 +24,7 @@
>>  #include <linux/msi.h>
>>  #include <linux/slab.h>
>>  
>> -#define DEV_ID_SHIFT	24
>> +#define DEV_ID_SHIFT	22
>>  #define MAX_DEV_MSIS	(1 << (32 - DEV_ID_SHIFT))
>>  
>>  /*
> 
> If we bother doing that, why not directly aligning it with MSI-X and
> allow up to 2048 interrupts per device? It is only an extra bit, and
> that still leaves 21 bits worth of device IDs, while still having
> hwirq as an unsigned long (32bit on 32bit architectures).
> 

Ok, I'll changed this value to 2048

Thanks
Ma Jun
> Thanks,
> 
> 	M.
> 


  reply	other threads:[~2015-12-22  2:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21  3:18 [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support MaJun
2015-12-21  3:18 ` MaJun
2015-12-21 10:43 ` Marc Zyngier
2015-12-21 10:43   ` Marc Zyngier
2015-12-22  2:46   ` majun (F) [this message]
2015-12-22  2:46     ` majun (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5678B9A0.8050506@huawei.com \
    --to=majun258@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.