* [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
@ 2015-12-21 3:18 ` MaJun
0 siblings, 0 replies; 6+ messages in thread
From: MaJun @ 2015-12-21 3:18 UTC (permalink / raw)
To: linux-arm-kernel
From: Ma Jun <majun258@huawei.com>
The current MSI framework can only support 256 platform MSIs.
But on Hisilicon platform, some network related devices has about 500
wired interrupts.
To support these devices, we need a new maximum value more than 256.
Signed-off-by: Ma Jun <majun258@huawei.com>
---
drivers/base/platform-msi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
index a203896..9c00d3f 100644
--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -24,7 +24,7 @@
#include <linux/msi.h>
#include <linux/slab.h>
-#define DEV_ID_SHIFT 24
+#define DEV_ID_SHIFT 22
#define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT))
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
@ 2015-12-21 3:18 ` MaJun
0 siblings, 0 replies; 6+ messages in thread
From: MaJun @ 2015-12-21 3:18 UTC (permalink / raw)
To: Catalin.Marinas, linux-kernel, linux-arm-kernel, Will.Deacon,
mark.rutland, marc.zyngier, jason, tglx, lizefan, huxinwei,
dingtianhong, zhaojunhua, liguozhu, xuwei5, wei.chenwei,
guohanjun, majun258
From: Ma Jun <majun258@huawei.com>
The current MSI framework can only support 256 platform MSIs.
But on Hisilicon platform, some network related devices has about 500
wired interrupts.
To support these devices, we need a new maximum value more than 256.
Signed-off-by: Ma Jun <majun258@huawei.com>
---
drivers/base/platform-msi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
index a203896..9c00d3f 100644
--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -24,7 +24,7 @@
#include <linux/msi.h>
#include <linux/slab.h>
-#define DEV_ID_SHIFT 24
+#define DEV_ID_SHIFT 22
#define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT))
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
2015-12-21 3:18 ` MaJun
@ 2015-12-21 10:43 ` Marc Zyngier
-1 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2015-12-21 10:43 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 21 Dec 2015 11:18:25 +0800
MaJun <majun258@huawei.com> wrote:
> From: Ma Jun <majun258@huawei.com>
>
> The current MSI framework can only support 256 platform MSIs.
>
> But on Hisilicon platform, some network related devices has about 500
> wired interrupts.
>
> To support these devices, we need a new maximum value more than 256.
>
> Signed-off-by: Ma Jun <majun258@huawei.com>
> ---
> drivers/base/platform-msi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
> index a203896..9c00d3f 100644
> --- a/drivers/base/platform-msi.c
> +++ b/drivers/base/platform-msi.c
> @@ -24,7 +24,7 @@
> #include <linux/msi.h>
> #include <linux/slab.h>
>
> -#define DEV_ID_SHIFT 24
> +#define DEV_ID_SHIFT 22
> #define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT))
>
> /*
If we bother doing that, why not directly aligning it with MSI-X and
allow up to 2048 interrupts per device? It is only an extra bit, and
that still leaves 21 bits worth of device IDs, while still having
hwirq as an unsigned long (32bit on 32bit architectures).
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
@ 2015-12-21 10:43 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2015-12-21 10:43 UTC (permalink / raw)
To: MaJun
Cc: Catalin.Marinas, linux-kernel, linux-arm-kernel, Will.Deacon,
mark.rutland, jason, tglx, lizefan, huxinwei, dingtianhong,
zhaojunhua, liguozhu, xuwei5, wei.chenwei, guohanjun
On Mon, 21 Dec 2015 11:18:25 +0800
MaJun <majun258@huawei.com> wrote:
> From: Ma Jun <majun258@huawei.com>
>
> The current MSI framework can only support 256 platform MSIs.
>
> But on Hisilicon platform, some network related devices has about 500
> wired interrupts.
>
> To support these devices, we need a new maximum value more than 256.
>
> Signed-off-by: Ma Jun <majun258@huawei.com>
> ---
> drivers/base/platform-msi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
> index a203896..9c00d3f 100644
> --- a/drivers/base/platform-msi.c
> +++ b/drivers/base/platform-msi.c
> @@ -24,7 +24,7 @@
> #include <linux/msi.h>
> #include <linux/slab.h>
>
> -#define DEV_ID_SHIFT 24
> +#define DEV_ID_SHIFT 22
> #define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT))
>
> /*
If we bother doing that, why not directly aligning it with MSI-X and
allow up to 2048 interrupts per device? It is only an extra bit, and
that still leaves 21 bits worth of device IDs, while still having
hwirq as an unsigned long (32bit on 32bit architectures).
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
2015-12-21 10:43 ` Marc Zyngier
@ 2015-12-22 2:46 ` majun (F)
-1 siblings, 0 replies; 6+ messages in thread
From: majun (F) @ 2015-12-22 2:46 UTC (permalink / raw)
To: linux-arm-kernel
? 2015/12/21 18:43, Marc Zyngier ??:
> On Mon, 21 Dec 2015 11:18:25 +0800
> MaJun <majun258@huawei.com> wrote:
>
>> From: Ma Jun <majun258@huawei.com>
>>
>> The current MSI framework can only support 256 platform MSIs.
>>
>> But on Hisilicon platform, some network related devices has about 500
>> wired interrupts.
>>
>> To support these devices, we need a new maximum value more than 256.
>>
>> Signed-off-by: Ma Jun <majun258@huawei.com>
>> ---
>> drivers/base/platform-msi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
>> index a203896..9c00d3f 100644
>> --- a/drivers/base/platform-msi.c
>> +++ b/drivers/base/platform-msi.c
>> @@ -24,7 +24,7 @@
>> #include <linux/msi.h>
>> #include <linux/slab.h>
>>
>> -#define DEV_ID_SHIFT 24
>> +#define DEV_ID_SHIFT 22
>> #define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT))
>>
>> /*
>
> If we bother doing that, why not directly aligning it with MSI-X and
> allow up to 2048 interrupts per device? It is only an extra bit, and
> that still leaves 21 bits worth of device IDs, while still having
> hwirq as an unsigned long (32bit on 32bit architectures).
>
Ok, I'll changed this value to 2048
Thanks
Ma Jun
> Thanks,
>
> M.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.
@ 2015-12-22 2:46 ` majun (F)
0 siblings, 0 replies; 6+ messages in thread
From: majun (F) @ 2015-12-22 2:46 UTC (permalink / raw)
To: Marc Zyngier
Cc: Catalin.Marinas, linux-kernel, linux-arm-kernel, Will.Deacon,
mark.rutland, jason, tglx, lizefan, huxinwei, dingtianhong,
zhaojunhua, liguozhu, xuwei5, wei.chenwei, guohanjun
在 2015/12/21 18:43, Marc Zyngier 写道:
> On Mon, 21 Dec 2015 11:18:25 +0800
> MaJun <majun258@huawei.com> wrote:
>
>> From: Ma Jun <majun258@huawei.com>
>>
>> The current MSI framework can only support 256 platform MSIs.
>>
>> But on Hisilicon platform, some network related devices has about 500
>> wired interrupts.
>>
>> To support these devices, we need a new maximum value more than 256.
>>
>> Signed-off-by: Ma Jun <majun258@huawei.com>
>> ---
>> drivers/base/platform-msi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
>> index a203896..9c00d3f 100644
>> --- a/drivers/base/platform-msi.c
>> +++ b/drivers/base/platform-msi.c
>> @@ -24,7 +24,7 @@
>> #include <linux/msi.h>
>> #include <linux/slab.h>
>>
>> -#define DEV_ID_SHIFT 24
>> +#define DEV_ID_SHIFT 22
>> #define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT))
>>
>> /*
>
> If we bother doing that, why not directly aligning it with MSI-X and
> allow up to 2048 interrupts per device? It is only an extra bit, and
> that still leaves 21 bits worth of device IDs, while still having
> hwirq as an unsigned long (32bit on 32bit architectures).
>
Ok, I'll changed this value to 2048
Thanks
Ma Jun
> Thanks,
>
> M.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-22 2:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-21 3:18 [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support MaJun
2015-12-21 3:18 ` MaJun
2015-12-21 10:43 ` Marc Zyngier
2015-12-21 10:43 ` Marc Zyngier
2015-12-22 2:46 ` majun (F)
2015-12-22 2:46 ` majun (F)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.