* [PATCH] nfsstat: show client rpc information correctly
@ 2015-12-24 12:12 Kinglong Mee
2015-12-28 18:35 ` Benjamin Coddington
2016-01-16 22:00 ` Steve Dickson
0 siblings, 2 replies; 3+ messages in thread
From: Kinglong Mee @ 2015-12-24 12:12 UTC (permalink / raw)
To: Steve Dickson
Cc: Trond Myklebust, linux-nfs@vger.kernel.org, kinglongmee,
Benjamin Coddington
There are 59 client rpc procedures, not 60.
The order of rpc name must be the same as define of
NFSPROC4_CLNT_xx in include/linux/nfs4.h,
not nfs4_procedures in nfs4xdr.c.
Drop duplicate rpc name "getdevlist".
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
utils/nfsstat/nfsstat.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
index b67f0aa..8376347 100644
--- a/utils/nfsstat/nfsstat.c
+++ b/utils/nfsstat/nfsstat.c
@@ -31,7 +31,7 @@ enum {
SRVPROC3_SZ = 22,
CLTPROC3_SZ = 22,
SRVPROC4_SZ = 2,
- CLTPROC4_SZ = 60,
+ CLTPROC4_SZ = 59,
SRVPROC4OPS_SZ = 71,
};
@@ -135,11 +135,10 @@ static const char * nfscltproc4name[CLTPROC4_SZ] = {
"sequence",
"get_lease_time",
"reclaim_comp",
- "getdevinfo",
"layoutget",
+ "getdevinfo",
"layoutcommit",
"layoutreturn",
- "getdevlist",
"secinfo_no",
"test_stateid",
"free_stateid",
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nfsstat: show client rpc information correctly
2015-12-24 12:12 [PATCH] nfsstat: show client rpc information correctly Kinglong Mee
@ 2015-12-28 18:35 ` Benjamin Coddington
2016-01-16 22:00 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Coddington @ 2015-12-28 18:35 UTC (permalink / raw)
To: Kinglong Mee; +Cc: Steve Dickson, Trond Myklebust, linux-nfs@vger.kernel.org
> There are 59 client rpc procedures, not 60.
>
> The order of rpc name must be the same as define of
> NFSPROC4_CLNT_xx in include/linux/nfs4.h,
> not nfs4_procedures in nfs4xdr.c.
Thanks for fixing this -- I did not look very closely at the
#define PROC(proc, argtype, restype) and missed the designated initializer.
It looks like we don't keep track of stats for NULL, then. That seems like
a minor problem -- but maybe we shouldn't be pretending we are keeping track
of it.
> Drop duplicate rpc name "getdevlist".
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
> ---
> utils/nfsstat/nfsstat.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index b67f0aa..8376347 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -31,7 +31,7 @@ enum {
> SRVPROC3_SZ = 22,
> CLTPROC3_SZ = 22,
> SRVPROC4_SZ = 2,
> - CLTPROC4_SZ = 60,
> + CLTPROC4_SZ = 59,
> SRVPROC4OPS_SZ = 71,
> };
>
> @@ -135,11 +135,10 @@ static const char * nfscltproc4name[CLTPROC4_SZ] = {
> "sequence",
> "get_lease_time",
> "reclaim_comp",
> - "getdevinfo",
> "layoutget",
> + "getdevinfo",
> "layoutcommit",
> "layoutreturn",
> - "getdevlist",
> "secinfo_no",
> "test_stateid",
> "free_stateid",
> --
> 2.5.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nfsstat: show client rpc information correctly
2015-12-24 12:12 [PATCH] nfsstat: show client rpc information correctly Kinglong Mee
2015-12-28 18:35 ` Benjamin Coddington
@ 2016-01-16 22:00 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2016-01-16 22:00 UTC (permalink / raw)
To: Kinglong Mee
Cc: Trond Myklebust, linux-nfs@vger.kernel.org, Benjamin Coddington
On 12/24/2015 07:12 AM, Kinglong Mee wrote:
> There are 59 client rpc procedures, not 60.
>
> The order of rpc name must be the same as define of
> NFSPROC4_CLNT_xx in include/linux/nfs4.h,
> not nfs4_procedures in nfs4xdr.c.
>
> Drop duplicate rpc name "getdevlist".
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Committed! Thanks!
steved.
> ---
> utils/nfsstat/nfsstat.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index b67f0aa..8376347 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -31,7 +31,7 @@ enum {
> SRVPROC3_SZ = 22,
> CLTPROC3_SZ = 22,
> SRVPROC4_SZ = 2,
> - CLTPROC4_SZ = 60,
> + CLTPROC4_SZ = 59,
> SRVPROC4OPS_SZ = 71,
> };
>
> @@ -135,11 +135,10 @@ static const char * nfscltproc4name[CLTPROC4_SZ] = {
> "sequence",
> "get_lease_time",
> "reclaim_comp",
> - "getdevinfo",
> "layoutget",
> + "getdevinfo",
> "layoutcommit",
> "layoutreturn",
> - "getdevlist",
> "secinfo_no",
> "test_stateid",
> "free_stateid",
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-16 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-24 12:12 [PATCH] nfsstat: show client rpc information correctly Kinglong Mee
2015-12-28 18:35 ` Benjamin Coddington
2016-01-16 22:00 ` Steve Dickson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.