All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
Date: Tue, 29 Dec 2015 11:28:47 +0100	[thread overview]
Message-ID: <5682605F.100@weilnetz.de> (raw)
In-Reply-To: <1451384035-29691-1-git-send-email-caoj.fnst@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/xen/Makefile.objs | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/Makefile.objs
> +++ b/hw/xen/Makefile.objs
> @@ -1,6 +1,4 @@
>  # xen backend driver support
>  common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>  
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o

Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
added duplicate .o entries which of course should be removed.

I suggest to keep the first line separate instead of merging it.
That preserves the alphabetic order and avoids a long line.

Regards,
Stefan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
Date: Tue, 29 Dec 2015 11:28:47 +0100	[thread overview]
Message-ID: <5682605F.100@weilnetz.de> (raw)
In-Reply-To: <1451384035-29691-1-git-send-email-caoj.fnst@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/xen/Makefile.objs | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/Makefile.objs
> +++ b/hw/xen/Makefile.objs
> @@ -1,6 +1,4 @@
>  # xen backend driver support
>  common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>  
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o

Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
added duplicate .o entries which of course should be removed.

I suggest to keep the first line separate instead of merging it.
That preserves the alphabetic order and avoids a long line.

Regards,
Stefan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH trivial] xen/Makefile.objs: simplify
Date: Tue, 29 Dec 2015 11:28:47 +0100	[thread overview]
Message-ID: <5682605F.100@weilnetz.de> (raw)
In-Reply-To: <1451384035-29691-1-git-send-email-caoj.fnst@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/xen/Makefile.objs | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/Makefile.objs
> +++ b/hw/xen/Makefile.objs
> @@ -1,6 +1,4 @@
>  # xen backend driver support
>  common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>  
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o

Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
added duplicate .o entries which of course should be removed.

I suggest to keep the first line separate instead of merging it.
That preserves the alphabetic order and avoids a long line.

Regards,
Stefan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-12-29 10:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 10:13 [Qemu-trivial] [PATCH trivial] xen/Makefile.objs: simplify Cao jin
2015-12-29 10:13 ` Cao jin
2015-12-29 10:13 ` [Qemu-devel] " Cao jin
2015-12-29 10:28 ` Stefan Weil [this message]
2015-12-29 10:28   ` Stefan Weil
2015-12-29 10:28   ` [Qemu-devel] " Stefan Weil
2015-12-29 12:27   ` [Qemu-trivial] " Cao jin
2015-12-29 12:27     ` Cao jin
2015-12-29 12:27     ` [Qemu-devel] " Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5682605F.100@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.