* [Qemu-trivial] [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 10:13 ` Cao jin
0 siblings, 0 replies; 9+ messages in thread
From: Cao jin @ 2015-12-29 10:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
merge three lines into one line
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/xen/Makefile.objs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index a9ad7e7..77806f0 100644
--- a/hw/xen/Makefile.objs
+++ b/hw/xen/Makefile.objs
@@ -1,6 +1,4 @@
# xen backend driver support
common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
+obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 10:13 ` Cao jin
0 siblings, 0 replies; 9+ messages in thread
From: Cao jin @ 2015-12-29 10:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
merge three lines into one line
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/xen/Makefile.objs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index a9ad7e7..77806f0 100644
--- a/hw/xen/Makefile.objs
+++ b/hw/xen/Makefile.objs
@@ -1,6 +1,4 @@
# xen backend driver support
common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
+obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 10:13 ` Cao jin
0 siblings, 0 replies; 9+ messages in thread
From: Cao jin @ 2015-12-29 10:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
merge three lines into one line
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/xen/Makefile.objs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index a9ad7e7..77806f0 100644
--- a/hw/xen/Makefile.objs
+++ b/hw/xen/Makefile.objs
@@ -1,6 +1,4 @@
# xen backend driver support
common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
-obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
+obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
2015-12-29 10:13 ` [Qemu-devel] " Cao jin
(?)
@ 2015-12-29 10:28 ` Stefan Weil
-1 siblings, 0 replies; 9+ messages in thread
From: Stefan Weil @ 2015-12-29 10:28 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/xen/Makefile.objs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/Makefile.objs
> +++ b/hw/xen/Makefile.objs
> @@ -1,6 +1,4 @@
> # xen backend driver support
> common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
added duplicate .o entries which of course should be removed.
I suggest to keep the first line separate instead of merging it.
That preserves the alphabetic order and avoids a long line.
Regards,
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 10:28 ` Stefan Weil
0 siblings, 0 replies; 9+ messages in thread
From: Stefan Weil @ 2015-12-29 10:28 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/xen/Makefile.objs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/Makefile.objs
> +++ b/hw/xen/Makefile.objs
> @@ -1,6 +1,4 @@
> # xen backend driver support
> common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
added duplicate .o entries which of course should be removed.
I suggest to keep the first line separate instead of merging it.
That preserves the alphabetic order and avoids a long line.
Regards,
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 10:28 ` Stefan Weil
0 siblings, 0 replies; 9+ messages in thread
From: Stefan Weil @ 2015-12-29 10:28 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/xen/Makefile.objs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/Makefile.objs
> +++ b/hw/xen/Makefile.objs
> @@ -1,6 +1,4 @@
> # xen backend driver support
> common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
added duplicate .o entries which of course should be removed.
I suggest to keep the first line separate instead of merging it.
That preserves the alphabetic order and avoids a long line.
Regards,
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
2015-12-29 10:28 ` [Qemu-devel] " Stefan Weil
(?)
@ 2015-12-29 12:27 ` Cao jin
-1 siblings, 0 replies; 9+ messages in thread
From: Cao jin @ 2015-12-29 12:27 UTC (permalink / raw)
To: Stefan Weil, qemu-devel
Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
On 12/29/2015 06:28 PM, Stefan Weil wrote:
> Am 29.12.2015 um 11:13 schrieb Cao jin:
>> merge three lines into one line
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>> hw/xen/Makefile.objs | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
>> index a9ad7e7..77806f0 100644
>> --- a/hw/xen/Makefile.objs
>> +++ b/hw/xen/Makefile.objs
>> @@ -1,6 +1,4 @@
>> # xen backend driver support
>> common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>>
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
>> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
>
> Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
> added duplicate .o entries which of course should be removed.
>
> I suggest to keep the first line separate instead of merging it.
> That preserves the alphabetic order and avoids a long line.
Ok, v2 is coming soon:)
> Regards,
> Stefan
>
>
--
Yours Sincerely,
Cao Jin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 12:27 ` Cao jin
0 siblings, 0 replies; 9+ messages in thread
From: Cao jin @ 2015-12-29 12:27 UTC (permalink / raw)
To: Stefan Weil, qemu-devel
Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
On 12/29/2015 06:28 PM, Stefan Weil wrote:
> Am 29.12.2015 um 11:13 schrieb Cao jin:
>> merge three lines into one line
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>> hw/xen/Makefile.objs | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
>> index a9ad7e7..77806f0 100644
>> --- a/hw/xen/Makefile.objs
>> +++ b/hw/xen/Makefile.objs
>> @@ -1,6 +1,4 @@
>> # xen backend driver support
>> common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>>
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
>> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
>
> Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
> added duplicate .o entries which of course should be removed.
>
> I suggest to keep the first line separate instead of merging it.
> That preserves the alphabetic order and avoids a long line.
Ok, v2 is coming soon:)
> Regards,
> Stefan
>
>
--
Yours Sincerely,
Cao Jin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] xen/Makefile.objs: simplify
@ 2015-12-29 12:27 ` Cao jin
0 siblings, 0 replies; 9+ messages in thread
From: Cao jin @ 2015-12-29 12:27 UTC (permalink / raw)
To: Stefan Weil, qemu-devel
Cc: qemu-trivial, pbonzini, xen-devel, stefano.stabellini
On 12/29/2015 06:28 PM, Stefan Weil wrote:
> Am 29.12.2015 um 11:13 schrieb Cao jin:
>> merge three lines into one line
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>> hw/xen/Makefile.objs | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
>> index a9ad7e7..77806f0 100644
>> --- a/hw/xen/Makefile.objs
>> +++ b/hw/xen/Makefile.objs
>> @@ -1,6 +1,4 @@
>> # xen backend driver support
>> common-obj-$(CONFIG_XEN_BACKEND) += xen_backend.o xen_devconfig.o
>>
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
>> -obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o
>> +obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o xen_pt_graphics.o xen-host-pci-device.o
>
> Obviously commit 798141799ccd5235a928b8fc0411d7d74e706489
> added duplicate .o entries which of course should be removed.
>
> I suggest to keep the first line separate instead of merging it.
> That preserves the alphabetic order and avoids a long line.
Ok, v2 is coming soon:)
> Regards,
> Stefan
>
>
--
Yours Sincerely,
Cao Jin
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-12-29 12:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-29 10:13 [Qemu-trivial] [PATCH trivial] xen/Makefile.objs: simplify Cao jin
2015-12-29 10:13 ` Cao jin
2015-12-29 10:13 ` [Qemu-devel] " Cao jin
2015-12-29 10:28 ` [Qemu-trivial] " Stefan Weil
2015-12-29 10:28 ` Stefan Weil
2015-12-29 10:28 ` [Qemu-devel] " Stefan Weil
2015-12-29 12:27 ` [Qemu-trivial] " Cao jin
2015-12-29 12:27 ` Cao jin
2015-12-29 12:27 ` [Qemu-devel] " Cao jin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.