From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
mika.westerberg@linux.intel.com, wsa@the-dreams.de
Cc: jarkko.nikula@linux.intel.com, lho@apm.com, Ken.Xue@amd.com,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided
Date: Mon, 4 Jan 2016 09:17:26 -0600 [thread overview]
Message-ID: <568A8D06.2010901@amd.com> (raw)
In-Reply-To: <1450895221.30729.322.camel@linux.intel.com>
Hi Andy,
On 12/23/2015 12:27 PM, Andy Shevchenko wrote:
>> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
>> >b/drivers/i2c/busses/i2c-designware-platdrv.c
>> >index 8ffc36b..04edd09 100644
>> >--- a/drivers/i2c/busses/i2c-designware-platdrv.c
>> >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> Can we introduce
>
> static int i2c_dw_plat_prepare_clk(struct dw_i2c_dev *i_dev, bool
> prepare)
> {
> if (IS_ERR(i_dev->clk))
> return PTR_ERR(i_dev->clk);
>
> if (prepare)
> /* REMOVEME: Yes, you have to check return value and this is one
> benefit of this change */
> return clk_prepare_enable(i_dev->clk);
>
> clk_disable_unprepare(i_dev->clk);
> return 0;
> }
>
> and…
>
Yes, I think this change. I'll put this in the V4, and send out soon.
Suravee
WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <wsa@the-dreams.de>
Cc: <jarkko.nikula@linux.intel.com>, <lho@apm.com>, <Ken.Xue@amd.com>,
<linux-i2c@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided
Date: Mon, 4 Jan 2016 09:17:26 -0600 [thread overview]
Message-ID: <568A8D06.2010901@amd.com> (raw)
In-Reply-To: <1450895221.30729.322.camel@linux.intel.com>
Hi Andy,
On 12/23/2015 12:27 PM, Andy Shevchenko wrote:
>> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
>> >b/drivers/i2c/busses/i2c-designware-platdrv.c
>> >index 8ffc36b..04edd09 100644
>> >--- a/drivers/i2c/busses/i2c-designware-platdrv.c
>> >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> Can we introduce
>
> static int i2c_dw_plat_prepare_clk(struct dw_i2c_dev *i_dev, bool
> prepare)
> {
> if (IS_ERR(i_dev->clk))
> return PTR_ERR(i_dev->clk);
>
> if (prepare)
> /* REMOVEME: Yes, you have to check return value and this is one
> benefit of this change */
> return clk_prepare_enable(i_dev->clk);
>
> clk_disable_unprepare(i_dev->clk);
> return 0;
> }
>
> and…
>
Yes, I think this change. I'll put this in the V4, and send out soon.
Suravee
next prev parent reply other threads:[~2016-01-04 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 21:35 [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided Suravee Suthikulpanit
2015-12-22 21:35 ` Suravee Suthikulpanit
2015-12-23 18:27 ` Andy Shevchenko
2016-01-04 15:17 ` Suravee Suthikulpanit [this message]
2016-01-04 15:17 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A8D06.2010901@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=Ken.Xue@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.