From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrey Smetanin <asmetanin@virtuozzo.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>,
Roman Kagan <rkagan@virtuozzo.com>,
"Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 3/7] kvm/x86: Hyper-V unify stimer_start() and stimer_restart()
Date: Thu, 7 Jan 2016 17:40:36 +0100 [thread overview]
Message-ID: <568E9504.30900@redhat.com> (raw)
In-Reply-To: <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com>
On 28/12/2015 16:27, Andrey Smetanin wrote:
> This will be used in future to start Hyper-V SynIC timer
> in several places by one logic in one function.
>
> Changes v2:
> * drop stimer->count == 0 check inside stimer_start()
> * comment stimer_start() assumptions
Can you replace comments with WARN_ON_ONCE?
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrey Smetanin <asmetanin@virtuozzo.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>, "Denis V. Lunev" <den@openvz.org>,
Roman Kagan <rkagan@virtuozzo.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/7] kvm/x86: Hyper-V unify stimer_start() and stimer_restart()
Date: Thu, 7 Jan 2016 17:40:36 +0100 [thread overview]
Message-ID: <568E9504.30900@redhat.com> (raw)
In-Reply-To: <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com>
On 28/12/2015 16:27, Andrey Smetanin wrote:
> This will be used in future to start Hyper-V SynIC timer
> in several places by one logic in one function.
>
> Changes v2:
> * drop stimer->count == 0 check inside stimer_start()
> * comment stimer_start() assumptions
Can you replace comments with WARN_ON_ONCE?
Paolo
next prev parent reply other threads:[~2016-01-07 16:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 15:27 [PATCH v2 0/7] KVM: Hyper-V SynIC timers migration fixes Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 1/7] kvm/x86: Hyper-V timers fix incorrect logical operation Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 2/7] kvm/x86: Drop stimer_stop() function Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 3/7] kvm/x86: Hyper-V unify stimer_start() and stimer_restart() Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2016-01-07 16:40 ` Paolo Bonzini [this message]
2016-01-07 16:40 ` Paolo Bonzini
2016-01-07 20:15 ` Andrey Smetanin
2016-01-07 20:15 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 4/7] kvm/x86: Reorg stimer_expiration() to better control timer restart Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 5/7] kvm/x86: Hyper-V fix SynIC timer disabling condition Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 6/7] kvm/x86: Skip SynIC vector check for QEMU side Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2015-12-28 15:27 ` [PATCH v2 7/7] kvm/x86: Update SynIC timers on guest entry only Andrey Smetanin
2015-12-28 15:27 ` [Qemu-devel] " Andrey Smetanin
2016-01-07 16:42 ` [PATCH v2 0/7] KVM: Hyper-V SynIC timers migration fixes Paolo Bonzini
2016-01-07 16:42 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E9504.30900@redhat.com \
--to=pbonzini@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.