* [PATCH] drm/radeon: fix trivial typo in warning message
@ 2016-01-08 0:22 Alexandre Demers
2016-01-08 9:35 ` Christian König
2016-01-08 17:36 ` Alex Deucher
0 siblings, 2 replies; 4+ messages in thread
From: Alexandre Demers @ 2016-01-08 0:22 UTC (permalink / raw)
To: dri-devel; +Cc: =airlied, christian.koenig
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
---
drivers/gpu/drm/radeon/radeon_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index c566993..4197ca1 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -1150,7 +1150,7 @@ static void radeon_check_arguments(struct radeon_device *rdev)
}
if (radeon_vm_size < 1) {
- dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
+ dev_warn(rdev->dev, "VM size (%d) too small, min is 1GB\n",
radeon_vm_size);
radeon_vm_size = 4;
}
--
2.6.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: fix trivial typo in warning message
2016-01-08 0:22 [PATCH] drm/radeon: fix trivial typo in warning message Alexandre Demers
@ 2016-01-08 9:35 ` Christian König
2016-01-08 12:10 ` Eric Engestrom
2016-01-08 17:36 ` Alex Deucher
1 sibling, 1 reply; 4+ messages in thread
From: Christian König @ 2016-01-08 9:35 UTC (permalink / raw)
To: Alexandre Demers, dri-devel; +Cc: =airlied
Am 08.01.2016 um 01:22 schrieb Alexandre Demers:
> Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
We probably need to fix this in amdgpu as well.
Thanks for the help,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index c566993..4197ca1 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -1150,7 +1150,7 @@ static void radeon_check_arguments(struct radeon_device *rdev)
> }
>
> if (radeon_vm_size < 1) {
> - dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
> + dev_warn(rdev->dev, "VM size (%d) too small, min is 1GB\n",
> radeon_vm_size);
> radeon_vm_size = 4;
> }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: fix trivial typo in warning message
2016-01-08 9:35 ` Christian König
@ 2016-01-08 12:10 ` Eric Engestrom
0 siblings, 0 replies; 4+ messages in thread
From: Eric Engestrom @ 2016-01-08 12:10 UTC (permalink / raw)
To: dri-devel
Yes, a quick grep shows the same typo in several places:
> $ grep -Rwn 'to small' drivers/gpu/
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:544: DRM_ERROR("BO to small for addr 0x%010Lx %d %d\n",
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:648: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:656: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
> drivers/gpu/drm/radeon/radeon_device.c:1153: dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
> drivers/gpu/drm/radeon/radeon_vce.c:501: DRM_ERROR("buffer to small (%d / %d)!\n",
> drivers/gpu/drm/radeon/radeon_uvd.c:563: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
BTW there's also a 'to large' one:
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:342: /* clamp timeout if it's to large */
On 08/01/16 09:35, Christian König wrote:
> Am 08.01.2016 um 01:22 schrieb Alexandre Demers:
>> Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>.
>
> We probably need to fix this in amdgpu as well.
>
> Thanks for the help,
> Christian.
>
>> ---
>> drivers/gpu/drm/radeon/radeon_device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
>> index c566993..4197ca1 100644
>> --- a/drivers/gpu/drm/radeon/radeon_device.c
>> +++ b/drivers/gpu/drm/radeon/radeon_device.c
>> @@ -1150,7 +1150,7 @@ static void radeon_check_arguments(struct radeon_device *rdev)
>> }
>>
>> if (radeon_vm_size < 1) {
>> - dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
>> + dev_warn(rdev->dev, "VM size (%d) too small, min is 1GB\n",
>> radeon_vm_size);
>> radeon_vm_size = 4;
>> }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon: fix trivial typo in warning message
2016-01-08 0:22 [PATCH] drm/radeon: fix trivial typo in warning message Alexandre Demers
2016-01-08 9:35 ` Christian König
@ 2016-01-08 17:36 ` Alex Deucher
1 sibling, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2016-01-08 17:36 UTC (permalink / raw)
To: Alexandre Demers; +Cc: =airlied, Christian Koenig, Maling list - DRI developers
On Thu, Jan 7, 2016 at 7:22 PM, Alexandre Demers
<alexandre.f.demers@gmail.com> wrote:
> Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index c566993..4197ca1 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -1150,7 +1150,7 @@ static void radeon_check_arguments(struct radeon_device *rdev)
> }
>
> if (radeon_vm_size < 1) {
> - dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
> + dev_warn(rdev->dev, "VM size (%d) too small, min is 1GB\n",
> radeon_vm_size);
> radeon_vm_size = 4;
> }
> --
> 2.6.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-08 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 0:22 [PATCH] drm/radeon: fix trivial typo in warning message Alexandre Demers
2016-01-08 9:35 ` Christian König
2016-01-08 12:10 ` Eric Engestrom
2016-01-08 17:36 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.