From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>, Anand Moon <linux.amoon@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tjakobi@math.uni-bielefeld.de
Subject: Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
Date: Fri, 8 Jan 2016 12:35:15 -0300 [thread overview]
Message-ID: <568FD733.8030601@osg.samsung.com> (raw)
In-Reply-To: <1452132905-8587-2-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?
> CONFIG_ARM_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM_NEON=m
> CONFIG_CRYPTO_SHA256_ARM=m
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
Date: Fri, 8 Jan 2016 12:35:15 -0300 [thread overview]
Message-ID: <568FD733.8030601@osg.samsung.com> (raw)
In-Reply-To: <1452132905-8587-2-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?
> CONFIG_ARM_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM_NEON=m
> CONFIG_CRYPTO_SHA256_ARM=m
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-01-08 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 2:15 [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats Krzysztof Kozlowski
2016-01-07 2:15 ` Krzysztof Kozlowski
2016-01-07 2:15 ` [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Krzysztof Kozlowski
2016-01-07 2:15 ` Krzysztof Kozlowski
2016-01-07 17:12 ` Anand Moon
2016-01-07 17:12 ` Anand Moon
2016-01-08 15:35 ` Javier Martinez Canillas [this message]
2016-01-08 15:35 ` Javier Martinez Canillas
2016-01-09 2:46 ` Krzysztof Kozlowski
2016-01-09 2:46 ` Krzysztof Kozlowski
2016-01-11 16:04 ` Javier Martinez Canillas
2016-01-11 16:04 ` Javier Martinez Canillas
2016-01-07 17:10 ` [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats Anand Moon
2016-01-07 17:10 ` Anand Moon
2016-01-08 15:32 ` Javier Martinez Canillas
2016-01-08 15:32 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FD733.8030601@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.