* [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats
@ 2016-01-07 2:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-07 2:15 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas,
Anand Moon, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: tjakobi
Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
which should bring performance benefits on Exynos SoCs. Enable these as
modules because they are optional, not essential anyhow for platform
booting nor related directly to Exynos Soc. All accelerated algorithms
pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
Additionally enable cpufreq statistics as they are useful for debugging.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/configs/exynos_defconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 24dcd2bb1215..0aee1e035be9 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -26,12 +26,14 @@ CONFIG_ARM_APPENDED_DTB=y
CONFIG_ARM_ATAG_DTB_COMPAT=y
CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc mem=256M"
CONFIG_CPU_FREQ=y
+CONFIG_CPU_FREQ_STAT_DETAILS=y
CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
CONFIG_CPUFREQ_DT=y
CONFIG_CPU_IDLE=y
CONFIG_ARM_EXYNOS_CPUIDLE=y
CONFIG_VFP=y
CONFIG_NEON=y
+CONFIG_KERNEL_MODE_NEON=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
@@ -238,7 +240,11 @@ CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_USER=y
-CONFIG_CRYPTO_SHA256=y
+CONFIG_ARM_CRYPTO=y
+CONFIG_CRYPTO_SHA1_ARM_NEON=m
+CONFIG_CRYPTO_SHA256_ARM=m
+CONFIG_CRYPTO_SHA512_ARM=m
+CONFIG_CRYPTO_AES_ARM_BS=m
CONFIG_CRC_CCITT=y
CONFIG_FONTS=y
CONFIG_FONT_7x14=y
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats
@ 2016-01-07 2:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-07 2:15 UTC (permalink / raw)
To: linux-arm-kernel
Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
which should bring performance benefits on Exynos SoCs. Enable these as
modules because they are optional, not essential anyhow for platform
booting nor related directly to Exynos Soc. All accelerated algorithms
pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
Additionally enable cpufreq statistics as they are useful for debugging.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/configs/exynos_defconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 24dcd2bb1215..0aee1e035be9 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -26,12 +26,14 @@ CONFIG_ARM_APPENDED_DTB=y
CONFIG_ARM_ATAG_DTB_COMPAT=y
CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc mem=256M"
CONFIG_CPU_FREQ=y
+CONFIG_CPU_FREQ_STAT_DETAILS=y
CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
CONFIG_CPUFREQ_DT=y
CONFIG_CPU_IDLE=y
CONFIG_ARM_EXYNOS_CPUIDLE=y
CONFIG_VFP=y
CONFIG_NEON=y
+CONFIG_KERNEL_MODE_NEON=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
@@ -238,7 +240,11 @@ CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_USER=y
-CONFIG_CRYPTO_SHA256=y
+CONFIG_ARM_CRYPTO=y
+CONFIG_CRYPTO_SHA1_ARM_NEON=m
+CONFIG_CRYPTO_SHA256_ARM=m
+CONFIG_CRYPTO_SHA512_ARM=m
+CONFIG_CRYPTO_AES_ARM_BS=m
CONFIG_CRC_CCITT=y
CONFIG_FONTS=y
CONFIG_FONT_7x14=y
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
2016-01-07 2:15 ` Krzysztof Kozlowski
@ 2016-01-07 2:15 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-07 2:15 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas,
Anand Moon, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: tjakobi
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.
Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
The cbc-aes-s5p properly registers itself and passes self-tests.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 0aee1e035be9..c47c7e069873 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_USER=y
+CONFIG_CRYPTO_DEV_S5P=y
CONFIG_ARM_CRYPTO=y
CONFIG_CRYPTO_SHA1_ARM_NEON=m
CONFIG_CRYPTO_SHA256_ARM=m
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
@ 2016-01-07 2:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-07 2:15 UTC (permalink / raw)
To: linux-arm-kernel
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.
Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
The cbc-aes-s5p properly registers itself and passes self-tests.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 0aee1e035be9..c47c7e069873 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_USER=y
+CONFIG_CRYPTO_DEV_S5P=y
CONFIG_ARM_CRYPTO=y
CONFIG_CRYPTO_SHA1_ARM_NEON=m
CONFIG_CRYPTO_SHA256_ARM=m
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
2016-01-07 2:15 ` Krzysztof Kozlowski
@ 2016-01-07 17:12 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2016-01-07 17:12 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kukjin Kim, Javier Martinez Canillas, linux-arm-kernel,
linux-samsung-soc@vger.kernel.org, Linux Kernel, Tobias Jakobi
Hi Krzysztof,
On 7 January 2016 at 07:45, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
> CONFIG_ARM_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM_NEON=m
> CONFIG_CRYPTO_SHA256_ARM=m
> --
> 1.9.1
>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Best Regards,
-Anand Moon
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
@ 2016-01-07 17:12 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2016-01-07 17:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Krzysztof,
On 7 January 2016 at 07:45, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
> CONFIG_ARM_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM_NEON=m
> CONFIG_CRYPTO_SHA256_ARM=m
> --
> 1.9.1
>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Best Regards,
-Anand Moon
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
2016-01-07 2:15 ` Krzysztof Kozlowski
@ 2016-01-08 15:35 ` Javier Martinez Canillas
-1 siblings, 0 replies; 16+ messages in thread
From: Javier Martinez Canillas @ 2016-01-08 15:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, Anand Moon, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: tjakobi
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?
> CONFIG_ARM_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM_NEON=m
> CONFIG_CRYPTO_SHA256_ARM=m
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
@ 2016-01-08 15:35 ` Javier Martinez Canillas
0 siblings, 0 replies; 16+ messages in thread
From: Javier Martinez Canillas @ 2016-01-08 15:35 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?
> CONFIG_ARM_CRYPTO=y
> CONFIG_CRYPTO_SHA1_ARM_NEON=m
> CONFIG_CRYPTO_SHA256_ARM=m
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
2016-01-08 15:35 ` Javier Martinez Canillas
@ 2016-01-09 2:46 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-09 2:46 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Kukjin Kim, Anand Moon, linux-arm-kernel, linux-samsung-soc,
linux-kernel, tjakobi
2016-01-09 0:35 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> Hello Krzysztof,
>
> On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
>> The Exynos SoC provides a Security SubSystem block for accelerating some
>> cryptographic operations. Enable the driver for it - s5p-secss to
>> utilize the hardware acceleration.
>>
>> Currently the s5p-secss driver supports AES in CBC and ECB modes.
>> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
>> change introduces one booting error:
>>
>> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>>
>> The cbc-aes-s5p properly registers itself and passes self-tests.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> arch/arm/configs/exynos_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>> index 0aee1e035be9..c47c7e069873 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>> CONFIG_DEBUG_SPINLOCK=y
>> CONFIG_DEBUG_MUTEXES=y
>> CONFIG_DEBUG_USER=y
>> +CONFIG_CRYPTO_DEV_S5P=y
>
> I noticed that this is not enabled in multi_v7_defconfig.
> Are you planing to do it as well?
Thanks for feedback and review. I noticed that as well but I am not
convinced because one of two of supported algorithms fails the
tests... which makes 50% of driver non-working. :) Maybe it is
harmless - just pollutes the dmesg... Maybe after fixing it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
@ 2016-01-09 2:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-09 2:46 UTC (permalink / raw)
To: linux-arm-kernel
2016-01-09 0:35 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> Hello Krzysztof,
>
> On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
>> The Exynos SoC provides a Security SubSystem block for accelerating some
>> cryptographic operations. Enable the driver for it - s5p-secss to
>> utilize the hardware acceleration.
>>
>> Currently the s5p-secss driver supports AES in CBC and ECB modes.
>> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
>> change introduces one booting error:
>>
>> alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>>
>> The cbc-aes-s5p properly registers itself and passes self-tests.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> arch/arm/configs/exynos_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>> index 0aee1e035be9..c47c7e069873 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>> CONFIG_DEBUG_SPINLOCK=y
>> CONFIG_DEBUG_MUTEXES=y
>> CONFIG_DEBUG_USER=y
>> +CONFIG_CRYPTO_DEV_S5P=y
>
> I noticed that this is not enabled in multi_v7_defconfig.
> Are you planing to do it as well?
Thanks for feedback and review. I noticed that as well but I am not
convinced because one of two of supported algorithms fails the
tests... which makes 50% of driver non-working. :) Maybe it is
harmless - just pollutes the dmesg... Maybe after fixing it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
2016-01-09 2:46 ` Krzysztof Kozlowski
@ 2016-01-11 16:04 ` Javier Martinez Canillas
-1 siblings, 0 replies; 16+ messages in thread
From: Javier Martinez Canillas @ 2016-01-11 16:04 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kukjin Kim, Anand Moon, linux-arm-kernel, linux-samsung-soc,
linux-kernel, tjakobi
Hello Krzysztof,
On 01/08/2016 11:46 PM, Krzysztof Kozlowski wrote:
[snip]
>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>>> CONFIG_DEBUG_SPINLOCK=y
>>> CONFIG_DEBUG_MUTEXES=y
>>> CONFIG_DEBUG_USER=y
>>> +CONFIG_CRYPTO_DEV_S5P=y
>>
>> I noticed that this is not enabled in multi_v7_defconfig.
>> Are you planing to do it as well?
>
> Thanks for feedback and review. I noticed that as well but I am not
> convinced because one of two of supported algorithms fails the
> tests... which makes 50% of driver non-working. :) Maybe it is
> harmless - just pollutes the dmesg... Maybe after fixing it.
>
Agreed that can be done after fixing the driver.
> Best regards,
> Krzysztof
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
@ 2016-01-11 16:04 ` Javier Martinez Canillas
0 siblings, 0 replies; 16+ messages in thread
From: Javier Martinez Canillas @ 2016-01-11 16:04 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 01/08/2016 11:46 PM, Krzysztof Kozlowski wrote:
[snip]
>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>>> CONFIG_DEBUG_SPINLOCK=y
>>> CONFIG_DEBUG_MUTEXES=y
>>> CONFIG_DEBUG_USER=y
>>> +CONFIG_CRYPTO_DEV_S5P=y
>>
>> I noticed that this is not enabled in multi_v7_defconfig.
>> Are you planing to do it as well?
>
> Thanks for feedback and review. I noticed that as well but I am not
> convinced because one of two of supported algorithms fails the
> tests... which makes 50% of driver non-working. :) Maybe it is
> harmless - just pollutes the dmesg... Maybe after fixing it.
>
Agreed that can be done after fixing the driver.
> Best regards,
> Krzysztof
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats
2016-01-07 2:15 ` Krzysztof Kozlowski
@ 2016-01-07 17:10 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2016-01-07 17:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kukjin Kim, Javier Martinez Canillas, linux-arm-kernel,
linux-samsung-soc@vger.kernel.org, Linux Kernel, Tobias Jakobi
Hi Krzysztof,
On 7 January 2016 at 07:45, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
> which should bring performance benefits on Exynos SoCs. Enable these as
> modules because they are optional, not essential anyhow for platform
> booting nor related directly to Exynos Soc. All accelerated algorithms
> pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
>
> Additionally enable cpufreq statistics as they are useful for debugging.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 24dcd2bb1215..0aee1e035be9 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -26,12 +26,14 @@ CONFIG_ARM_APPENDED_DTB=y
> CONFIG_ARM_ATAG_DTB_COMPAT=y
> CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc mem=256M"
> CONFIG_CPU_FREQ=y
> +CONFIG_CPU_FREQ_STAT_DETAILS=y
> CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> CONFIG_CPUFREQ_DT=y
> CONFIG_CPU_IDLE=y
> CONFIG_ARM_EXYNOS_CPUIDLE=y
> CONFIG_VFP=y
> CONFIG_NEON=y
> +CONFIG_KERNEL_MODE_NEON=y
> CONFIG_NET=y
> CONFIG_PACKET=y
> CONFIG_UNIX=y
> @@ -238,7 +240,11 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> -CONFIG_CRYPTO_SHA256=y
> +CONFIG_ARM_CRYPTO=y
> +CONFIG_CRYPTO_SHA1_ARM_NEON=m
> +CONFIG_CRYPTO_SHA256_ARM=m
> +CONFIG_CRYPTO_SHA512_ARM=m
> +CONFIG_CRYPTO_AES_ARM_BS=m
> CONFIG_CRC_CCITT=y
> CONFIG_FONTS=y
> CONFIG_FONT_7x14=y
> --
> 1.9.1
>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Best Regards,
-Anand Moon
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats
@ 2016-01-07 17:10 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2016-01-07 17:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Krzysztof,
On 7 January 2016 at 07:45, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
> which should bring performance benefits on Exynos SoCs. Enable these as
> modules because they are optional, not essential anyhow for platform
> booting nor related directly to Exynos Soc. All accelerated algorithms
> pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
>
> Additionally enable cpufreq statistics as they are useful for debugging.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 24dcd2bb1215..0aee1e035be9 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -26,12 +26,14 @@ CONFIG_ARM_APPENDED_DTB=y
> CONFIG_ARM_ATAG_DTB_COMPAT=y
> CONFIG_CMDLINE="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc mem=256M"
> CONFIG_CPU_FREQ=y
> +CONFIG_CPU_FREQ_STAT_DETAILS=y
> CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
> CONFIG_CPUFREQ_DT=y
> CONFIG_CPU_IDLE=y
> CONFIG_ARM_EXYNOS_CPUIDLE=y
> CONFIG_VFP=y
> CONFIG_NEON=y
> +CONFIG_KERNEL_MODE_NEON=y
> CONFIG_NET=y
> CONFIG_PACKET=y
> CONFIG_UNIX=y
> @@ -238,7 +240,11 @@ CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
> -CONFIG_CRYPTO_SHA256=y
> +CONFIG_ARM_CRYPTO=y
> +CONFIG_CRYPTO_SHA1_ARM_NEON=m
> +CONFIG_CRYPTO_SHA256_ARM=m
> +CONFIG_CRYPTO_SHA512_ARM=m
> +CONFIG_CRYPTO_AES_ARM_BS=m
> CONFIG_CRC_CCITT=y
> CONFIG_FONTS=y
> CONFIG_FONT_7x14=y
> --
> 1.9.1
>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Best Regards,
-Anand Moon
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats
2016-01-07 2:15 ` Krzysztof Kozlowski
@ 2016-01-08 15:32 ` Javier Martinez Canillas
-1 siblings, 0 replies; 16+ messages in thread
From: Javier Martinez Canillas @ 2016-01-08 15:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, Anand Moon, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: tjakobi
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
> which should bring performance benefits on Exynos SoCs. Enable these as
> modules because they are optional, not essential anyhow for platform
> booting nor related directly to Exynos Soc. All accelerated algorithms
> pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
>
> Additionally enable cpufreq statistics as they are useful for debugging.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats
@ 2016-01-08 15:32 ` Javier Martinez Canillas
0 siblings, 0 replies; 16+ messages in thread
From: Javier Martinez Canillas @ 2016-01-08 15:32 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
> which should bring performance benefits on Exynos SoCs. Enable these as
> modules because they are optional, not essential anyhow for platform
> booting nor related directly to Exynos Soc. All accelerated algorithms
> pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
>
> Additionally enable cpufreq statistics as they are useful for debugging.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-01-11 16:04 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 2:15 [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats Krzysztof Kozlowski
2016-01-07 2:15 ` Krzysztof Kozlowski
2016-01-07 2:15 ` [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Krzysztof Kozlowski
2016-01-07 2:15 ` Krzysztof Kozlowski
2016-01-07 17:12 ` Anand Moon
2016-01-07 17:12 ` Anand Moon
2016-01-08 15:35 ` Javier Martinez Canillas
2016-01-08 15:35 ` Javier Martinez Canillas
2016-01-09 2:46 ` Krzysztof Kozlowski
2016-01-09 2:46 ` Krzysztof Kozlowski
2016-01-11 16:04 ` Javier Martinez Canillas
2016-01-11 16:04 ` Javier Martinez Canillas
2016-01-07 17:10 ` [PATCH 1/2] ARM: exynos_defconfig: Enable NEON, accelerated crypto and cpufreq stats Anand Moon
2016-01-07 17:10 ` Anand Moon
2016-01-08 15:32 ` Javier Martinez Canillas
2016-01-08 15:32 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.