Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes

[Dirk Behme <dirk.behme@gmail.com>]

On 18.12.2015 11:47, Sudeep Holla wrote:
>
>
> On 18/12/15 10:44, Dirk Behme wrote:
>> On 18.12.2015 11:16, Sudeep Holla wrote:
>>>
>>>
>>> On 18/12/15 02:29, Simon Horman wrote:
>>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>
>>>> Enabling the performance monitor unit on r8a7795.
>>>>
>>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>> ---
>>>>   arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>>>   1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> index 4d43cf31418f..b9229a49dabc 100644
>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> @@ -230,6 +230,18 @@
>>>>               power-domains = <&cpg>;
>>>>           };
>>>>
>>>> +        pmu {
>>>> +            compatible = "arm,armv8-pmuv3";
>>>
>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>> this
>>> for some shmobile platform recently.
>>
>>
>> Yes. But as this patch has been applied already to some branches, I
>> incorporated your a57-pmu hint with an additional update patch:
>>
>> http://marc.info/?l=linux-sh&m\x145011467914857
>>
>> Feel free to squash if still possible.
>>
>
> Ah OK, I didn't know the exact dts name, sorry for the noise.
> Better if it was posted as part of this series :)


I finally found some time to test this

http://marc.info/?l=linux-sh&m\x145011467914857

and surprisingly it doesn't seem to work:

Using "arm,cortex-a57-pmu" results in

hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters 
available
hw perfevents: failed to probe PMU!
hw perfevents: failed to register PMU devices!

while switching back to "arm,armv8-pmuv3" successfully gives

hw perfevents: enabled with armv8_pmuv3 PMU driver, 7 counters available

without any further error messages.

Any idea?

Best regards

Dirk