Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes

[Sudeep Holla <sudeep.holla@arm.com>]

On 09/01/16 06:36, Dirk Behme wrote:
> On 18.12.2015 11:47, Sudeep Holla wrote:
>>
>>
>> On 18/12/15 10:44, Dirk Behme wrote:
>>> On 18.12.2015 11:16, Sudeep Holla wrote:

[...]

>>>>
>>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>>> this for some shmobile platform recently.
>>>
>>> Yes. But as this patch has been applied already to some branches, I
>>> incorporated your a57-pmu hint with an additional update patch:
>>>
>>> http://marc.info/?l=linux-sh&m\x145011467914857
>>>
>>> Feel free to squash if still possible.
>>>
>>
>> Ah OK, I didn't know the exact dts name, sorry for the noise.
>> Better if it was posted as part of this series :)
>
>
> I finally found some time to test this
>
> http://marc.info/?l=linux-sh&m\x145011467914857
>
> and surprisingly it doesn't seem to work:
>
> Using "arm,cortex-a57-pmu" results in
>
> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters available

I had a quick look at the DT in the link above and IIUC A57 PMU's are
successfully probed.

> hw perfevents: failed to probe PMU!
> hw perfevents: failed to register PMU devices!
>

This must be for A53 PMUs. So I suspect if the update DT is passed
correctly to the kernel.

> while switching back to "arm,armv8-pmuv3" successfully gives
>
> hw perfevents: enabled with armv8_pmuv3 PMU driver, 7 counters available
>
> without any further error messages.
>
> Any idea?

You need to check if of_pmu_irq_cfg is failing.
Is the updated DT picked up correctly ?

-- 
Regards,
Sudeep