* [PATCH] rtc: max77xxx: fix of_table.cocci warnings
@ 2016-01-12 11:27 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-01-12 11:27 UTC (permalink / raw)
To: Laxman Dewangan
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linus.walleij, gnurou, lee.jones, broonie, a.zummo,
alexandre.belloni, lgirdwood, devicetree, linux-kernel,
linux-gpio, rtc-linux, swarren, treding, k.kozlowski
Make sure (of/i2c/platform)_device_id tables are NULL terminated
Generated by: scripts/coccinelle/misc/of_table.cocci
CC: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
Please take the patch only if it's a positive warning. Thanks!
rtc-max77xxx.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/rtc/rtc-max77xxx.c
+++ b/drivers/rtc/rtc-max77xxx.c
@@ -480,6 +480,7 @@ static const struct platform_device_id m
{ .name = "max77xxx-rtc", },
{ .name = "max77620-rtc", },
{ .name = "max20024-rtc", },
+ {},
};
static struct platform_driver max77xxx_rtc_driver = {
^ permalink raw reply [flat|nested] 6+ messages in thread* [rtc-linux] [PATCH] rtc: max77xxx: fix of_table.cocci warnings
@ 2016-01-12 11:27 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-01-12 11:27 UTC (permalink / raw)
To: Laxman Dewangan
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linus.walleij, gnurou, lee.jones, broonie, a.zummo,
alexandre.belloni, lgirdwood, devicetree, linux-kernel,
linux-gpio, rtc-linux, swarren, treding, k.kozlowski
Make sure (of/i2c/platform)_device_id tables are NULL terminated
Generated by: scripts/coccinelle/misc/of_table.cocci
CC: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
Please take the patch only if it's a positive warning. Thanks!
rtc-max77xxx.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/rtc/rtc-max77xxx.c
+++ b/drivers/rtc/rtc-max77xxx.c
@@ -480,6 +480,7 @@ static const struct platform_device_id m
{ .name = "max77xxx-rtc", },
{ .name = "max77620-rtc", },
{ .name = "max20024-rtc", },
+ {},
};
static struct platform_driver max77xxx_rtc_driver = {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings
2016-01-12 11:27 ` [rtc-linux] " Julia Lawall
(?)
@ 2016-01-12 11:20 ` Laxman Dewangan
-1 siblings, 0 replies; 6+ messages in thread
From: Laxman Dewangan @ 2016-01-12 11:20 UTC (permalink / raw)
To: Julia Lawall
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linus.walleij, gnurou, lee.jones, broonie, a.zummo,
alexandre.belloni, lgirdwood, devicetree, linux-kernel,
linux-gpio, rtc-linux, swarren, treding, k.kozlowski
Hi Julia,
Thanks for pointing this issue.
What script do you run to get this error?
I tried to run script/coccicheck and it did not showed this issue.
When I run make with coccicheck per Documentation, it did not show
specific to this error. Although, there was lots of output.
I want to get this type of error by running script.
Any command for this?
Thanks,
Laxman
On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> rtc-max77xxx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/rtc/rtc-max77xxx.c
> +++ b/drivers/rtc/rtc-max77xxx.c
> @@ -480,6 +480,7 @@ static const struct platform_device_id m
> { .name = "max77xxx-rtc", },
> { .name = "max77620-rtc", },
> { .name = "max20024-rtc", },
> + {},
> };
>
> static struct platform_driver max77xxx_rtc_driver = {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings
@ 2016-01-12 11:20 ` Laxman Dewangan
0 siblings, 0 replies; 6+ messages in thread
From: Laxman Dewangan @ 2016-01-12 11:20 UTC (permalink / raw)
To: Julia Lawall
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linus.walleij, gnurou, lee.jones, broonie, a.zummo,
alexandre.belloni, lgirdwood, devicetree, linux-kernel,
linux-gpio, rtc-linux, swarren, treding, k.kozlowski
Hi Julia,
Thanks for pointing this issue.
What script do you run to get this error?
I tried to run script/coccicheck and it did not showed this issue.
When I run make with coccicheck per Documentation, it did not show
specific to this error. Although, there was lots of output.
I want to get this type of error by running script.
Any command for this?
Thanks,
Laxman
On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> rtc-max77xxx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/rtc/rtc-max77xxx.c
> +++ b/drivers/rtc/rtc-max77xxx.c
> @@ -480,6 +480,7 @@ static const struct platform_device_id m
> { .name = "max77xxx-rtc", },
> { .name = "max77620-rtc", },
> { .name = "max20024-rtc", },
> + {},
> };
>
> static struct platform_driver max77xxx_rtc_driver = {
^ permalink raw reply [flat|nested] 6+ messages in thread* [rtc-linux] Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings
@ 2016-01-12 11:20 ` Laxman Dewangan
0 siblings, 0 replies; 6+ messages in thread
From: Laxman Dewangan @ 2016-01-12 11:20 UTC (permalink / raw)
To: Julia Lawall
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linus.walleij, gnurou, lee.jones, broonie, a.zummo,
alexandre.belloni, lgirdwood, devicetree, linux-kernel,
linux-gpio, rtc-linux, swarren, treding, k.kozlowski
Hi Julia,
Thanks for pointing this issue.
What script do you run to get this error?
I tried to run script/coccicheck and it did not showed this issue.
When I run make with coccicheck per Documentation, it did not show
specific to this error. Although, there was lots of output.
I want to get this type of error by running script.
Any command for this?
Thanks,
Laxman
On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> rtc-max77xxx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/rtc/rtc-max77xxx.c
> +++ b/drivers/rtc/rtc-max77xxx.c
> @@ -480,6 +480,7 @@ static const struct platform_device_id m
> { .name = "max77xxx-rtc", },
> { .name = "max77620-rtc", },
> { .name = "max20024-rtc", },
> + {},
> };
>
> static struct platform_driver max77xxx_rtc_driver = {
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread