All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, julia.lawall@lip6.fr,
	kbuild-all@01.org, daniel.vetter@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Date: Mon, 18 Jan 2016 17:42:24 +0000	[thread overview]
Message-ID: <569D2400.9030702@imgtec.com> (raw)
In-Reply-To: <20160118172025.GM19130@phenom.ffwll.local>

I expect this is the script she mentions:
https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci

Julia is one of the authors of Coccinelle, and the author of that script :)


On 18/01/16 17:20, Daniel Vetter wrote:
> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
>> List_for_each entry binds its first argument to an offset from the list
>> pointer, so this should not be NULL.
>>
>> Generated by: scripts/coccinelle/iterators/itnull.cocci
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>> Please take the patch only if it's a positive warning. Thanks!
> 
> Against which tree is this? I can't find this anywhere like that ...
> -Daniel
> 
>>
>>  intel_display.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
>>  		struct intel_flip_work *work;
>>
>>  		list_for_each_entry(work, &crtc->flip_work, head) {
>> -			if (work && work->event &&
>> +			if (work->event &&
>>  			    work->event->base.file_priv == file) {
>>  				kfree(work->event);
>>  				work->event = NULL;
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: <daniel@ffwll.ch>
Cc: <julia.lawall@lip6.fr>, <dri-devel@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<daniel.vetter@intel.com>, <kbuild-all@01.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Date: Mon, 18 Jan 2016 17:42:24 +0000	[thread overview]
Message-ID: <569D2400.9030702@imgtec.com> (raw)
In-Reply-To: <20160118172025.GM19130@phenom.ffwll.local>

I expect this is the script she mentions:
https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci

Julia is one of the authors of Coccinelle, and the author of that script :)


On 18/01/16 17:20, Daniel Vetter wrote:
> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
>> List_for_each entry binds its first argument to an offset from the list
>> pointer, so this should not be NULL.
>>
>> Generated by: scripts/coccinelle/iterators/itnull.cocci
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>> Please take the patch only if it's a positive warning. Thanks!
> 
> Against which tree is this? I can't find this anywhere like that ...
> -Daniel
> 
>>
>>  intel_display.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
>>  		struct intel_flip_work *work;
>>
>>  		list_for_each_entry(work, &crtc->flip_work, head) {
>> -			if (work && work->event &&
>> +			if (work->event &&
>>  			    work->event->base.file_priv == file) {
>>  				kfree(work->event);
>>  				work->event = NULL;
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 

  reply	other threads:[~2016-01-18 17:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 15:49 [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Julia Lawall
2016-01-18 15:49 ` Julia Lawall
2016-01-18 17:20 ` [Intel-gfx] " Daniel Vetter
2016-01-18 17:20   ` Daniel Vetter
2016-01-18 17:42   ` Eric Engestrom [this message]
2016-01-18 17:42     ` Eric Engestrom
2016-01-18 18:02     ` Daniel Vetter
2016-01-18 18:02       ` [Intel-gfx] " Daniel Vetter
2016-01-18 20:20   ` Julia Lawall
2016-01-18 20:20     ` [Intel-gfx] " Julia Lawall
2016-01-20 10:05   ` Maarten Lankhorst
2016-01-20 10:05     ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569D2400.9030702@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=daniel.vetter@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=julia.lawall@lip6.fr \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.