From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
patches@opensource.wolfsnmicro.com
Subject: Re: [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
Date: Fri, 22 Jan 2016 09:21:44 +0900 [thread overview]
Message-ID: <56A17618.4030008@samsung.com> (raw)
In-Reply-To: <1453400718-26720-1-git-send-email-broonie@kernel.org>
On 22.01.2016 03:25, Mark Brown wrote:
> The Cragganmore machine driver provides platform data for the generic GPIO
> platform driver which uses structures only defined if the driver is
> enabled. Since there is little reason to use the platform without the GPIOs
> add a select to avoid build failures.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm/mach-s3c64xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 7c0c420c3016..98d2aa9393f1 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
> depends on I2C=y
> select CPU_S3C6410
> select LEDS_GPIO_REGISTER
> + select GPIO_GENERIC_PLATFORM
> select S3C64XX_DEV_SPI0
> select S3C64XX_SETUP_FB_24BPP
> select S3C64XX_SETUP_I2C1
>
Thanks for the patch!
This was already fixed by Arnd:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
Date: Fri, 22 Jan 2016 09:21:44 +0900 [thread overview]
Message-ID: <56A17618.4030008@samsung.com> (raw)
In-Reply-To: <1453400718-26720-1-git-send-email-broonie@kernel.org>
On 22.01.2016 03:25, Mark Brown wrote:
> The Cragganmore machine driver provides platform data for the generic GPIO
> platform driver which uses structures only defined if the driver is
> enabled. Since there is little reason to use the platform without the GPIOs
> add a select to avoid build failures.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm/mach-s3c64xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 7c0c420c3016..98d2aa9393f1 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
> depends on I2C=y
> select CPU_S3C6410
> select LEDS_GPIO_REGISTER
> + select GPIO_GENERIC_PLATFORM
> select S3C64XX_DEV_SPI0
> select S3C64XX_SETUP_FB_24BPP
> select S3C64XX_SETUP_I2C1
>
Thanks for the patch!
This was already fixed by Arnd:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-01-22 0:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 18:25 [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore Mark Brown
2016-01-21 18:25 ` Mark Brown
2016-01-22 0:21 ` Krzysztof Kozlowski [this message]
2016-01-22 0:21 ` Krzysztof Kozlowski
2016-01-26 15:10 ` Charles Keepax
2016-01-26 15:10 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A17618.4030008@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsnmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.