* [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
@ 2016-01-21 18:25 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2016-01-21 18:25 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, patches, Mark Brown
The Cragganmore machine driver provides platform data for the generic GPIO
platform driver which uses structures only defined if the driver is
enabled. Since there is little reason to use the platform without the GPIOs
add a select to avoid build failures.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm/mach-s3c64xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 7c0c420c3016..98d2aa9393f1 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
depends on I2C=y
select CPU_S3C6410
select LEDS_GPIO_REGISTER
+ select GPIO_GENERIC_PLATFORM
select S3C64XX_DEV_SPI0
select S3C64XX_SETUP_FB_24BPP
select S3C64XX_SETUP_I2C1
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
@ 2016-01-21 18:25 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2016-01-21 18:25 UTC (permalink / raw)
To: linux-arm-kernel
The Cragganmore machine driver provides platform data for the generic GPIO
platform driver which uses structures only defined if the driver is
enabled. Since there is little reason to use the platform without the GPIOs
add a select to avoid build failures.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm/mach-s3c64xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 7c0c420c3016..98d2aa9393f1 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
depends on I2C=y
select CPU_S3C6410
select LEDS_GPIO_REGISTER
+ select GPIO_GENERIC_PLATFORM
select S3C64XX_DEV_SPI0
select S3C64XX_SETUP_FB_24BPP
select S3C64XX_SETUP_I2C1
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
2016-01-21 18:25 ` Mark Brown
@ 2016-01-22 0:21 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-22 0:21 UTC (permalink / raw)
To: Mark Brown, Kukjin Kim; +Cc: linux-arm-kernel, linux-samsung-soc, patches
On 22.01.2016 03:25, Mark Brown wrote:
> The Cragganmore machine driver provides platform data for the generic GPIO
> platform driver which uses structures only defined if the driver is
> enabled. Since there is little reason to use the platform without the GPIOs
> add a select to avoid build failures.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm/mach-s3c64xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 7c0c420c3016..98d2aa9393f1 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
> depends on I2C=y
> select CPU_S3C6410
> select LEDS_GPIO_REGISTER
> + select GPIO_GENERIC_PLATFORM
> select S3C64XX_DEV_SPI0
> select S3C64XX_SETUP_FB_24BPP
> select S3C64XX_SETUP_I2C1
>
Thanks for the patch!
This was already fixed by Arnd:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
@ 2016-01-22 0:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-22 0:21 UTC (permalink / raw)
To: linux-arm-kernel
On 22.01.2016 03:25, Mark Brown wrote:
> The Cragganmore machine driver provides platform data for the generic GPIO
> platform driver which uses structures only defined if the driver is
> enabled. Since there is little reason to use the platform without the GPIOs
> add a select to avoid build failures.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm/mach-s3c64xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 7c0c420c3016..98d2aa9393f1 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
> depends on I2C=y
> select CPU_S3C6410
> select LEDS_GPIO_REGISTER
> + select GPIO_GENERIC_PLATFORM
> select S3C64XX_DEV_SPI0
> select S3C64XX_SETUP_FB_24BPP
> select S3C64XX_SETUP_I2C1
>
Thanks for the patch!
This was already fixed by Arnd:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
2016-01-21 18:25 ` Mark Brown
@ 2016-01-26 15:10 ` Charles Keepax
-1 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2016-01-26 15:10 UTC (permalink / raw)
To: Mark Brown
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-arm-kernel,
linux-samsung-soc, patches
On Thu, Jan 21, 2016 at 06:25:18PM +0000, Mark Brown wrote:
> The Cragganmore machine driver provides platform data for the generic GPIO
> platform driver which uses structures only defined if the driver is
> enabled. Since there is little reason to use the platform without the GPIOs
> add a select to avoid build failures.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
All looks good to me and doesn't cause any issues on my Speyside.
Tested-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore
@ 2016-01-26 15:10 ` Charles Keepax
0 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2016-01-26 15:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 21, 2016 at 06:25:18PM +0000, Mark Brown wrote:
> The Cragganmore machine driver provides platform data for the generic GPIO
> platform driver which uses structures only defined if the driver is
> enabled. Since there is little reason to use the platform without the GPIOs
> add a select to avoid build failures.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
All looks good to me and doesn't cause any issues on my Speyside.
Tested-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-26 15:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 18:25 [PATCH] ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore Mark Brown
2016-01-21 18:25 ` Mark Brown
2016-01-22 0:21 ` Krzysztof Kozlowski
2016-01-22 0:21 ` Krzysztof Kozlowski
2016-01-26 15:10 ` Charles Keepax
2016-01-26 15:10 ` Charles Keepax
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.