From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
peter.maydell@linaro.org
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>,
xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init()
Date: Fri, 22 Jan 2016 12:21:40 +0100 [thread overview]
Message-ID: <56A210C4.9040407@redhat.com> (raw)
In-Reply-To: <1453395690-32660-10-git-send-email-stefano.stabellini@eu.citrix.com>
On 21/01/2016 18:01, Stefano Stabellini wrote:
> - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n",
> - j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> - regs->offset, xen_pt_emu_reg_grps[i].grp_type,
> - i, ARRAY_SIZE(xen_pt_emu_reg_grps), rc);
> + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err);
> + if (err) {
> + error_append_hint(&err, "Failed to initialize %d/%zu"
> + " reg 0x%x in grp_type = 0x%x (%d/%zu)",
> + j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
Coverity noticed a preexisting problem here. emu_regs is a pointer,
thus ARRAY_SIZE doesn't return what you expect.
Paolo
> + regs->offset, xen_pt_emu_reg_grps[i].grp_type,
> + i, ARRAY_SIZE(xen_pt_emu_reg_grps));
> + error_propagate(errp, err);
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
peter.maydell@linaro.org
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>,
xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [PULL 10/11] Add Error **errp for xen_pt_config_init()
Date: Fri, 22 Jan 2016 12:21:40 +0100 [thread overview]
Message-ID: <56A210C4.9040407@redhat.com> (raw)
In-Reply-To: <1453395690-32660-10-git-send-email-stefano.stabellini@eu.citrix.com>
On 21/01/2016 18:01, Stefano Stabellini wrote:
> - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n",
> - j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> - regs->offset, xen_pt_emu_reg_grps[i].grp_type,
> - i, ARRAY_SIZE(xen_pt_emu_reg_grps), rc);
> + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err);
> + if (err) {
> + error_append_hint(&err, "Failed to initialize %d/%zu"
> + " reg 0x%x in grp_type = 0x%x (%d/%zu)",
> + j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
Coverity noticed a preexisting problem here. emu_regs is a pointer,
thus ARRAY_SIZE doesn't return what you expect.
Paolo
> + regs->offset, xen_pt_emu_reg_grps[i].grp_type,
> + i, ARRAY_SIZE(xen_pt_emu_reg_grps));
> + error_propagate(errp, err);
next prev parent reply other threads:[~2016-01-22 11:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 17:01 [Qemu-devel] [PULL 0/11] xen-20160121 Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 01/11] MAINTAINERS: update Xen files Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 02/11] xenfb.c: avoid expensive loops when prod <= out_cons Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 03/11] xen-hvm: Clean up xen_hvm_init() error handling Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 04/11] xen-hvm: Clean up xen_ram_alloc() " Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 05/11] xen-pvdevice: convert to realize() Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 06/11] Change xen_host_pci_sysfs_path() to return void Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 07/11] Xen: use qemu_strtoul instead of strtol Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 08/11] Add Error **errp for xen_host_pci_device_get() Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 09/11] Add Error **errp for xen_pt_setup_vga() Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init() Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-22 11:21 ` Paolo Bonzini [this message]
2016-01-22 11:21 ` Paolo Bonzini
2016-01-23 12:23 ` [Qemu-devel] " Cao jin
2016-01-23 12:23 ` Cao jin
2016-01-25 10:53 ` [Qemu-devel] " Stefano Stabellini
2016-01-25 10:53 ` Stefano Stabellini
2016-01-21 17:01 ` [Qemu-devel] [PULL 11/11] Xen PCI passthru: convert to realize() Stefano Stabellini
2016-01-21 17:01 ` Stefano Stabellini
2016-01-21 17:45 ` [Qemu-devel] [PULL 0/11] xen-20160121 Peter Maydell
2016-01-21 17:45 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A210C4.9040407@redhat.com \
--to=pbonzini@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.