* [PATCH] ARM: bcm: use const and __initconst for smp_operations
@ 2016-01-25 11:31 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2016-01-25 11:31 UTC (permalink / raw)
To: linux-arm-kernel
This newly added code missed the global fixup by commit 75305275a721
("ARM: use const and __initconst for smp_operations"). So fix it now.
Also, add missing "static" qualifier.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/mach-bcm/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
index 575defc..cfae9c7 100644
--- a/arch/arm/mach-bcm/platsmp.c
+++ b/arch/arm/mach-bcm/platsmp.c
@@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
&bcm_smp_ops);
-struct smp_operations nsp_smp_ops __initdata = {
+static const struct smp_operations nsp_smp_ops __initconst = {
.smp_prepare_cpus = bcm_smp_prepare_cpus,
.smp_boot_secondary = nsp_boot_secondary,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: bcm: use const and __initconst for smp_operations
@ 2016-01-25 11:31 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2016-01-25 11:31 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masahiro Yamada, Scott Branden, linux-kernel, Russell King,
bcm-kernel-feedback-list, Florian Fainelli, Ray Jui
This newly added code missed the global fixup by commit 75305275a721
("ARM: use const and __initconst for smp_operations"). So fix it now.
Also, add missing "static" qualifier.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/mach-bcm/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
index 575defc..cfae9c7 100644
--- a/arch/arm/mach-bcm/platsmp.c
+++ b/arch/arm/mach-bcm/platsmp.c
@@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
&bcm_smp_ops);
-struct smp_operations nsp_smp_ops __initdata = {
+static const struct smp_operations nsp_smp_ops __initconst = {
.smp_prepare_cpus = bcm_smp_prepare_cpus,
.smp_boot_secondary = nsp_boot_secondary,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: bcm: use const and __initconst for smp_operations
2016-01-25 11:31 ` Masahiro Yamada
@ 2016-01-25 17:15 ` Ray Jui
-1 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2016-01-25 17:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi Masahiro,
On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
> This newly added code missed the global fixup by commit 75305275a721
> ("ARM: use const and __initconst for smp_operations"). So fix it now.
>
> Also, add missing "static" qualifier.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/mach-bcm/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 575defc..cfae9c7 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
> CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
> &bcm_smp_ops);
>
> -struct smp_operations nsp_smp_ops __initdata = {
> +static const struct smp_operations nsp_smp_ops __initconst = {
> .smp_prepare_cpus = bcm_smp_prepare_cpus,
> .smp_boot_secondary = nsp_boot_secondary,
> };
>
This fix looks good to me. Thanks!
Reviewed-by: Ray Jui <rjui@broadcom.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: bcm: use const and __initconst for smp_operations
@ 2016-01-25 17:15 ` Ray Jui
0 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2016-01-25 17:15 UTC (permalink / raw)
To: Masahiro Yamada, linux-arm-kernel
Cc: Scott Branden, linux-kernel, Russell King,
bcm-kernel-feedback-list, Florian Fainelli
Hi Masahiro,
On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
> This newly added code missed the global fixup by commit 75305275a721
> ("ARM: use const and __initconst for smp_operations"). So fix it now.
>
> Also, add missing "static" qualifier.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/mach-bcm/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 575defc..cfae9c7 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
> CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
> &bcm_smp_ops);
>
> -struct smp_operations nsp_smp_ops __initdata = {
> +static const struct smp_operations nsp_smp_ops __initconst = {
> .smp_prepare_cpus = bcm_smp_prepare_cpus,
> .smp_boot_secondary = nsp_boot_secondary,
> };
>
This fix looks good to me. Thanks!
Reviewed-by: Ray Jui <rjui@broadcom.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: bcm: use const and __initconst for smp_operations
2016-01-25 17:15 ` Ray Jui
@ 2016-02-01 21:11 ` Florian Fainelli
-1 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2016-02-01 21:11 UTC (permalink / raw)
To: linux-arm-kernel
On 25/01/16 09:15, Ray Jui wrote:
> Hi Masahiro,
>
> On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
>> This newly added code missed the global fixup by commit 75305275a721
>> ("ARM: use const and __initconst for smp_operations"). So fix it now.
>>
>> Also, add missing "static" qualifier.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied, thanks!
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: bcm: use const and __initconst for smp_operations
@ 2016-02-01 21:11 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2016-02-01 21:11 UTC (permalink / raw)
To: Ray Jui, Masahiro Yamada, linux-arm-kernel
Cc: Scott Branden, linux-kernel, Russell King,
bcm-kernel-feedback-list, Florian Fainelli
On 25/01/16 09:15, Ray Jui wrote:
> Hi Masahiro,
>
> On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
>> This newly added code missed the global fixup by commit 75305275a721
>> ("ARM: use const and __initconst for smp_operations"). So fix it now.
>>
>> Also, add missing "static" qualifier.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied, thanks!
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-01 21:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 11:31 [PATCH] ARM: bcm: use const and __initconst for smp_operations Masahiro Yamada
2016-01-25 11:31 ` Masahiro Yamada
2016-01-25 17:15 ` Ray Jui
2016-01-25 17:15 ` Ray Jui
2016-02-01 21:11 ` Florian Fainelli
2016-02-01 21:11 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.