From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] fbdev: s6e8ax0: avoid unused function warnings
Date: Tue, 26 Jan 2016 00:46:26 +0000 [thread overview]
Message-ID: <56A6C1E2.7060804@samsung.com> (raw)
In-Reply-To: <1453734300-1958304-1-git-send-email-arnd@arndb.de>
On 26.01.2016 00:04, Arnd Bergmann wrote:
> The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef
> when CONFIG_PM is set to avoid unused function warnings, but they
> call some other functions that nothing else calls, and we get warnings
> about those:
>
> drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function]
> drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function]
>
> This marks the PM functions as __maybe_unused so the compiler can
> silently drop them when they are not referenced.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Kukjin Kim <kgene@kernel.org>,
linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: s6e8ax0: avoid unused function warnings
Date: Tue, 26 Jan 2016 09:46:26 +0900 [thread overview]
Message-ID: <56A6C1E2.7060804@samsung.com> (raw)
In-Reply-To: <1453734300-1958304-1-git-send-email-arnd@arndb.de>
On 26.01.2016 00:04, Arnd Bergmann wrote:
> The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef
> when CONFIG_PM is set to avoid unused function warnings, but they
> call some other functions that nothing else calls, and we get warnings
> about those:
>
> drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function]
> drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function]
>
> This marks the PM functions as __maybe_unused so the compiler can
> silently drop them when they are not referenced.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fbdev: s6e8ax0: avoid unused function warnings
Date: Tue, 26 Jan 2016 09:46:26 +0900 [thread overview]
Message-ID: <56A6C1E2.7060804@samsung.com> (raw)
In-Reply-To: <1453734300-1958304-1-git-send-email-arnd@arndb.de>
On 26.01.2016 00:04, Arnd Bergmann wrote:
> The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef
> when CONFIG_PM is set to avoid unused function warnings, but they
> call some other functions that nothing else calls, and we get warnings
> about those:
>
> drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function]
> drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function]
>
> This marks the PM functions as __maybe_unused so the compiler can
> silently drop them when they are not referenced.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-01-26 0:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:04 [PATCH] fbdev: s6e8ax0: avoid unused function warnings Arnd Bergmann
2016-01-25 15:04 ` Arnd Bergmann
2016-01-25 15:04 ` Arnd Bergmann
2016-01-26 0:46 ` Krzysztof Kozlowski [this message]
2016-01-26 0:46 ` Krzysztof Kozlowski
2016-01-26 0:46 ` Krzysztof Kozlowski
2016-01-29 11:37 ` Tomi Valkeinen
2016-01-29 11:37 ` Tomi Valkeinen
2016-01-29 11:37 ` Tomi Valkeinen
2016-01-29 11:37 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6C1E2.7060804@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.