From: Yakir Yang <ykk@rock-chips.com>
To: Paul Bolle <pebolle@tiscali.nl>,
Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Ben Chan <benchan@google.com>, Ken Mixte <kmixter@google.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Thierry Reding <treding@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
Zheng Yang <zhengyang@rock-chips.com>
Subject: Re: [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support
Date: Tue, 26 Jan 2016 10:28:03 +0800 [thread overview]
Message-ID: <56A6D9B3.4070006@rock-chips.com> (raw)
In-Reply-To: <1453769119.17181.37.camel@tiscali.nl>
Hi Paul,
On 01/26/2016 08:45 AM, Paul Bolle wrote:
> On ma, 2016-01-25 at 09:47 +0800, Yakir Yang wrote:
>> --- a/drivers/gpu/drm/rockchip/Kconfig
>> +++ b/drivers/gpu/drm/rockchip/Kconfig
>> +config ROCKCHIP_INNO_HDMI
>> + tristate "Rockchip specific extensions for Innosilicon HDMI"
>> + depends on DRM_ROCKCHIP
>> + help
>> + This selects support for Rockchip SoC specific extensions
>> + for the Innosilicon HDMI driver. If you want to enable
>> + HDMI on RK3036 based SoC, you should selet this option.
> (Really trivial: start indentation with tabs only, please. And
> s/selet/select/.)
Got it
>> --- /dev/null
>> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
>> + * This software is licensed under the terms of the GNU General
>> Public
>> + * License version 2, as published by the Free Software Foundation,
>> and
>> + * may be copied, distributed, and modified under those terms.
> This states this file is licensed GPL v2 only.
>
>> +MODULE_LICENSE("GPL");
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
>
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
Ah, thanks.
- Yakir
> Thanks,
>
>
> Paul Bolle
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: ykk@rock-chips.com (Yakir Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support
Date: Tue, 26 Jan 2016 10:28:03 +0800 [thread overview]
Message-ID: <56A6D9B3.4070006@rock-chips.com> (raw)
In-Reply-To: <1453769119.17181.37.camel@tiscali.nl>
Hi Paul,
On 01/26/2016 08:45 AM, Paul Bolle wrote:
> On ma, 2016-01-25 at 09:47 +0800, Yakir Yang wrote:
>> --- a/drivers/gpu/drm/rockchip/Kconfig
>> +++ b/drivers/gpu/drm/rockchip/Kconfig
>> +config ROCKCHIP_INNO_HDMI
>> + tristate "Rockchip specific extensions for Innosilicon HDMI"
>> + depends on DRM_ROCKCHIP
>> + help
>> + This selects support for Rockchip SoC specific extensions
>> + for the Innosilicon HDMI driver. If you want to enable
>> + HDMI on RK3036 based SoC, you should selet this option.
> (Really trivial: start indentation with tabs only, please. And
> s/selet/select/.)
Got it
>> --- /dev/null
>> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
>> + * This software is licensed under the terms of the GNU General
>> Public
>> + * License version 2, as published by the Free Software Foundation,
>> and
>> + * may be copied, distributed, and modified under those terms.
> This states this file is licensed GPL v2 only.
>
>> +MODULE_LICENSE("GPL");
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
>
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
Ah, thanks.
- Yakir
> Thanks,
>
>
> Paul Bolle
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Yakir Yang <ykk@rock-chips.com>
To: Paul Bolle <pebolle@tiscali.nl>,
Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>
Cc: Thierry Reding <treding@nvidia.com>,
Rob Herring <robh+dt@kernel.org>, Ken Mixte <kmixter@google.com>,
Ben Chan <benchan@google.com>,
Zheng Yang <zhengyang@rock-chips.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support
Date: Tue, 26 Jan 2016 10:28:03 +0800 [thread overview]
Message-ID: <56A6D9B3.4070006@rock-chips.com> (raw)
In-Reply-To: <1453769119.17181.37.camel@tiscali.nl>
Hi Paul,
On 01/26/2016 08:45 AM, Paul Bolle wrote:
> On ma, 2016-01-25 at 09:47 +0800, Yakir Yang wrote:
>> --- a/drivers/gpu/drm/rockchip/Kconfig
>> +++ b/drivers/gpu/drm/rockchip/Kconfig
>> +config ROCKCHIP_INNO_HDMI
>> + tristate "Rockchip specific extensions for Innosilicon HDMI"
>> + depends on DRM_ROCKCHIP
>> + help
>> + This selects support for Rockchip SoC specific extensions
>> + for the Innosilicon HDMI driver. If you want to enable
>> + HDMI on RK3036 based SoC, you should selet this option.
> (Really trivial: start indentation with tabs only, please. And
> s/selet/select/.)
Got it
>> --- /dev/null
>> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
>> + * This software is licensed under the terms of the GNU General
>> Public
>> + * License version 2, as published by the Free Software Foundation,
>> and
>> + * may be copied, distributed, and modified under those terms.
> This states this file is licensed GPL v2 only.
>
>> +MODULE_LICENSE("GPL");
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
>
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
Ah, thanks.
- Yakir
> Thanks,
>
>
> Paul Bolle
>
>
>
next prev parent reply other threads:[~2016-01-26 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 1:43 [PATCH v6 0/1] Introduce Innosilicon HDMI driver on Rockchip platforms Yakir Yang
2016-01-25 1:43 ` Yakir Yang
2016-01-25 1:43 ` Yakir Yang
2016-01-25 1:47 ` [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support Yakir Yang
2016-01-25 1:47 ` Yakir Yang
2016-01-25 1:47 ` Yakir Yang
[not found] ` <1453686430-21470-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-26 0:45 ` Paul Bolle
2016-01-26 0:45 ` Paul Bolle
2016-01-26 0:45 ` Paul Bolle
2016-01-26 2:28 ` Yakir Yang [this message]
2016-01-26 2:28 ` Yakir Yang
2016-01-26 2:28 ` Yakir Yang
2016-01-25 12:47 ` [PATCH v6 0/1] Introduce Innosilicon HDMI driver on Rockchip platforms Heiko Stübner
2016-01-25 12:47 ` Heiko Stübner
2016-01-25 12:47 ` Heiko Stübner
2016-01-26 2:34 ` Yakir Yang
2016-01-26 2:34 ` Yakir Yang
2016-01-26 2:34 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6D9B3.4070006@rock-chips.com \
--to=ykk@rock-chips.com \
--cc=airlied@linux.ie \
--cc=benchan@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kmixter@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
--cc=zhengyang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.