From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Keerthy <j-keerthy@ti.com>,
linus.walleij@linaro.org, Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
lokeshvutla@ti.com, Santosh Shilimkar <ssantosh@kernel.org>,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call
Date: Thu, 28 Jan 2016 16:18:21 +0200 [thread overview]
Message-ID: <56AA232D.3040509@ti.com> (raw)
In-Reply-To: <1453988331-17111-2-git-send-email-j-keerthy@ti.com>
On 01/28/2016 03:38 PM, Keerthy wrote:
> Currently the first parameter of irq_domain_add_legacy is NULL.
> irq_find_host function returns NULL when we do not populate the of_node
> and hence irq_of_parse_and_map call fails whenever we want to request a
> gpio irq. This fixes the request_irq failures for gpio interrupts.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index ec58f42..c889f31 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> return irq;
> }
>
> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
> &davinci_gpio_irq_ops,
> chips);
> if (!irq_domain) {
>
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Keerthy <j-keerthy@ti.com>, <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lokeshvutla@ti.com>, Santosh Shilimkar <ssantosh@kernel.org>,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call
Date: Thu, 28 Jan 2016 16:18:21 +0200 [thread overview]
Message-ID: <56AA232D.3040509@ti.com> (raw)
In-Reply-To: <1453988331-17111-2-git-send-email-j-keerthy@ti.com>
On 01/28/2016 03:38 PM, Keerthy wrote:
> Currently the first parameter of irq_domain_add_legacy is NULL.
> irq_find_host function returns NULL when we do not populate the of_node
> and hence irq_of_parse_and_map call fails whenever we want to request a
> gpio irq. This fixes the request_irq failures for gpio interrupts.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index ec58f42..c889f31 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> return irq;
> }
>
> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
> &davinci_gpio_irq_ops,
> chips);
> if (!irq_domain) {
>
--
regards,
-grygorii
next prev parent reply other threads:[~2016-01-28 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 13:38 [PATCH 0/2] gpio: davinci: driver fixes Keerthy
2016-01-28 13:38 ` Keerthy
2016-01-28 13:38 ` [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy
2016-01-28 13:38 ` Keerthy
2016-01-28 14:18 ` Grygorii Strashko [this message]
2016-01-28 14:18 ` Grygorii Strashko
2016-02-08 9:48 ` Keerthy
2016-02-08 9:48 ` Keerthy
2016-02-10 10:00 ` Linus Walleij
2016-01-28 13:38 ` [PATCH 2/2] gpio: davinci: Fix the number of controllers allocated Keerthy
2016-01-28 13:38 ` Keerthy
2016-01-28 14:18 ` Grygorii Strashko
2016-01-28 14:18 ` Grygorii Strashko
2016-02-08 9:47 ` Keerthy
2016-02-08 9:47 ` Keerthy
2016-02-10 10:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA232D.3040509@ti.com \
--to=grygorii.strashko@ti.com \
--cc=gnurou@gmail.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.