* [Qemu-trivial] [PATCH v1 1/1] qom: Correct object_property_get_int() description
@ 2016-01-18 18:42 ` Alistair Francis
0 siblings, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2016-01-18 18:42 UTC (permalink / raw)
To: qemu-devel
Cc: christian.liebhardt, qemu-trivial, christian.liebhardt, mjt,
alistair.francis
The description of object_property_get_int() stated that on an error
it returns NULL. This is not the case and the function will return -1
if an error occurs. Update the commented documentation accordingly.
Reported-By: Christian Liebhardt <christian.liebhardt@keysight.com>
Signed-off-by: Christian Liebhardt <christian.liebhardt@keysight.com>
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
include/qom/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 4509166..2848f5e 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1107,7 +1107,7 @@ void object_property_set_int(Object *obj, int64_t value,
* @name: the name of the property
* @errp: returns an error if this function fails
*
- * Returns: the value of the property, converted to an integer, or NULL if
+ * Returns: the value of the property, converted to an integer, or negative if
* an error occurs (including when the property value is not an integer).
*/
int64_t object_property_get_int(Object *obj, const char *name,
--
2.5.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
@ 2016-01-18 18:42 ` Alistair Francis
0 siblings, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2016-01-18 18:42 UTC (permalink / raw)
To: qemu-devel
Cc: christian.liebhardt, qemu-trivial, christian.liebhardt, mjt,
alistair.francis
The description of object_property_get_int() stated that on an error
it returns NULL. This is not the case and the function will return -1
if an error occurs. Update the commented documentation accordingly.
Reported-By: Christian Liebhardt <christian.liebhardt@keysight.com>
Signed-off-by: Christian Liebhardt <christian.liebhardt@keysight.com>
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
include/qom/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 4509166..2848f5e 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1107,7 +1107,7 @@ void object_property_set_int(Object *obj, int64_t value,
* @name: the name of the property
* @errp: returns an error if this function fails
*
- * Returns: the value of the property, converted to an integer, or NULL if
+ * Returns: the value of the property, converted to an integer, or negative if
* an error occurs (including when the property value is not an integer).
*/
int64_t object_property_get_int(Object *obj, const char *name,
--
2.5.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
2016-01-18 18:42 ` [Qemu-devel] " Alistair Francis
@ 2016-01-19 7:19 ` Markus Armbruster
-1 siblings, 0 replies; 8+ messages in thread
From: Markus Armbruster @ 2016-01-19 7:19 UTC (permalink / raw)
To: Alistair Francis
Cc: christian.liebhardt, mjt, qemu-devel, qemu-trivial,
christian.liebhardt, Andreas Färber
Copying maintainer. Always do that even for trivial patches.
Alistair Francis <alistair.francis@xilinx.com> writes:
> The description of object_property_get_int() stated that on an error
> it returns NULL. This is not the case and the function will return -1
> if an error occurs. Update the commented documentation accordingly.
>
> Reported-By: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> include/qom/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 4509166..2848f5e 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1107,7 +1107,7 @@ void object_property_set_int(Object *obj, int64_t value,
> * @name: the name of the property
> * @errp: returns an error if this function fails
> *
> - * Returns: the value of the property, converted to an integer, or NULL if
> + * Returns: the value of the property, converted to an integer, or negative if
> * an error occurs (including when the property value is not an integer).
> */
> int64_t object_property_get_int(Object *obj, const char *name,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
@ 2016-01-19 7:19 ` Markus Armbruster
0 siblings, 0 replies; 8+ messages in thread
From: Markus Armbruster @ 2016-01-19 7:19 UTC (permalink / raw)
To: Alistair Francis
Cc: christian.liebhardt, mjt, qemu-devel, qemu-trivial,
christian.liebhardt, Andreas Färber
Copying maintainer. Always do that even for trivial patches.
Alistair Francis <alistair.francis@xilinx.com> writes:
> The description of object_property_get_int() stated that on an error
> it returns NULL. This is not the case and the function will return -1
> if an error occurs. Update the commented documentation accordingly.
>
> Reported-By: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> include/qom/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 4509166..2848f5e 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1107,7 +1107,7 @@ void object_property_set_int(Object *obj, int64_t value,
> * @name: the name of the property
> * @errp: returns an error if this function fails
> *
> - * Returns: the value of the property, converted to an integer, or NULL if
> + * Returns: the value of the property, converted to an integer, or negative if
> * an error occurs (including when the property value is not an integer).
> */
> int64_t object_property_get_int(Object *obj, const char *name,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH v1 1/1] qom: Correct object_property_get_int() description
2016-01-18 18:42 ` [Qemu-devel] " Alistair Francis
@ 2016-01-30 9:35 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2016-01-30 9:35 UTC (permalink / raw)
To: Alistair Francis, qemu-devel
Cc: christian.liebhardt, qemu-trivial, christian.liebhardt
18.01.2016 21:42, Alistair Francis wrote:
> The description of object_property_get_int() stated that on an error
> it returns NULL. This is not the case and the function will return -1
> if an error occurs. Update the commented documentation accordingly.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
@ 2016-01-30 9:35 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2016-01-30 9:35 UTC (permalink / raw)
To: Alistair Francis, qemu-devel
Cc: christian.liebhardt, qemu-trivial, christian.liebhardt
18.01.2016 21:42, Alistair Francis wrote:
> The description of object_property_get_int() stated that on an error
> it returns NULL. This is not the case and the function will return -1
> if an error occurs. Update the commented documentation accordingly.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
2016-01-30 9:35 ` [Qemu-devel] " Michael Tokarev
@ 2016-02-01 23:27 ` Alistair Francis
-1 siblings, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2016-02-01 23:27 UTC (permalink / raw)
To: Michael Tokarev
Cc: christian.liebhardt, qemu-trivial, christian.liebhardt,
qemu-devel@nongnu.org Developers, Alistair Francis
On Sat, Jan 30, 2016 at 1:35 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> 18.01.2016 21:42, Alistair Francis wrote:
>> The description of object_property_get_int() stated that on an error
>> it returns NULL. This is not the case and the function will return -1
>> if an error occurs. Update the commented documentation accordingly.
>
> Applied to -trivial, thanks!
Thanks!
Alistair
>
> /mjt
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
@ 2016-02-01 23:27 ` Alistair Francis
0 siblings, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2016-02-01 23:27 UTC (permalink / raw)
To: Michael Tokarev
Cc: christian.liebhardt, qemu-trivial, christian.liebhardt,
qemu-devel@nongnu.org Developers, Alistair Francis
On Sat, Jan 30, 2016 at 1:35 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> 18.01.2016 21:42, Alistair Francis wrote:
>> The description of object_property_get_int() stated that on an error
>> it returns NULL. This is not the case and the function will return -1
>> if an error occurs. Update the commented documentation accordingly.
>
> Applied to -trivial, thanks!
Thanks!
Alistair
>
> /mjt
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-01 23:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-18 18:42 [Qemu-trivial] [PATCH v1 1/1] qom: Correct object_property_get_int() description Alistair Francis
2016-01-18 18:42 ` [Qemu-devel] " Alistair Francis
2016-01-19 7:19 ` [Qemu-trivial] " Markus Armbruster
2016-01-19 7:19 ` Markus Armbruster
2016-01-30 9:35 ` [Qemu-trivial] " Michael Tokarev
2016-01-30 9:35 ` [Qemu-devel] " Michael Tokarev
2016-02-01 23:27 ` [Qemu-trivial] " Alistair Francis
2016-02-01 23:27 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.