All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Sean Bruno <sbruno@freebsd.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath
Date: Sat, 30 Jan 2016 12:51:27 +0300	[thread overview]
Message-ID: <56AC879F.9020705@msgid.tls.msk.ru> (raw)
In-Reply-To: <1453484125-4064-1-git-send-email-berrange@redhat.com>

22.01.2016 20:35, Daniel P. Berrange wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.

Applied to -trivial, fixed qemu-devel@ addres.

Thanks!

/mjt

> Tested-by: Sean Bruno <sbruno@freebsd.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  qemu-char.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
>  }
>  
>  static CharDriverState *qemu_chr_open_pp_fd(int fd,
> -                                            ChardevBackend *backend,
> +                                            ChardevCommon *backend,
>                                              Error **errp)
>  {
>      CharDriverState *chr;
>  
> -    chr = qemu_chr_alloc(common, errp);
> +    chr = qemu_chr_alloc(backend, errp);
>      if (!chr) {
>          return NULL;
>      }
> 



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Sean Bruno <sbruno@freebsd.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath
Date: Sat, 30 Jan 2016 12:51:27 +0300	[thread overview]
Message-ID: <56AC879F.9020705@msgid.tls.msk.ru> (raw)
In-Reply-To: <1453484125-4064-1-git-send-email-berrange@redhat.com>

22.01.2016 20:35, Daniel P. Berrange wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.

Applied to -trivial, fixed qemu-devel@ addres.

Thanks!

/mjt

> Tested-by: Sean Bruno <sbruno@freebsd.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  qemu-char.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
>  }
>  
>  static CharDriverState *qemu_chr_open_pp_fd(int fd,
> -                                            ChardevBackend *backend,
> +                                            ChardevCommon *backend,
>                                              Error **errp)
>  {
>      CharDriverState *chr;
>  
> -    chr = qemu_chr_alloc(common, errp);
> +    chr = qemu_chr_alloc(backend, errp);
>      if (!chr) {
>          return NULL;
>      }
> 

  parent reply	other threads:[~2016-01-30  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 17:35 [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath Daniel P. Berrange
2016-01-22 18:03 ` Peter Maydell
2016-01-22 18:03   ` [Qemu-devel] " Peter Maydell
2016-01-30  9:51 ` Michael Tokarev [this message]
2016-01-30  9:51   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AC879F.9020705@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sbruno@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.