* [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath
@ 2016-01-22 17:35 Daniel P. Berrange
2016-01-22 18:03 ` [Qemu-devel] " Peter Maydell
2016-01-30 9:51 ` [Qemu-devel] " Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Daniel P. Berrange @ 2016-01-22 17:35 UTC (permalink / raw)
To: qemu-deve
Cc: qemu-trivial, Peter Maydell, Sean Bruno, Daniel P. Berrange,
Paolo Bonzini
The BSD impl of qemu_chr_open_pp_fd had mis-declared
its parameter type as ChardevBackend instead of
ChardevCommon. It had also mistakenly used the variable
name 'common' instead of 'backend'.
Tested-by: Sean Bruno <sbruno@freebsd.org>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
qemu-char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index e133f4f..aa2e660 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
}
static CharDriverState *qemu_chr_open_pp_fd(int fd,
- ChardevBackend *backend,
+ ChardevCommon *backend,
Error **errp)
{
CharDriverState *chr;
- chr = qemu_chr_alloc(common, errp);
+ chr = qemu_chr_alloc(backend, errp);
if (!chr) {
return NULL;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath
2016-01-22 17:35 [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath Daniel P. Berrange
@ 2016-01-22 18:03 ` Peter Maydell
2016-01-30 9:51 ` [Qemu-devel] " Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-01-22 18:03 UTC (permalink / raw)
To: Daniel P. Berrange, QEMU Developers
Cc: QEMU Trivial, Paolo Bonzini, Sean Bruno
You typoed the qemu-devel address...
thanks
-- PMM
On 22 January 2016 at 17:35, Daniel P. Berrange <berrange@redhat.com> wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.
>
> Tested-by: Sean Bruno <sbruno@freebsd.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> qemu-char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
> }
>
> static CharDriverState *qemu_chr_open_pp_fd(int fd,
> - ChardevBackend *backend,
> + ChardevCommon *backend,
> Error **errp)
> {
> CharDriverState *chr;
>
> - chr = qemu_chr_alloc(common, errp);
> + chr = qemu_chr_alloc(backend, errp);
> if (!chr) {
> return NULL;
> }
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath
@ 2016-01-22 18:03 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-01-22 18:03 UTC (permalink / raw)
To: Daniel P. Berrange, QEMU Developers
Cc: QEMU Trivial, Paolo Bonzini, Sean Bruno
You typoed the qemu-devel address...
thanks
-- PMM
On 22 January 2016 at 17:35, Daniel P. Berrange <berrange@redhat.com> wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.
>
> Tested-by: Sean Bruno <sbruno@freebsd.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> qemu-char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
> }
>
> static CharDriverState *qemu_chr_open_pp_fd(int fd,
> - ChardevBackend *backend,
> + ChardevCommon *backend,
> Error **errp)
> {
> CharDriverState *chr;
>
> - chr = qemu_chr_alloc(common, errp);
> + chr = qemu_chr_alloc(backend, errp);
> if (!chr) {
> return NULL;
> }
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath
2016-01-22 17:35 [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath Daniel P. Berrange
@ 2016-01-30 9:51 ` Michael Tokarev
2016-01-30 9:51 ` [Qemu-devel] " Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2016-01-30 9:51 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel
Cc: qemu-trivial, Peter Maydell, Sean Bruno, Paolo Bonzini
22.01.2016 20:35, Daniel P. Berrange wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.
Applied to -trivial, fixed qemu-devel@ addres.
Thanks!
/mjt
> Tested-by: Sean Bruno <sbruno@freebsd.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> qemu-char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
> }
>
> static CharDriverState *qemu_chr_open_pp_fd(int fd,
> - ChardevBackend *backend,
> + ChardevCommon *backend,
> Error **errp)
> {
> CharDriverState *chr;
>
> - chr = qemu_chr_alloc(common, errp);
> + chr = qemu_chr_alloc(backend, errp);
> if (!chr) {
> return NULL;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath
@ 2016-01-30 9:51 ` Michael Tokarev
0 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2016-01-30 9:51 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel
Cc: qemu-trivial, Peter Maydell, Sean Bruno, Paolo Bonzini
22.01.2016 20:35, Daniel P. Berrange wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.
Applied to -trivial, fixed qemu-devel@ addres.
Thanks!
/mjt
> Tested-by: Sean Bruno <sbruno@freebsd.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> qemu-char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void *arg)
> }
>
> static CharDriverState *qemu_chr_open_pp_fd(int fd,
> - ChardevBackend *backend,
> + ChardevCommon *backend,
> Error **errp)
> {
> CharDriverState *chr;
>
> - chr = qemu_chr_alloc(common, errp);
> + chr = qemu_chr_alloc(backend, errp);
> if (!chr) {
> return NULL;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-30 9:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-22 17:35 [Qemu-trivial] [PATCH] char: fix parameter name / type in BSD codepath Daniel P. Berrange
2016-01-22 18:03 ` Peter Maydell
2016-01-22 18:03 ` [Qemu-devel] " Peter Maydell
2016-01-30 9:51 ` [Qemu-trivial] " Michael Tokarev
2016-01-30 9:51 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.