* [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators
@ 2016-01-22 12:39 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2016-01-22 12:39 UTC (permalink / raw)
To: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Matthias Brugger, Sascha Hauer,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
With CONFIG_PM enabled do not call genpd->power_on manually as this
will cause the regulators being turned on once in SCPSYS probe and
then again when the genpd core turns on the domains. Instead, call
genpd->power_on only with CONFIG_PM disabled and tell the genpd core
that the domains are disabled when registered.
Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/soc/mediatek/mtk-scpsys.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
index 0221387..78227db 100644
--- a/drivers/soc/mediatek/mtk-scpsys.c
+++ b/drivers/soc/mediatek/mtk-scpsys.c
@@ -500,14 +500,13 @@ static int __init scpsys_probe(struct platform_device *pdev)
genpd->dev_ops.active_wakeup = scpsys_active_wakeup;
/*
- * Initially turn on all domains to make the domains usable
- * with !CONFIG_PM and to get the hardware in sync with the
- * software. The unused domains will be switched off during
- * late_init time.
+ * With CONFIG_PM disabled turn on all domains to make the
+ * hardware usable.
*/
- genpd->power_on(genpd);
+ if (!IS_ENABLED(CONFIG_PM))
+ genpd->power_on(genpd);
- pm_genpd_init(genpd, NULL, false);
+ pm_genpd_init(genpd, NULL, true);
}
/*
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators
@ 2016-01-22 12:39 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2016-01-22 12:39 UTC (permalink / raw)
To: linux-arm-kernel
With CONFIG_PM enabled do not call genpd->power_on manually as this
will cause the regulators being turned on once in SCPSYS probe and
then again when the genpd core turns on the domains. Instead, call
genpd->power_on only with CONFIG_PM disabled and tell the genpd core
that the domains are disabled when registered.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/soc/mediatek/mtk-scpsys.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
index 0221387..78227db 100644
--- a/drivers/soc/mediatek/mtk-scpsys.c
+++ b/drivers/soc/mediatek/mtk-scpsys.c
@@ -500,14 +500,13 @@ static int __init scpsys_probe(struct platform_device *pdev)
genpd->dev_ops.active_wakeup = scpsys_active_wakeup;
/*
- * Initially turn on all domains to make the domains usable
- * with !CONFIG_PM and to get the hardware in sync with the
- * software. The unused domains will be switched off during
- * late_init time.
+ * With CONFIG_PM disabled turn on all domains to make the
+ * hardware usable.
*/
- genpd->power_on(genpd);
+ if (!IS_ENABLED(CONFIG_PM))
+ genpd->power_on(genpd);
- pm_genpd_init(genpd, NULL, false);
+ pm_genpd_init(genpd, NULL, true);
}
/*
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1453466365-24406-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators
2016-01-22 12:39 ` Sascha Hauer
@ 2016-01-22 19:26 ` Daniel Kurtz
-1 siblings, 0 replies; 6+ messages in thread
From: Daniel Kurtz @ 2016-01-22 19:26 UTC (permalink / raw)
To: Sascha Hauer
Cc: Matthias Brugger, moderated list:ARM/Mediatek SoC support,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
On Fri, Jan 22, 2016 at 4:39 AM, Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>
> With CONFIG_PM enabled do not call genpd->power_on manually as this
> will cause the regulators being turned on once in SCPSYS probe and
> then again when the genpd core turns on the domains. Instead, call
> genpd->power_on only with CONFIG_PM disabled and tell the genpd core
> that the domains are disabled when registered.
>
> Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Take your pick:
Tested-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Reviewed-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> drivers/soc/mediatek/mtk-scpsys.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index 0221387..78227db 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -500,14 +500,13 @@ static int __init scpsys_probe(struct platform_device *pdev)
> genpd->dev_ops.active_wakeup = scpsys_active_wakeup;
>
> /*
> - * Initially turn on all domains to make the domains usable
> - * with !CONFIG_PM and to get the hardware in sync with the
> - * software. The unused domains will be switched off during
> - * late_init time.
> + * With CONFIG_PM disabled turn on all domains to make the
> + * hardware usable.
> */
> - genpd->power_on(genpd);
> + if (!IS_ENABLED(CONFIG_PM))
> + genpd->power_on(genpd);
>
> - pm_genpd_init(genpd, NULL, false);
> + pm_genpd_init(genpd, NULL, true);
> }
>
> /*
> --
> 2.7.0.rc3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators
@ 2016-01-22 19:26 ` Daniel Kurtz
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kurtz @ 2016-01-22 19:26 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 22, 2016 at 4:39 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> With CONFIG_PM enabled do not call genpd->power_on manually as this
> will cause the regulators being turned on once in SCPSYS probe and
> then again when the genpd core turns on the domains. Instead, call
> genpd->power_on only with CONFIG_PM disabled and tell the genpd core
> that the domains are disabled when registered.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Take your pick:
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
> drivers/soc/mediatek/mtk-scpsys.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index 0221387..78227db 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -500,14 +500,13 @@ static int __init scpsys_probe(struct platform_device *pdev)
> genpd->dev_ops.active_wakeup = scpsys_active_wakeup;
>
> /*
> - * Initially turn on all domains to make the domains usable
> - * with !CONFIG_PM and to get the hardware in sync with the
> - * software. The unused domains will be switched off during
> - * late_init time.
> + * With CONFIG_PM disabled turn on all domains to make the
> + * hardware usable.
> */
> - genpd->power_on(genpd);
> + if (!IS_ENABLED(CONFIG_PM))
> + genpd->power_on(genpd);
>
> - pm_genpd_init(genpd, NULL, false);
> + pm_genpd_init(genpd, NULL, true);
> }
>
> /*
> --
> 2.7.0.rc3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAGS+omD=ZdLoT8fZ_vq4CvdCvAwsz2tbdEzS5Q8pAL5zAKW5yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators
2016-01-22 19:26 ` Daniel Kurtz
@ 2016-02-01 10:28 ` Matthias Brugger
-1 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2016-02-01 10:28 UTC (permalink / raw)
To: Daniel Kurtz, Sascha Hauer
Cc: moderated list:ARM/Mediatek SoC support,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
On 22/01/16 20:26, Daniel Kurtz wrote:
> On Fri, Jan 22, 2016 at 4:39 AM, Sascha Hauer<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> >
>> >With CONFIG_PM enabled do not call genpd->power_on manually as this
>> >will cause the regulators being turned on once in SCPSYS probe and
>> >then again when the genpd core turns on the domains. Instead, call
>> >genpd->power_on only with CONFIG_PM disabled and tell the genpd core
>> >that the domains are disabled when registered.
>> >
>> >Signed-off-by: Sascha Hauer<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Take your pick:
> Tested-by: Daniel Kurtz<djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Reviewed-by: Daniel Kurtz<djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
>> >---
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators
@ 2016-02-01 10:28 ` Matthias Brugger
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2016-02-01 10:28 UTC (permalink / raw)
To: linux-arm-kernel
On 22/01/16 20:26, Daniel Kurtz wrote:
> On Fri, Jan 22, 2016 at 4:39 AM, Sascha Hauer<s.hauer@pengutronix.de> wrote:
>> >
>> >With CONFIG_PM enabled do not call genpd->power_on manually as this
>> >will cause the regulators being turned on once in SCPSYS probe and
>> >then again when the genpd core turns on the domains. Instead, call
>> >genpd->power_on only with CONFIG_PM disabled and tell the genpd core
>> >that the domains are disabled when registered.
>> >
>> >Signed-off-by: Sascha Hauer<s.hauer@pengutronix.de>
> Take your pick:
> Tested-by: Daniel Kurtz<djkurtz@chromium.org>
> Reviewed-by: Daniel Kurtz<djkurtz@chromium.org>
>
>> >---
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-01 10:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-22 12:39 [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators Sascha Hauer
2016-01-22 12:39 ` Sascha Hauer
[not found] ` <1453466365-24406-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-01-22 19:26 ` Daniel Kurtz
2016-01-22 19:26 ` Daniel Kurtz
[not found] ` <CAGS+omD=ZdLoT8fZ_vq4CvdCvAwsz2tbdEzS5Q8pAL5zAKW5yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-01 10:28 ` Matthias Brugger
2016-02-01 10:28 ` Matthias Brugger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.