* Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
@ 2016-02-01 15:18 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2016-02-01 15:18 UTC (permalink / raw)
To: Andreas Dannenberg
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, jic23-DgEjT+Ai2ygdnm+yROfE0A,
Alexander Koch, knaack.h-Mmb7MZpHnFY, lars-Qo5EllUWu/uELgA04lAiVw,
pmeerw-jW+XmwGofnuzQB+pC5nmwQ,
mhornung.linux-Re5JQEeQqe8AvxtiuMwx3w,
fengguang.wu-ral2JQCrhuEAvxtiuMwx3w
On Fri, Jan 29, 2016 at 01:03:00PM -0600, Andreas Dannenberg wrote:
> Signed-off-by: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>
> ---
> .../devicetree/bindings/iio/light/opt3001.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> new file mode 100644
> index 0000000..55b9cb3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> @@ -0,0 +1,26 @@
> +* Texas Instruments OPT3001 Ambient Light Sensor
> +
> +The driver supports interrupt-driven and interrupt-less operation, depending
> +on whether an interrupt property has been populated into the DT. Note that
> +the optional generation of IIO events on rising/falling light threshold changes
> +requires the use of interrupts. Without interrupts, only the simple reading
> +of the current light value is supported through the IIO API.
Seems like you could poll and do the threshold changes in s/w. Anyway,
that's all irrelevant to the DT binding.
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
2016-02-01 15:18 ` Rob Herring
@ 2016-02-01 19:56 ` Jonathan Cameron
-1 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2016-02-01 19:56 UTC (permalink / raw)
To: Rob Herring, Andreas Dannenberg
Cc: linux-iio, devicetree, Alexander Koch, knaack.h, lars,
pmeerw@pmeerw.net >> Peter Meerwald, mhornung.linux,
fengguang.wu
On 01/02/16 15:18, Rob Herring wrote:
> On Fri, Jan 29, 2016 at 01:03:00PM -0600, Andreas Dannenberg wrote:
>> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
>> ---
>> .../devicetree/bindings/iio/light/opt3001.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
>> new file mode 100644
>> index 0000000..55b9cb3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
>> @@ -0,0 +1,26 @@
>> +* Texas Instruments OPT3001 Ambient Light Sensor
>> +
>> +The driver supports interrupt-driven and interrupt-less operation, depending
>> +on whether an interrupt property has been populated into the DT. Note that
>> +the optional generation of IIO events on rising/falling light threshold changes
>> +requires the use of interrupts. Without interrupts, only the simple reading
>> +of the current light value is supported through the IIO API.
>
> Seems like you could poll and do the threshold changes in s/w. Anyway,
> that's all irrelevant to the DT binding.
>
> Acked-by: Rob Herring <robh@kernel.org>
Oddity occurred during a merge or patch application at some point as I actually had
some docs in my local tree copy for this, but they weren't being tracked by git.
Checking back, the original patch series did have docs so not sure what rabbit
hole these dropped down. Anyhow, easiest option for me is to just apply this
patch and not chase down where the original went!
Have added a note to the commit to this effect. Applied to the togreg
branch of iio.git.
Thanks,
Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
@ 2016-02-01 19:56 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2016-02-01 19:56 UTC (permalink / raw)
To: Rob Herring, Andreas Dannenberg
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Alexander Koch,
knaack.h-Mmb7MZpHnFY, lars-Qo5EllUWu/uELgA04lAiVw,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org >> Peter Meerwald,
mhornung.linux-Re5JQEeQqe8AvxtiuMwx3w,
fengguang.wu-ral2JQCrhuEAvxtiuMwx3w
On 01/02/16 15:18, Rob Herring wrote:
> On Fri, Jan 29, 2016 at 01:03:00PM -0600, Andreas Dannenberg wrote:
>> Signed-off-by: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>
>> ---
>> .../devicetree/bindings/iio/light/opt3001.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
>> new file mode 100644
>> index 0000000..55b9cb3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
>> @@ -0,0 +1,26 @@
>> +* Texas Instruments OPT3001 Ambient Light Sensor
>> +
>> +The driver supports interrupt-driven and interrupt-less operation, depending
>> +on whether an interrupt property has been populated into the DT. Note that
>> +the optional generation of IIO events on rising/falling light threshold changes
>> +requires the use of interrupts. Without interrupts, only the simple reading
>> +of the current light value is supported through the IIO API.
>
> Seems like you could poll and do the threshold changes in s/w. Anyway,
> that's all irrelevant to the DT binding.
>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Oddity occurred during a merge or patch application at some point as I actually had
some docs in my local tree copy for this, but they weren't being tracked by git.
Checking back, the original patch series did have docs so not sure what rabbit
hole these dropped down. Anyhow, easiest option for me is to just apply this
patch and not chase down where the original went!
Have added a note to the commit to this effect. Applied to the togreg
branch of iio.git.
Thanks,
Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
2016-02-01 15:18 ` Rob Herring
@ 2016-02-01 20:01 ` Andreas Dannenberg
-1 siblings, 0 replies; 10+ messages in thread
From: Andreas Dannenberg @ 2016-02-01 20:01 UTC (permalink / raw)
To: Rob Herring
Cc: linux-iio, devicetree, jic23, Alexander Koch, knaack.h, lars,
pmeerw, mhornung.linux, fengguang.wu
On Mon, Feb 01, 2016 at 09:18:48AM -0600, Rob Herring wrote:
> On Fri, Jan 29, 2016 at 01:03:00PM -0600, Andreas Dannenberg wrote:
> > Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> > ---
> > .../devicetree/bindings/iio/light/opt3001.txt | 26 ++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> > new file mode 100644
> > index 0000000..55b9cb3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> > @@ -0,0 +1,26 @@
> > +* Texas Instruments OPT3001 Ambient Light Sensor
> > +
> > +The driver supports interrupt-driven and interrupt-less operation, depending
> > +on whether an interrupt property has been populated into the DT. Note that
> > +the optional generation of IIO events on rising/falling light threshold changes
> > +requires the use of interrupts. Without interrupts, only the simple reading
> > +of the current light value is supported through the IIO API.
>
> Seems like you could poll and do the threshold changes in s/w. Anyway,
> that's all irrelevant to the DT binding.
True that. The recent addition of polling mode to the driver did not
consider this use case so until somebody has a strong need for this and
adds the needed code at least we have this limitation documented.
Regards,
Andreas
>
> Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
@ 2016-02-01 20:01 ` Andreas Dannenberg
0 siblings, 0 replies; 10+ messages in thread
From: Andreas Dannenberg @ 2016-02-01 20:01 UTC (permalink / raw)
To: Rob Herring
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, jic23-DgEjT+Ai2ygdnm+yROfE0A,
Alexander Koch, knaack.h-Mmb7MZpHnFY, lars-Qo5EllUWu/uELgA04lAiVw,
pmeerw-jW+XmwGofnuzQB+pC5nmwQ,
mhornung.linux-Re5JQEeQqe8AvxtiuMwx3w,
fengguang.wu-ral2JQCrhuEAvxtiuMwx3w
On Mon, Feb 01, 2016 at 09:18:48AM -0600, Rob Herring wrote:
> On Fri, Jan 29, 2016 at 01:03:00PM -0600, Andreas Dannenberg wrote:
> > Signed-off-by: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>
> > ---
> > .../devicetree/bindings/iio/light/opt3001.txt | 26 ++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> > new file mode 100644
> > index 0000000..55b9cb3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> > @@ -0,0 +1,26 @@
> > +* Texas Instruments OPT3001 Ambient Light Sensor
> > +
> > +The driver supports interrupt-driven and interrupt-less operation, depending
> > +on whether an interrupt property has been populated into the DT. Note that
> > +the optional generation of IIO events on rising/falling light threshold changes
> > +requires the use of interrupts. Without interrupts, only the simple reading
> > +of the current light value is supported through the IIO API.
>
> Seems like you could poll and do the threshold changes in s/w. Anyway,
> that's all irrelevant to the DT binding.
True that. The recent addition of polling mode to the driver did not
consider this use case so until somebody has a strong need for this and
adds the needed code at least we have this limitation documented.
Regards,
Andreas
>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
^ permalink raw reply [flat|nested] 10+ messages in thread