All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Jingoo Han <jingoohan1@gmail.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	dri-devel@lists.freedesktop.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic
Date: Mon, 8 Feb 2016 09:03:36 -0300	[thread overview]
Message-ID: <56B88418.7090106@osg.samsung.com> (raw)
In-Reply-To: <1454080171-23769-1-git-send-email-javier@osg.samsung.com>

Hello Inki,

On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote:
> Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support
> for panel") made the Exynos DP DT binding more consistent since the OF
> graph could be used to lookup either a panel or a bridge device node.
>
> Before that commit, a panel would be looked up using a phandle and a
> bridge using the OF graph which made the DT binding not consistent.
>
> But the patch broke the later case since not finding a panel dev node
> would cause the driver's to do a probe deferral instead of attempting
> to lookup a bridge device node associated with the remote endpoint.
>
> So instead of returning a -EPROBE_DEFER if a panel is not found, check
> if there's a bridge and only do a probe deferral if both aren't found.
>
> Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel")
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>

Any comments about this patch? It is needed to have display working on
machines with a bridge chip again so it should be pushed to -rc ASAP.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic
Date: Mon, 8 Feb 2016 09:03:36 -0300	[thread overview]
Message-ID: <56B88418.7090106@osg.samsung.com> (raw)
In-Reply-To: <1454080171-23769-1-git-send-email-javier@osg.samsung.com>

Hello Inki,

On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote:
> Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support
> for panel") made the Exynos DP DT binding more consistent since the OF
> graph could be used to lookup either a panel or a bridge device node.
>
> Before that commit, a panel would be looked up using a phandle and a
> bridge using the OF graph which made the DT binding not consistent.
>
> But the patch broke the later case since not finding a panel dev node
> would cause the driver's to do a probe deferral instead of attempting
> to lookup a bridge device node associated with the remote endpoint.
>
> So instead of returning a -EPROBE_DEFER if a panel is not found, check
> if there's a bridge and only do a probe deferral if both aren't found.
>
> Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel")
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>

Any comments about this patch? It is needed to have display working on
machines with a bridge chip again so it should be pushed to -rc ASAP.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	David Airlie <airlied@linux.ie>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic
Date: Mon, 8 Feb 2016 09:03:36 -0300	[thread overview]
Message-ID: <56B88418.7090106@osg.samsung.com> (raw)
In-Reply-To: <1454080171-23769-1-git-send-email-javier@osg.samsung.com>

Hello Inki,

On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote:
> Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support
> for panel") made the Exynos DP DT binding more consistent since the OF
> graph could be used to lookup either a panel or a bridge device node.
>
> Before that commit, a panel would be looked up using a phandle and a
> bridge using the OF graph which made the DT binding not consistent.
>
> But the patch broke the later case since not finding a panel dev node
> would cause the driver's to do a probe deferral instead of attempting
> to lookup a bridge device node associated with the remote endpoint.
>
> So instead of returning a -EPROBE_DEFER if a panel is not found, check
> if there's a bridge and only do a probe deferral if both aren't found.
>
> Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel")
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>

Any comments about this patch? It is needed to have display working on
machines with a bridge chip again so it should be pushed to -rc ASAP.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2016-02-08 12:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 15:09 [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic Javier Martinez Canillas
2016-01-29 15:09 ` Javier Martinez Canillas
2016-01-29 15:09 ` Javier Martinez Canillas
2016-02-08 12:03 ` Javier Martinez Canillas [this message]
2016-02-08 12:03   ` Javier Martinez Canillas
2016-02-08 12:03   ` Javier Martinez Canillas
2016-02-08 12:38   ` Marek Szyprowski
2016-02-08 12:38     ` Marek Szyprowski
2016-02-08 12:44     ` Javier Martinez Canillas
2016-02-08 12:44       ` Javier Martinez Canillas
2016-02-08 12:44       ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B88418.7090106@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.