All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org,
	broonie@kernel.org, a.zummo@towertech.it,
	alexandre.belloni@free-electrons.com
Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	rtc-linux@googlegroups.com, swarren@nvidia.com,
	treding@nvidia.com, k.kozlowski@samsung.com,
	vreddytalla@nvidia.com, Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024
Date: Tue, 9 Feb 2016 20:32:24 +0530	[thread overview]
Message-ID: <56B9FF80.7010107@nvidia.com> (raw)
In-Reply-To: <1454171931-27752-9-git-send-email-ldewangan@nvidia.com>

Hi Mark,

I have taken care of all your previous comment on this patch.

Can you please review?

I got the macro from Lee's and spinning the V8 of this series so if 
there is any thing, I can take care on my next version.

Thanks,
Laxman


On Saturday 30 January 2016 10:08 PM, Laxman Dewangan wrote:
> MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the
> multiple DCDC and LDOs. This supplies the power to different
> components of the system.
> Also these rails has configuration for ramp time, flexible
> power sequence, slew rate etc.
>
> Add regulator driver to access these rails via regulator APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>
> - Cleanup code based on comment received on mfd/rtc.
> - Avoid duplication on error message.
>
> Changes form V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - Refactor Regulator driver to use core API for DT parsing.
> - Update based on API changes.
>
> Changes from V3:
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
>   
> Changes from V4:
> - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt
> - Detail out properties.
>
> Changes from V5:
> - Separate out DT binding doc for regulator.
>
> Changes from V6:
> - Use direct regmap APIs.
> - Drop active-discharge configuration as it wil be move to core and through
>    callback. Follow on patches are palnned for this.
>


WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <linus.walleij@linaro.org>,
	<gnurou@gmail.com>, <lee.jones@linaro.org>, <broonie@kernel.org>,
	<a.zummo@towertech.it>, <alexandre.belloni@free-electrons.com>
Cc: <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<rtc-linux@googlegroups.com>, <swarren@nvidia.com>,
	<treding@nvidia.com>, <k.kozlowski@samsung.com>,
	<vreddytalla@nvidia.com>, Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: [rtc-linux] Re: [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024
Date: Tue, 9 Feb 2016 20:32:24 +0530	[thread overview]
Message-ID: <56B9FF80.7010107@nvidia.com> (raw)
In-Reply-To: <1454171931-27752-9-git-send-email-ldewangan@nvidia.com>

Hi Mark,

I have taken care of all your previous comment on this patch.

Can you please review?

I got the macro from Lee's and spinning the V8 of this series so if 
there is any thing, I can take care on my next version.

Thanks,
Laxman


On Saturday 30 January 2016 10:08 PM, Laxman Dewangan wrote:
> MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the
> multiple DCDC and LDOs. This supplies the power to different
> components of the system.
> Also these rails has configuration for ramp time, flexible
> power sequence, slew rate etc.
>
> Add regulator driver to access these rails via regulator APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>
> - Cleanup code based on comment received on mfd/rtc.
> - Avoid duplication on error message.
>
> Changes form V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - Refactor Regulator driver to use core API for DT parsing.
> - Update based on API changes.
>
> Changes from V3:
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
>   
> Changes from V4:
> - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt
> - Detail out properties.
>
> Changes from V5:
> - Separate out DT binding doc for regulator.
>
> Changes from V6:
> - Use direct regmap APIs.
> - Drop active-discharge configuration as it wil be move to core and through
>    callback. Follow on patches are palnned for this.
>

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <linus.walleij@linaro.org>,
	<gnurou@gmail.com>, <lee.jones@linaro.org>, <broonie@kernel.org>,
	<a.zummo@towertech.it>, <alexandre.belloni@free-electrons.com>
Cc: <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<rtc-linux@googlegroups.com>, <swarren@nvidia.com>,
	<treding@nvidia.com>, <k.kozlowski@samsung.com>,
	<vreddytalla@nvidia.com>, Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024
Date: Tue, 9 Feb 2016 20:32:24 +0530	[thread overview]
Message-ID: <56B9FF80.7010107@nvidia.com> (raw)
In-Reply-To: <1454171931-27752-9-git-send-email-ldewangan@nvidia.com>

Hi Mark,

I have taken care of all your previous comment on this patch.

Can you please review?

I got the macro from Lee's and spinning the V8 of this series so if 
there is any thing, I can take care on my next version.

Thanks,
Laxman


On Saturday 30 January 2016 10:08 PM, Laxman Dewangan wrote:
> MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the
> multiple DCDC and LDOs. This supplies the power to different
> components of the system.
> Also these rails has configuration for ramp time, flexible
> power sequence, slew rate etc.
>
> Add regulator driver to access these rails via regulator APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>
> - Cleanup code based on comment received on mfd/rtc.
> - Avoid duplication on error message.
>
> Changes form V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - Refactor Regulator driver to use core API for DT parsing.
> - Update based on API changes.
>
> Changes from V3:
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
>   
> Changes from V4:
> - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt
> - Detail out properties.
>
> Changes from V5:
> - Separate out DT binding doc for regulator.
>
> Changes from V6:
> - Use direct regmap APIs.
> - Drop active-discharge configuration as it wil be move to core and through
>    callback. Follow on patches are palnned for this.
>

  reply	other threads:[~2016-02-09 15:14 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30 16:38 [PATCH V7 0/8] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan
2016-01-30 16:38 ` Laxman Dewangan
2016-01-30 16:38 ` [rtc-linux] " Laxman Dewangan
2016-01-30 16:38 ` [PATCH V7 1/8] mfd: add device-tree binding doc for PMIC max77620/max20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-02-09 15:42   ` Lee Jones
2016-02-09 15:42     ` Lee Jones
2016-02-09 15:42     ` [rtc-linux] " Lee Jones
2016-02-09 17:56     ` Laxman Dewangan
2016-02-09 17:56       ` Laxman Dewangan
2016-02-09 17:56       ` [rtc-linux] " Laxman Dewangan
2016-02-10 13:23       ` Lee Jones
2016-02-10 13:23         ` [rtc-linux] " Lee Jones
2016-02-10 13:48         ` Laxman Dewangan
2016-02-10 13:48           ` Laxman Dewangan
2016-02-10 13:48           ` [rtc-linux] " Laxman Dewangan
2016-02-11  9:26           ` Lee Jones
2016-02-11  9:26             ` [rtc-linux] " Lee Jones
2016-02-11 10:19             ` Laxman Dewangan
2016-02-11 10:19               ` Laxman Dewangan
2016-02-11 10:19               ` [rtc-linux] " Laxman Dewangan
2016-01-30 16:38 ` [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
     [not found]   ` <1454171931-27752-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-30 17:16     ` kbuild test robot
2016-01-30 17:16       ` kbuild test robot
2016-01-30 17:16       ` [rtc-linux] " kbuild test robot
2016-01-30 17:12       ` Laxman Dewangan
2016-01-30 17:12         ` Laxman Dewangan
2016-01-30 17:12         ` [rtc-linux] " Laxman Dewangan
2016-02-01  8:25         ` Lee Jones
2016-02-01  8:25           ` Lee Jones
2016-02-01  8:25           ` [rtc-linux] " Lee Jones
2016-02-01  8:31           ` Laxman Dewangan
2016-02-01  8:31             ` Laxman Dewangan
2016-02-01  8:31             ` [rtc-linux] " Laxman Dewangan
2016-02-01  9:02             ` Lee Jones
2016-02-01  9:02               ` [rtc-linux] " Lee Jones
2016-02-01  9:15               ` Laxman Dewangan
2016-02-01  9:15                 ` Laxman Dewangan
2016-02-01  9:15                 ` [rtc-linux] " Laxman Dewangan
2016-01-30 17:52   ` kbuild test robot
2016-01-30 17:52     ` kbuild test robot
2016-01-30 17:52     ` [rtc-linux] " kbuild test robot
2016-01-30 16:38 ` [PATCH V7 3/8] pinctrl: add DT binding doc for pincontrol of PMIC max77620/max20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-02-05 14:48   ` Linus Walleij
2016-02-05 14:48     ` [rtc-linux] " Linus Walleij
2016-01-30 16:38 ` [PATCH V7 4/8] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-01-30 16:38 ` [PATCH V7 5/8] gpio: add DT binding doc for gpio of PMIC max77620/max20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-02-05 14:48   ` Linus Walleij
2016-02-05 14:48     ` Linus Walleij
2016-02-09 14:29     ` Lee Jones
2016-02-09 14:29       ` Lee Jones
2016-02-09 14:29       ` Lee Jones
2016-01-30 16:38 ` [PATCH V7 6/8] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-01-30 16:38 ` [PATCH V7 7/8] regulator: add DT binding doc for regulator of PMIC max77620/max20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-01-30 16:38 ` [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024 Laxman Dewangan
2016-01-30 16:38   ` Laxman Dewangan
2016-01-30 16:38   ` [rtc-linux] " Laxman Dewangan
2016-02-09 15:02   ` Laxman Dewangan [this message]
2016-02-09 15:02     ` Laxman Dewangan
2016-02-09 15:02     ` [rtc-linux] " Laxman Dewangan
2016-02-09 15:36     ` Mark Brown
2016-02-09 15:36       ` [rtc-linux] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B9FF80.7010107@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=k.kozlowski@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mkasoju@nvidia.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=swarren@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=vreddytalla@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.