From: David Long <dave.long@linaro.org>
To: Ingo Molnar <mingo@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"chengang@emindsoft.com.cn" <chengang@emindsoft.com.cn>,
Andy Lutomirski <luto@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Borislav Petkov <bp@suse.de>, Brian Gerst <brgerst@gmail.com>,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
Kees Cook <keescook@chromium.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Rashmica Gupta <rashmicy@gmail.com>,
Rich Felker <dalias@libc.org>, Richard Kuo <rkuo@codeaurora.org>,
Roland McGrath <roland@hack.frob.com>,
Russell King <linux@arm.linux.org.uk>, Thomas Gleixner <tglx>
Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code
Date: Tue, 9 Feb 2016 15:55:02 -0500 [thread overview]
Message-ID: <56BA5226.3090105@linaro.org> (raw)
In-Reply-To: <20160209094526.GB25268@gmail.com>
On 02/09/2016 04:45 AM, Ingo Molnar wrote:
>
> * Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
>>
>>> From: "David A. Long" <dave.long@linaro.org>
>>>
>>> Move duplicate and functionally equivalent code for accessing registers
>>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
>>> common kernel files.
>>>
>>> I'm sending this out again (with updated distribution list) because v2
>>> just never got pulled in, even though I don't think there were any
>>> outstanding issues.
>>
>> A big cross arch patch like this would often get taken by Andrew Morton, but
>> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
>> us :D
>
> The other problem is that the second patch is commingling changes to 6 separate
> architectures:
>
> 16 files changed, 106 insertions(+), 343 deletions(-)
>
> that should probably be 6 separate patches. Easier to review, easier to bisect to,
> easier to revert, etc.
>
> Thanks,
>
> Ingo
>
I see your point but I'm not sure it could have been broken into
separate successive patches that would each build for all architectures.
-dl
WARNING: multiple messages have this Message-ID (diff)
From: David Long <dave.long@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code
Date: Tue, 09 Feb 2016 20:55:02 +0000 [thread overview]
Message-ID: <56BA5226.3090105@linaro.org> (raw)
In-Reply-To: <20160209094526.GB25268@gmail.com>
On 02/09/2016 04:45 AM, Ingo Molnar wrote:
>
> * Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
>>
>>> From: "David A. Long" <dave.long@linaro.org>
>>>
>>> Move duplicate and functionally equivalent code for accessing registers
>>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
>>> common kernel files.
>>>
>>> I'm sending this out again (with updated distribution list) because v2
>>> just never got pulled in, even though I don't think there were any
>>> outstanding issues.
>>
>> A big cross arch patch like this would often get taken by Andrew Morton, but
>> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
>> us :D
>
> The other problem is that the second patch is commingling changes to 6 separate
> architectures:
>
> 16 files changed, 106 insertions(+), 343 deletions(-)
>
> that should probably be 6 separate patches. Easier to review, easier to bisect to,
> easier to revert, etc.
>
> Thanks,
>
> Ingo
>
I see your point but I'm not sure it could have been broken into
separate successive patches that would each build for all architectures.
-dl
WARNING: multiple messages have this Message-ID (diff)
From: David Long <dave.long@linaro.org>
To: Ingo Molnar <mingo@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"chengang@emindsoft.com.cn" <chengang@emindsoft.com.cn>,
Andy Lutomirski <luto@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Borislav Petkov <bp@suse.de>, Brian Gerst <brgerst@gmail.com>,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
Kees Cook <keescook@chromium.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Rashmica Gupta <rashmicy@gmail.com>,
Rich Felker <dalias@libc.org>, Richard Kuo <rkuo@codeaurora.org>,
Roland McGrath <roland@hack.frob.com>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-arm-kernel@lists.infradead.org,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org
Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code
Date: Tue, 9 Feb 2016 15:55:02 -0500 [thread overview]
Message-ID: <56BA5226.3090105@linaro.org> (raw)
In-Reply-To: <20160209094526.GB25268@gmail.com>
On 02/09/2016 04:45 AM, Ingo Molnar wrote:
>
> * Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
>>
>>> From: "David A. Long" <dave.long@linaro.org>
>>>
>>> Move duplicate and functionally equivalent code for accessing registers
>>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
>>> common kernel files.
>>>
>>> I'm sending this out again (with updated distribution list) because v2
>>> just never got pulled in, even though I don't think there were any
>>> outstanding issues.
>>
>> A big cross arch patch like this would often get taken by Andrew Morton, but
>> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
>> us :D
>
> The other problem is that the second patch is commingling changes to 6 separate
> architectures:
>
> 16 files changed, 106 insertions(+), 343 deletions(-)
>
> that should probably be 6 separate patches. Easier to review, easier to bisect to,
> easier to revert, etc.
>
> Thanks,
>
> Ingo
>
I see your point but I'm not sure it could have been broken into
separate successive patches that would each build for all architectures.
-dl
WARNING: multiple messages have this Message-ID (diff)
From: dave.long@linaro.org (David Long)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] Consolidate redundant register/stack access code
Date: Tue, 9 Feb 2016 15:55:02 -0500 [thread overview]
Message-ID: <56BA5226.3090105@linaro.org> (raw)
In-Reply-To: <20160209094526.GB25268@gmail.com>
On 02/09/2016 04:45 AM, Ingo Molnar wrote:
>
> * Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
>>
>>> From: "David A. Long" <dave.long@linaro.org>
>>>
>>> Move duplicate and functionally equivalent code for accessing registers
>>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
>>> common kernel files.
>>>
>>> I'm sending this out again (with updated distribution list) because v2
>>> just never got pulled in, even though I don't think there were any
>>> outstanding issues.
>>
>> A big cross arch patch like this would often get taken by Andrew Morton, but
>> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
>> us :D
>
> The other problem is that the second patch is commingling changes to 6 separate
> architectures:
>
> 16 files changed, 106 insertions(+), 343 deletions(-)
>
> that should probably be 6 separate patches. Easier to review, easier to bisect to,
> easier to revert, etc.
>
> Thanks,
>
> Ingo
>
I see your point but I'm not sure it could have been broken into
separate successive patches that would each build for all architectures.
-dl
next prev parent reply other threads:[~2016-02-09 20:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 5:38 [PATCH v3 0/2] Consolidate redundant register/stack access code David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` [PATCH v3 1/2] Move the pt_regs_offset struct definition from arch to common include file David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` [PATCH v3 2/2] Consolidate redundant register/stack access code David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` David Long
2016-02-09 5:38 ` David Long
2016-02-09 9:36 ` [PATCH v3 0/2] " Michael Ellerman
2016-02-09 9:36 ` Michael Ellerman
2016-02-09 9:36 ` Michael Ellerman
2016-02-09 9:36 ` Michael Ellerman
2016-02-09 9:45 ` Ingo Molnar
2016-02-09 9:45 ` Ingo Molnar
2016-02-09 9:45 ` Ingo Molnar
2016-02-09 9:45 ` Ingo Molnar
2016-02-09 20:55 ` David Long [this message]
2016-02-09 20:55 ` David Long
2016-02-09 20:55 ` David Long
2016-02-09 20:55 ` David Long
2016-02-17 9:45 ` Ingo Molnar
2016-02-17 9:45 ` Ingo Molnar
2016-02-17 9:45 ` Ingo Molnar
2016-02-17 9:45 ` Ingo Molnar
2016-02-09 20:53 ` David Long
2016-02-09 20:53 ` David Long
2016-02-09 20:53 ` David Long
2016-02-09 20:53 ` David Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA5226.3090105@linaro.org \
--to=dave.long@linaro.org \
--cc=JBeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=chengang@emindsoft.com.cn \
--cc=dahi@linux.vnet.ibm.com \
--cc=dalias@libc.org \
--cc=dvlasenk@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=rashmicy@gmail.com \
--cc=rkuo@codeaurora.org \
--cc=roland@hack.frob.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.