All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v4 2/3] clocksource: Add NPS400 timers driver
Date: Thu, 11 Feb 2016 09:18:42 +0100	[thread overview]
Message-ID: <56BC43E2.9030306@linaro.org> (raw)
In-Reply-To: <1455159741-21722-3-git-send-email-noamc@ezchip.com>

On 02/11/2016 04:02 AM, Noam Camus wrote:
> From: Noam Camus <noamc at ezchip.com>
>
> Add internal tick generator which is shared by all cores.
> Each cluster of cores view it through dedicated address.
> This is used for SMP system where all CPUs synced by same
> clock source.
>
> Signed-off-by: Noam Camus <noamc at ezchip.com>
> Cc: Daniel Lezcano <daniel.lezcano at linaro.org>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: John Stultz <john.stultz at linaro.org>
> Acked-by: Vineet Gupta <vgupta at synopsys.com>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano at linaro.org>

but ...

[ ... ]

> +	clk = of_clk_get(node, 0);
> +	if (IS_ERR(clk))
> +		panic("Can't get timer clock");

                 ^^^^^^

I failed to see that at in the previous review.

Thanks

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Noam Camus <noamc@ezchip.com>, linux-kernel@vger.kernel.org
Cc: linux-snps-arc@lists.infradead.org, marc.zyngier@arm.com,
	cmetcalf@ezchip.com, talz@ezchip.com, giladb@ezchip.com,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v4 2/3] clocksource: Add NPS400 timers driver
Date: Thu, 11 Feb 2016 09:18:42 +0100	[thread overview]
Message-ID: <56BC43E2.9030306@linaro.org> (raw)
In-Reply-To: <1455159741-21722-3-git-send-email-noamc@ezchip.com>

On 02/11/2016 04:02 AM, Noam Camus wrote:
> From: Noam Camus <noamc@ezchip.com>
>
> Add internal tick generator which is shared by all cores.
> Each cluster of cores view it through dedicated address.
> This is used for SMP system where all CPUs synced by same
> clock source.
>
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: John Stultz <john.stultz@linaro.org>
> Acked-by: Vineet Gupta <vgupta@synopsys.com>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

but ...

[ ... ]

> +	clk = of_clk_get(node, 0);
> +	if (IS_ERR(clk))
> +		panic("Can't get timer clock");

                 ^^^^^^

I failed to see that at in the previous review.

Thanks

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2016-02-11  8:18 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 13:14 [PATCH v2 0/3] Adding NPS400 drivers Noam Camus
2016-02-02 13:14 ` Noam Camus
2016-02-02 13:14 ` [PATCH v2 1/3] soc: Support for EZchip SoC Noam Camus
2016-02-02 13:14   ` Noam Camus
2016-02-02 13:14 ` [PATCH v2 2/3] clocksource: Add NPS400 timers driver Noam Camus
2016-02-02 13:14   ` Noam Camus
2016-02-02 14:36   ` kbuild test robot
2016-02-02 14:36     ` kbuild test robot
2016-02-02 13:14 ` [PATCH v2 3/3] irqchip: add nps Internal and external irqchips Noam Camus
2016-02-02 13:14   ` Noam Camus
2016-02-02 13:35   ` Thomas Gleixner
2016-02-02 13:35     ` Thomas Gleixner
2016-02-02 20:40   ` kbuild test robot
2016-02-02 20:40     ` kbuild test robot
2016-02-06 16:16 ` [PATCH v3 0/3] Adding NPS400 drivers Noam Camus
2016-02-06 16:16   ` Noam Camus
2016-02-11  3:02   ` [PATCH v4 " Noam Camus
2016-02-11  3:02     ` Noam Camus
2016-02-11 18:40     ` [PATCH v5 " Noam Camus
2016-02-11 18:40       ` Noam Camus
2016-02-17  7:05       ` Noam Camus
2016-02-17  7:05         ` Noam Camus
2016-02-11 18:40     ` [PATCH v5 1/3] soc: Support for EZchip SoC Noam Camus
2016-02-11 18:40       ` Noam Camus
2016-02-11 18:40     ` [PATCH v5 2/3] clocksource: Add NPS400 timers driver Noam Camus
2016-02-11 18:40       ` Noam Camus
2016-02-11 20:29       ` Daniel Lezcano
2016-02-11 20:29         ` Daniel Lezcano
2016-02-11 18:40     ` [PATCH v5 3/3] irqchip: add nps Internal and external irqchips Noam Camus
2016-02-11 18:40       ` Noam Camus
2016-02-19 14:03       ` Jason Cooper
2016-02-19 14:03         ` Jason Cooper
2016-02-19 14:42         ` Noam Camus
2016-02-19 14:42           ` Noam Camus
2016-02-11  3:02   ` [PATCH v4 1/3] soc: Support for EZchip SoC Noam Camus
2016-02-11  3:02     ` Noam Camus
2016-02-11  3:02   ` [PATCH v4 2/3] clocksource: Add NPS400 timers driver Noam Camus
2016-02-11  3:02     ` Noam Camus
2016-02-11  8:18     ` Daniel Lezcano [this message]
2016-02-11  8:18       ` Daniel Lezcano
2016-02-11  3:02   ` [PATCH v4 3/3] irqchip: add nps Internal and external irqchips Noam Camus
2016-02-11  3:02     ` Noam Camus
2016-02-06 16:16 ` [PATCH v3 1/3] soc: Support for EZchip SoC Noam Camus
2016-02-06 16:16   ` Noam Camus
2016-02-06 16:16 ` [PATCH v3 2/3] clocksource: Add NPS400 timers driver Noam Camus
2016-02-06 16:16   ` Noam Camus
2016-02-08 14:21   ` Daniel Lezcano
2016-02-08 14:21     ` Daniel Lezcano
2016-02-09 12:36     ` Noam Camus
2016-02-09 12:36       ` Noam Camus
2016-02-09 13:38       ` Daniel Lezcano
2016-02-09 13:38         ` Daniel Lezcano
2016-02-09 21:47         ` Noam Camus
2016-02-09 21:47           ` Noam Camus
2016-02-09 22:55           ` Daniel Lezcano
2016-02-09 22:55             ` Daniel Lezcano
2016-02-10  8:01             ` Noam Camus
2016-02-10  8:01               ` Noam Camus
2016-02-06 16:16 ` [PATCH v3 3/3] irqchip: add nps Internal and external irqchips Noam Camus
2016-02-06 16:16   ` Noam Camus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BC43E2.9030306@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.