* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
@ 2016-02-14 6:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2016-02-14 6:34 UTC (permalink / raw)
To: rtc-linux, linux-kernel, Javier Martinez Canillas
Cc: k.kozlowski.k, devicetree, linux-samsung-soc, Alexandre Belloni,
Rob Herring, Alessandro Zummo
W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
> The S3C Real Time Clock driver requires the clock and source clock to
> be defined in the device node but that requirement is not documented.
+Cc: Alessandro Zummo
No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
but rest of compatible devices need only rtc clock.
Best regards,
Krzysztof
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
> index ac2fcd6ff4b8..1068ffce9f91 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
> @@ -14,6 +14,10 @@ Required properties:
> interrupt number is the rtc alarm interrupt and second interrupt number
> is the rtc tick interrupt. The number of cells representing a interrupt
> depends on the parent interrupt controller.
> +- clocks: Must contain a list of phandle and clock specifier for the rtc
> + and source clocks.
> +- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the
> + same order as the clocks property.
>
> Example:
>
> @@ -21,4 +25,6 @@ Example:
> compatible = "samsung,s3c6410-rtc";
> reg = <0x10070000 0x100>;
> interrupts = <44 0 45 0>;
> + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
> + clock-names = "rtc", "rtc_src";
> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
@ 2016-02-14 6:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2016-02-14 6:34 UTC (permalink / raw)
To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Javier Martinez Canillas
Cc: k.kozlowski.k-Re5JQEeQqe8AvxtiuMwx3w,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Alexandre Belloni,
Rob Herring, Alessandro Zummo
W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
> The S3C Real Time Clock driver requires the clock and source clock to
> be defined in the device node but that requirement is not documented.
+Cc: Alessandro Zummo
No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
but rest of compatible devices need only rtc clock.
Best regards,
Krzysztof
>
> Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
>
> ---
>
> Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
> index ac2fcd6ff4b8..1068ffce9f91 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
> @@ -14,6 +14,10 @@ Required properties:
> interrupt number is the rtc alarm interrupt and second interrupt number
> is the rtc tick interrupt. The number of cells representing a interrupt
> depends on the parent interrupt controller.
> +- clocks: Must contain a list of phandle and clock specifier for the rtc
> + and source clocks.
> +- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the
> + same order as the clocks property.
>
> Example:
>
> @@ -21,4 +25,6 @@ Example:
> compatible = "samsung,s3c6410-rtc";
> reg = <0x10070000 0x100>;
> interrupts = <44 0 45 0>;
> + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
> + clock-names = "rtc", "rtc_src";
> };
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
@ 2016-02-15 12:49 ` Javier Martinez Canillas
0 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2016-02-15 12:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, rtc-linux, linux-kernel
Cc: k.kozlowski.k, devicetree, linux-samsung-soc, Alexandre Belloni,
Rob Herring, Alessandro Zummo
Hello Krzysztof,
Thanks a lot for your feedback.
On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>
I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.
> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>
Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
@ 2016-02-15 12:49 ` Javier Martinez Canillas
0 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2016-02-15 12:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, rtc-linux, linux-kernel
Cc: k.kozlowski.k, devicetree, linux-samsung-soc, Alexandre Belloni,
Rob Herring, Alessandro Zummo
Hello Krzysztof,
Thanks a lot for your feedback.
On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>
I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.
> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>
Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
@ 2016-02-15 12:49 ` Javier Martinez Canillas
0 siblings, 0 replies; 10+ messages in thread
From: Javier Martinez Canillas @ 2016-02-15 12:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, rtc-linux-/JYPxA39Uh5TLH3MbocFFw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: k.kozlowski.k-Re5JQEeQqe8AvxtiuMwx3w,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Alexandre Belloni,
Rob Herring, Alessandro Zummo
Hello Krzysztof,
Thanks a lot for your feedback.
On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>
I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.
> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>
Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
2016-02-15 12:49 ` Javier Martinez Canillas
@ 2016-02-15 13:41 ` Alexandre Belloni
-1 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2016-02-15 13:41 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Krzysztof Kozlowski, rtc-linux, linux-kernel, k.kozlowski.k,
devicetree, linux-samsung-soc, Rob Herring, Alessandro Zummo
On 15/02/2016 at 09:49:34 -0300, Javier Martinez Canillas wrote :
> >No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> >but rest of compatible devices need only rtc clock.
> >
>
> Right, sorry for missing that. I noticed that this patch has already
> been picked by Rob Herring (I thought it would be picked by Alexandre
> though) so I will post a follow up patch explaining that rtc_src is
> only for the s3c6410-rtc compatible.
>
Yeah, I was going to take it, thanks for pointing out the Rob already
has it in his tree.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
@ 2016-02-15 13:41 ` Alexandre Belloni
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2016-02-15 13:41 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Krzysztof Kozlowski, rtc-linux, linux-kernel, k.kozlowski.k,
devicetree, linux-samsung-soc, Rob Herring, Alessandro Zummo
On 15/02/2016 at 09:49:34 -0300, Javier Martinez Canillas wrote :
> >No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> >but rest of compatible devices need only rtc clock.
> >
>
> Right, sorry for missing that. I noticed that this patch has already
> been picked by Rob Herring (I thought it would be picked by Alexandre
> though) so I will post a follow up patch explaining that rtc_src is
> only for the s3c6410-rtc compatible.
>
Yeah, I was going to take it, thanks for pointing out the Rob already
has it in his tree.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread