All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Subject: Re: [PATCH v4 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi
Date: Mon, 15 Feb 2016 11:36:36 +0800	[thread overview]
Message-ID: <56C147C4.20704@gmail.com> (raw)
In-Reply-To: <42802946.20XC68fnyM@phil>



在 2016年02月09日 16:30, Heiko Stuebner 写道:
> Hi Caesar,
>
> Am Montag, 9. November 2015, 12:49:01 schrieb Caesar Wang:
>> This patch add the thermal needed info on RK3368.
>> Meanwhile, support the trips to throttle for thermal.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> Acked-by: Eduardo Valentin <edubezval@gmail.com>
> [...]
>
>> @@ -829,6 +855,16 @@
>>   			};
>>   		};
>>
>> +		tsadc {
>> +			otp_gpio: otp-gpio {
>> +				rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
>> +			};
>> +
>> +			otp_out: otp-out {
>> +				rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
>> +			};
>> +		};
>> +
>>   		uart0 {
>>   			uart0_xfer: uart0-xfer {
>>   				rockchip,pins = <2 24 RK_FUNC_1 &pcfg_pull_up>,
> As it came up just now, these pinctrl settings seem strange. I.e. according
> to the TRM gpio0b2 [= gpio0 10] func_1 is sc_rst, which seems to be the
> smartcard controller?
>
> It came up because it seems the Tronsmart R68 board seems to use this pin
> for controlling the vcc_host regulator instead.

Yep, that's the incorrect over-temperature protection pin. :-(

Fixed in https://patchwork.kernel.org/patch/8308831/

Thanks Heiko.

>
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
Thanks,
Caesar


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: caesar.upstream@gmail.com (Caesar Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi
Date: Mon, 15 Feb 2016 11:36:36 +0800	[thread overview]
Message-ID: <56C147C4.20704@gmail.com> (raw)
In-Reply-To: <42802946.20XC68fnyM@phil>



? 2016?02?09? 16:30, Heiko Stuebner ??:
> Hi Caesar,
>
> Am Montag, 9. November 2015, 12:49:01 schrieb Caesar Wang:
>> This patch add the thermal needed info on RK3368.
>> Meanwhile, support the trips to throttle for thermal.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> Acked-by: Eduardo Valentin <edubezval@gmail.com>
> [...]
>
>> @@ -829,6 +855,16 @@
>>   			};
>>   		};
>>
>> +		tsadc {
>> +			otp_gpio: otp-gpio {
>> +				rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
>> +			};
>> +
>> +			otp_out: otp-out {
>> +				rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
>> +			};
>> +		};
>> +
>>   		uart0 {
>>   			uart0_xfer: uart0-xfer {
>>   				rockchip,pins = <2 24 RK_FUNC_1 &pcfg_pull_up>,
> As it came up just now, these pinctrl settings seem strange. I.e. according
> to the TRM gpio0b2 [= gpio0 10] func_1 is sc_rst, which seems to be the
> smartcard controller?
>
> It came up because it seems the Tronsmart R68 board seems to use this pin
> for controlling the vcc_host regulator instead.

Yep, that's the incorrect over-temperature protection pin. :-(

Fixed in https://patchwork.kernel.org/patch/8308831/

Thanks Heiko.

>
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
Thanks,
Caesar

  reply	other threads:[~2016-02-15  3:36 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09  4:48 [PATCH v4 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs Caesar Wang
2015-11-09  4:48 ` Caesar Wang
2015-11-09  4:48 ` Caesar Wang
     [not found] ` <1447044542-30859-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-09  4:48   ` [PATCH v4 01/10] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48   ` [PATCH v4 02/10] thermal: rockchip: better to compatible the driver for different SoCs Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48   ` [PATCH v4 03/10] thermal: rockchip: trivial: fix typo in commit Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48   ` [PATCH v4 04/10] thermal: rockchip: improve the conversion function Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:48     ` Caesar Wang
2015-11-09  4:49   ` [PATCH v4 08/10] arm64: dts: Add the thermal data found on RK3368 Caesar Wang
2015-11-09  4:49     ` Caesar Wang
2015-11-09  4:49     ` Caesar Wang
2015-11-09  4:49   ` [PATCH v4 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi Caesar Wang
2015-11-09  4:49     ` Caesar Wang
2015-11-09  4:49     ` Caesar Wang
     [not found]     ` <1447044542-30859-10-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-09  8:30       ` Heiko Stuebner
2016-02-09  8:30         ` Heiko Stuebner
2016-02-15  3:36         ` Caesar Wang [this message]
2016-02-15  3:36           ` Caesar Wang
2015-11-09  4:48 ` [PATCH v4 05/10] thermal: rockchip: Add the sort mode for adc value increment or decrement Caesar Wang
2015-11-09  4:48   ` Caesar Wang
2015-11-09  4:48 ` [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures Caesar Wang
2015-11-09  4:48   ` Caesar Wang
     [not found]   ` <1447044542-30859-7-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-12-02 18:38     ` Brian Norris
2015-12-02 18:38       ` Brian Norris
2015-12-02 18:38       ` Brian Norris
     [not found]       ` <565F8FFE.3080807@rock-chips.com>
     [not found]         ` <565F8FFE.3080807-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-12-03  0:49           ` Brian Norris
2015-12-03  0:49             ` Brian Norris
2015-12-03  0:49             ` Brian Norris
2015-12-03  1:16             ` Caesar Wang
2015-12-03  1:16               ` Caesar Wang
2015-11-09  4:48 ` [PATCH v4 07/10] thermal: rockchip: Support the RK3368 SoCs in thermal driver Caesar Wang
2015-11-09  4:48   ` Caesar Wang
2015-11-09  4:49 ` [PATCH v4 10/10] arm64: dts: Enable the Thermal on R88 board Caesar Wang
2015-11-09  4:49   ` Caesar Wang
2015-11-12 18:29 ` [PATCH v4 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs Eduardo Valentin
2015-11-12 18:29   ` Eduardo Valentin
2015-11-12 18:31   ` Eduardo Valentin
2015-11-12 18:31     ` Eduardo Valentin
     [not found]     ` <20151112183119.GA5289-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-11-21 16:41       ` Heiko Stuebner
2015-11-21 16:41         ` Heiko Stuebner
2015-11-21 16:41         ` Heiko Stuebner
2015-11-12 22:14   ` Heiko Stuebner
2015-11-12 22:14     ` Heiko Stuebner
2015-11-14  6:31     ` Caesar Wang
2015-11-14  6:31       ` Caesar Wang
     [not found]   ` <20151112182950.GB4361-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-11-14  6:30     ` Caesar Wang
2015-11-14  6:30       ` Caesar Wang
2015-11-14  6:30       ` Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C147C4.20704@gmail.com \
    --to=caesar.upstream-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.