From: Mugunthan V N <mugunthanvnm@ti.com>
To: "David Rivshin (Allworx)" <drivshin.allworx@gmail.com>,
netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
David Miller <davem@davemloft.net>,
Nicolas Chauvet <kwizart@gmail.com>
Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode
Date: Mon, 15 Feb 2016 11:45:59 +0530 [thread overview]
Message-ID: <56C16D1F.7060601@ti.com> (raw)
In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com>
On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@allworx.com>
>
> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
> and silently handled any other values as if MII was specified. In a
> case where the PHY mode was incorrectly specified, or a bug elsewhere,
> there would be no indication of a problem. If MII was the correct mode,
> then this will go unnoticed, otherwise the symptom will be a failure
> to transmit/receive data over the RMII/RGMII link.
>
> Add a dev_warn() to make this condition obvious and provide a
> breadcrumb to follow.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: David Rivshin <drivshin@allworx.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode
Date: Mon, 15 Feb 2016 11:45:59 +0530 [thread overview]
Message-ID: <56C16D1F.7060601@ti.com> (raw)
In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com>
On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@allworx.com>
>
> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
> and silently handled any other values as if MII was specified. In a
> case where the PHY mode was incorrectly specified, or a bug elsewhere,
> there would be no indication of a problem. If MII was the correct mode,
> then this will go unnoticed, otherwise the symptom will be a failure
> to transmit/receive data over the RMII/RGMII link.
>
> Add a dev_warn() to make this condition obvious and provide a
> breadcrumb to follow.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: David Rivshin <drivshin@allworx.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: "David Rivshin (Allworx)" <drivshin.allworx@gmail.com>,
<netdev@vger.kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, David Miller <davem@davemloft.net>,
Nicolas Chauvet <kwizart@gmail.com>
Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode
Date: Mon, 15 Feb 2016 11:45:59 +0530 [thread overview]
Message-ID: <56C16D1F.7060601@ti.com> (raw)
In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com>
On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@allworx.com>
>
> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
> and silently handled any other values as if MII was specified. In a
> case where the PHY mode was incorrectly specified, or a bug elsewhere,
> there would be no indication of a problem. If MII was the correct mode,
> then this will go unnoticed, otherwise the symptom will be a failure
> to transmit/receive data over the RMII/RGMII link.
>
> Add a dev_warn() to make this condition obvious and provide a
> breadcrumb to follow.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: David Rivshin <drivshin@allworx.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2016-02-15 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 0:45 [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode David Rivshin (Allworx)
2016-02-13 0:45 ` David Rivshin (Allworx)
2016-02-15 6:15 ` Mugunthan V N [this message]
2016-02-15 6:15 ` Mugunthan V N
2016-02-15 6:15 ` Mugunthan V N
2016-02-17 15:51 ` David Miller
2016-02-17 15:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C16D1F.7060601@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=drivshin.allworx@gmail.com \
--cc=kwizart@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.