From: David Daney <ddaney@caviumnetworks.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Tirumalesh Chalamarla <tchalamarla@caviumnetworks.com>,
stripathi@apm.com, David Daney <ddaney@caviumnetworks.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Robert Richter <rric@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536
Date: Wed, 17 Feb 2016 10:57:50 -0800 [thread overview]
Message-ID: <56C4C2AE.90009@caviumnetworks.com> (raw)
In-Reply-To: <20160217112931.GB31970@arm.com>
On 02/17/2016 03:29 AM, Will Deacon wrote:
> On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote:
>> On 02/16/2016 01:14 PM, Robert Richter wrote:
>>> CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only
>>> used for core interrupts, e.g. also for gicv3 devices (and now also
>>> for ahci). Non-core errata (e.g. CONFIG_CAVIUM_ERRATUM_23144) are not
>>> enabled in the arm64 cpu errata framework (not handled in
>>> arch/arm64/kernel/cpu_errata.c).
>>>
>>> Thus,
>>>
>>> #ifdef CONFIG_CAVIUM_ERRATUM_22536
>>> if (pdev->vendor == 0x177d && pdev->device == 0xa01c)
>>> ahci_thunderx_init(&pdev->dev, hpriv);
>>> #endif
>>>
>>> is the correct enablement of the workaround by device id.
>>>
>>> And, CAVIUM_ERRATUM_* is very easy to handle, enable and document.
>>>
>> The code will only run for Thunder and AHCI, becuase its PCI.
>
> Well, the guards also serve as documentation for exactly why we're having
> to do something special here, so I'd say go ahead and add
> CONFIG_CAVIUM_ERRATUM_22536 and update
> Documentation/arm64/silicon-errata.txt accordingly.
>
If the ahci/ata maintainers insist, we can add that.
<sarcasm>
Should we also add some CONFIG_ variables for:
ahci_mcp89_apple_enable()
ahci_sb600_enable_64bit()
ahci_p5wdh_workaround()
.
.
.
Surely we would wish to give people the flexibility to trim that code
out of the driver if they know that it is not needed.
And don't even get me started on drivers/pci/quirks.c ...
</sarcasm>
>
>
> Will
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536
Date: Wed, 17 Feb 2016 10:57:50 -0800 [thread overview]
Message-ID: <56C4C2AE.90009@caviumnetworks.com> (raw)
In-Reply-To: <20160217112931.GB31970@arm.com>
On 02/17/2016 03:29 AM, Will Deacon wrote:
> On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote:
>> On 02/16/2016 01:14 PM, Robert Richter wrote:
>>> CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only
>>> used for core interrupts, e.g. also for gicv3 devices (and now also
>>> for ahci). Non-core errata (e.g. CONFIG_CAVIUM_ERRATUM_23144) are not
>>> enabled in the arm64 cpu errata framework (not handled in
>>> arch/arm64/kernel/cpu_errata.c).
>>>
>>> Thus,
>>>
>>> #ifdef CONFIG_CAVIUM_ERRATUM_22536
>>> if (pdev->vendor == 0x177d && pdev->device == 0xa01c)
>>> ahci_thunderx_init(&pdev->dev, hpriv);
>>> #endif
>>>
>>> is the correct enablement of the workaround by device id.
>>>
>>> And, CAVIUM_ERRATUM_* is very easy to handle, enable and document.
>>>
>> The code will only run for Thunder and AHCI, becuase its PCI.
>
> Well, the guards also serve as documentation for exactly why we're having
> to do something special here, so I'd say go ahead and add
> CONFIG_CAVIUM_ERRATUM_22536 and update
> Documentation/arm64/silicon-errata.txt accordingly.
>
If the ahci/ata maintainers insist, we can add that.
<sarcasm>
Should we also add some CONFIG_ variables for:
ahci_mcp89_apple_enable()
ahci_sb600_enable_64bit()
ahci_p5wdh_workaround()
.
.
.
Surely we would wish to give people the flexibility to trim that code
out of the driver if they know that it is not needed.
And don't even get me started on drivers/pci/quirks.c ...
</sarcasm>
>
>
> Will
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Tirumalesh Chalamarla <tchalamarla@caviumnetworks.com>,
<stripathi@apm.com>, David Daney <ddaney@caviumnetworks.com>,
<linux-kernel@vger.kernel.org>, <linux-ide@vger.kernel.org>,
Tejun Heo <tj@kernel.org>, Robert Richter <rric@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536
Date: Wed, 17 Feb 2016 10:57:50 -0800 [thread overview]
Message-ID: <56C4C2AE.90009@caviumnetworks.com> (raw)
In-Reply-To: <20160217112931.GB31970@arm.com>
On 02/17/2016 03:29 AM, Will Deacon wrote:
> On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote:
>> On 02/16/2016 01:14 PM, Robert Richter wrote:
>>> CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only
>>> used for core interrupts, e.g. also for gicv3 devices (and now also
>>> for ahci). Non-core errata (e.g. CONFIG_CAVIUM_ERRATUM_23144) are not
>>> enabled in the arm64 cpu errata framework (not handled in
>>> arch/arm64/kernel/cpu_errata.c).
>>>
>>> Thus,
>>>
>>> #ifdef CONFIG_CAVIUM_ERRATUM_22536
>>> if (pdev->vendor == 0x177d && pdev->device == 0xa01c)
>>> ahci_thunderx_init(&pdev->dev, hpriv);
>>> #endif
>>>
>>> is the correct enablement of the workaround by device id.
>>>
>>> And, CAVIUM_ERRATUM_* is very easy to handle, enable and document.
>>>
>> The code will only run for Thunder and AHCI, becuase its PCI.
>
> Well, the guards also serve as documentation for exactly why we're having
> to do something special here, so I'd say go ahead and add
> CONFIG_CAVIUM_ERRATUM_22536 and update
> Documentation/arm64/silicon-errata.txt accordingly.
>
If the ahci/ata maintainers insist, we can add that.
<sarcasm>
Should we also add some CONFIG_ variables for:
ahci_mcp89_apple_enable()
ahci_sb600_enable_64bit()
ahci_p5wdh_workaround()
.
.
.
Surely we would wish to give people the flexibility to trim that code
out of the driver if they know that it is not needed.
And don't even get me started on drivers/pci/quirks.c ...
</sarcasm>
>
>
> Will
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2016-02-17 18:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 23:20 [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 tchalamarla
2016-02-12 23:20 ` tchalamarla
2016-02-12 23:20 ` tchalamarla at caviumnetworks.com
2016-02-13 16:54 ` Sergei Shtylyov
2016-02-13 16:54 ` Sergei Shtylyov
2016-02-14 17:01 ` Tejun Heo
2016-02-14 17:01 ` Tejun Heo
2016-02-15 3:36 ` Tirumalesh Chalamarla
2016-02-15 3:36 ` Tirumalesh Chalamarla
2016-02-15 3:36 ` Tirumalesh Chalamarla
2016-02-15 18:30 ` Tejun Heo
2016-02-15 18:30 ` Tejun Heo
2016-02-16 14:42 ` Robert Richter
2016-02-16 14:42 ` Robert Richter
2016-02-16 19:14 ` Tirumalesh Chalamarla
2016-02-16 19:14 ` Tirumalesh Chalamarla
2016-02-16 19:14 ` Tirumalesh Chalamarla
2016-02-16 19:38 ` David Daney
2016-02-16 19:38 ` David Daney
2016-02-16 19:38 ` David Daney
2016-02-16 19:50 ` Tirumalesh Chalamarla
2016-02-16 19:50 ` Tirumalesh Chalamarla
2016-02-16 19:50 ` Tirumalesh Chalamarla
2016-02-16 21:14 ` Robert Richter
2016-02-16 21:14 ` Robert Richter
2016-02-16 23:13 ` Tirumalesh Chalamarla
2016-02-16 23:13 ` Tirumalesh Chalamarla
2016-02-16 23:13 ` Tirumalesh Chalamarla
2016-02-17 11:29 ` Will Deacon
2016-02-17 11:29 ` Will Deacon
2016-02-17 18:57 ` David Daney [this message]
2016-02-17 18:57 ` David Daney
2016-02-17 18:57 ` David Daney
2016-02-17 20:00 ` Tejun Heo
2016-02-17 20:00 ` Tejun Heo
2016-02-17 21:46 ` Tirumalesh Chalamarla
2016-02-17 21:46 ` Tirumalesh Chalamarla
2016-02-17 21:46 ` Tirumalesh Chalamarla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4C2AE.90009@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
--cc=stripathi@apm.com \
--cc=tchalamarla@caviumnetworks.com \
--cc=tj@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.