From: David Vrabel <david.vrabel@citrix.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>, <bp@alien8.de>
Cc: <rusty@rustcorp.com.au>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, <luto@amacapital.net>,
<xen-devel@lists.xensource.com>, <david.vrabel@citrix.com>,
<boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check
Date: Fri, 19 Feb 2016 13:27:21 +0000 [thread overview]
Message-ID: <56C71839.3090609@citrix.com> (raw)
In-Reply-To: <1455887316-9223-9-git-send-email-mcgrof@kernel.org>
On 19/02/16 13:08, Luis R. Rodriguez wrote:
> The current check is a super long winded way of asking if this
> is on lguest. The flags is used for legacy features, this is
> likely inspired by the ACPI IA-PC boot architecture flags, where
> as for RTC it annotates No CMOS real-time clock present. I don't
> expect we will be implementing more legacy features, its simply
> pointless so just remove this legacy flag feature thing as well.
No. This check is needed for Xen PV domU guests and without it PV
guests don't get a console (as I think the history of the change that
introduced this makes clear).
I think this trend towards a coarse-grained subarch instead of a set of
feature bits is the wrong direction.
David
next prev parent reply other threads:[~2016-02-19 13:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 13:08 [PATCH 0/9] x86/init: replace paravirt_enabled() were possible Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 1/9] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-02-19 13:19 ` [Xen-devel] " Juergen Gross
2016-02-19 13:40 ` David Vrabel
2016-02-19 14:40 ` Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 2/9] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 3/9] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 4/9] x86/init: make ebda depend on PC subarch Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 5/9] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-02-19 15:08 ` Boris Ostrovsky
2016-02-19 20:58 ` Luis R. Rodriguez
2016-02-19 22:17 ` Boris Ostrovsky
2016-02-20 0:42 ` Luis R. Rodriguez
2016-02-22 14:15 ` Boris Ostrovsky
2016-02-19 13:08 ` [PATCH 6/9] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 7/9] x86/cpu/intel: replace paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-02-19 13:08 ` [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check Luis R. Rodriguez
2016-02-19 13:22 ` [Xen-devel] " Juergen Gross
2016-02-19 14:48 ` Luis R. Rodriguez
2016-02-22 6:07 ` Luis R. Rodriguez
2016-02-22 10:27 ` Borislav Petkov
2016-02-22 14:34 ` Boris Ostrovsky
2016-02-22 23:12 ` Luis R. Rodriguez
2016-02-19 13:27 ` David Vrabel [this message]
2016-02-19 13:08 ` [PATCH 9/9] pnpbios: replace paravirt_enabled() check with subarch checks Luis R. Rodriguez
2016-02-19 13:34 ` [Xen-devel] [PATCH 0/9] x86/init: replace paravirt_enabled() were possible David Vrabel
2016-02-19 14:36 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C71839.3090609@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.