From: Doug Goldstein <cardoe@cardoe.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed
Date: Fri, 19 Feb 2016 08:27:21 -0600 [thread overview]
Message-ID: <56C72649.4090905@cardoe.com> (raw)
In-Reply-To: <20160219140036.GB31079@localhost.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 708 bytes --]
On 2/19/16 8:00 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Feb 18, 2016 at 08:57:02PM -0600, Doug Goldstein wrote:
>> bcc/ld86/as86 are only necessary when we build rombios and not always so
>> failing the build when they aren't available should not happen if the
>> user isn't building rombios.
>
> That is quite the long sentence. Perhaps trim it down to:
>
> "are necessary when we build ROMBIOS. However if we do not build it
> (not building qemu-trad) - the build requirements are overly strict
> and can lead to failures." ?
>
> Otherwise
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
Agreed. That's better. Thank you for the review.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-19 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 2:57 [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Doug Goldstein
2016-02-19 2:57 ` [PATCH v2 2/4] m4/python: fix typo in LDFLAGS variable name Doug Goldstein
2016-02-19 14:02 ` Konrad Rzeszutek Wilk
2016-02-22 16:10 ` Ian Jackson
2016-02-19 2:57 ` [PATCH v2 3/4] m4/python: fix checks for Python library support Doug Goldstein
2016-02-22 16:22 ` Ian Jackson
2016-02-22 19:14 ` Doug Goldstein
2016-02-29 18:00 ` Doug Goldstein
2016-03-01 18:06 ` Ian Jackson
2016-02-23 2:25 ` Doug Goldstein
2016-02-19 2:57 ` [PATCH v2 4/4] configure: rerun autoconf Doug Goldstein
2016-02-22 16:20 ` Ian Jackson
2016-02-19 14:00 ` [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Konrad Rzeszutek Wilk
2016-02-19 14:27 ` Doug Goldstein [this message]
2016-02-22 14:37 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C72649.4090905@cardoe.com \
--to=cardoe@cardoe.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.