From: Doug Goldstein <cardoe@cardoe.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/4] m4/python: fix checks for Python library support
Date: Mon, 22 Feb 2016 20:25:27 -0600 [thread overview]
Message-ID: <56CBC317.60708@cardoe.com> (raw)
In-Reply-To: <22219.13751.865220.68830@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1113 bytes --]
On 2/22/16 10:22 AM, Ian Jackson wrote:
> Doug Goldstein writes ("[PATCH v2 3/4] m4/python: fix checks for Python library support"):
>> AC_CHECK_LIB() was running gcc -Llib -lm -lutils conftest.c which on
>> platforms that do as needed operations by default will result in
>> underlinking. Instead AC_CHECK_LIB() suggests supplying the extra
>> libraries necessary in a 5th argument.
>
> I'm afraid I don't quite follow why the code in the patch has the
> effect you desire. Why does setting LDFLAGS not work ? Forgive me if
> I'm being dense - I'm afraid I have a cold.
>
> Regards,
> Ian.
>
In fact this pattern is repeated all over the code base in makefiles:
libxenctrl.so.$(MAJOR).$(MINOR): $(CTRL_PIC_OBJS)
$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG)
-Wl,libxenctrl.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^
$(LDLIBS_libxentoollog) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab)
$(LDLIBS_libxengntshr) $(LDLIBS_libxencall)
$(LDLIBS_libxenforeignmemory) $(PTHREAD_LIBS) $(APPEND_LDFLAGS)
COMPILER CFLAGS/LDFLAGS -o TARGET SOURCE LIBS
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-23 2:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 2:57 [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Doug Goldstein
2016-02-19 2:57 ` [PATCH v2 2/4] m4/python: fix typo in LDFLAGS variable name Doug Goldstein
2016-02-19 14:02 ` Konrad Rzeszutek Wilk
2016-02-22 16:10 ` Ian Jackson
2016-02-19 2:57 ` [PATCH v2 3/4] m4/python: fix checks for Python library support Doug Goldstein
2016-02-22 16:22 ` Ian Jackson
2016-02-22 19:14 ` Doug Goldstein
2016-02-29 18:00 ` Doug Goldstein
2016-03-01 18:06 ` Ian Jackson
2016-02-23 2:25 ` Doug Goldstein [this message]
2016-02-19 2:57 ` [PATCH v2 4/4] configure: rerun autoconf Doug Goldstein
2016-02-22 16:20 ` Ian Jackson
2016-02-19 14:00 ` [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Konrad Rzeszutek Wilk
2016-02-19 14:27 ` Doug Goldstein
2016-02-22 14:37 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CBC317.60708@cardoe.com \
--to=cardoe@cardoe.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.