From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andreas Gruenbacher <agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
linux-ext4 <linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
XFS Developers <xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux NFS Mailing List
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Anna Schumaker
<anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>,
Andreas Dilger <adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
Subject: Re: richacl(7) man page review comments
Date: Sun, 21 Feb 2016 22:01:25 +0100 [thread overview]
Message-ID: <56CA25A5.2030100@gmail.com> (raw)
In-Reply-To: <CAHc6FU4CCrcrA6=oCiq2A5rGd9CCGELaTZq6tGpmd2jcV_Zp4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote:
> Hi Michael,
>
> thanks again for all the feedback. I've followed all your suggestions;
> again, please see the github repo for the latest version:
>
> https://github.com/andreas-gruenbacher/richacl
>
> On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages)
> <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Hi Andreas,
>>
>> Here's a few more comments on the current richacl(7) page
>> that I fetched from the git repo.
>>
[...]
>>> .HP
>>> .BR dir_inherit "\ (" d ):
>>> The entry is inheritable for directories.
>>
>> "When this flag appears in the ACL entry of a directory, then that entry is
>> inherited by new subdirectories created in the directory."
>>
>> Is that text that I propose correct?
>
> It's not entirely wrong, but only a small part of the truth. Entries
> are inherited such that the permissions in file_inherit entries become
> effective for access checking for new files, and the permissions in
> dir_inherit entries become effective for access checking for new
> directories, recursively.
>
> Your feedback prompted me to look into the inheritance flag
> computation more closely once again, and I found bugs. The steps of
> the algorithm are explained in the section "Permissions at
> file-creation time", by the way.
Hmmm... writing and refining documentation helps find code bugs.
Who knew? :-)
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: mtk.manpages@gmail.com, "J. Bruce Fields" <bfields@fieldses.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
XFS Developers <xfs@oss.sgi.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-cifs@vger.kernel.org, Linux API <linux-api@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Jeff Layton <jlayton@poochiereds.net>,
Andreas Dilger <adilger@dilger.ca>
Subject: Re: richacl(7) man page review comments
Date: Sun, 21 Feb 2016 22:01:25 +0100 [thread overview]
Message-ID: <56CA25A5.2030100@gmail.com> (raw)
In-Reply-To: <CAHc6FU4CCrcrA6=oCiq2A5rGd9CCGELaTZq6tGpmd2jcV_Zp4A@mail.gmail.com>
On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote:
> Hi Michael,
>
> thanks again for all the feedback. I've followed all your suggestions;
> again, please see the github repo for the latest version:
>
> https://github.com/andreas-gruenbacher/richacl
>
> On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages)
> <mtk.manpages@gmail.com> wrote:
>> Hi Andreas,
>>
>> Here's a few more comments on the current richacl(7) page
>> that I fetched from the git repo.
>>
[...]
>>> .HP
>>> .BR dir_inherit "\ (" d ):
>>> The entry is inheritable for directories.
>>
>> "When this flag appears in the ACL entry of a directory, then that entry is
>> inherited by new subdirectories created in the directory."
>>
>> Is that text that I propose correct?
>
> It's not entirely wrong, but only a small part of the truth. Entries
> are inherited such that the permissions in file_inherit entries become
> effective for access checking for new files, and the permissions in
> dir_inherit entries become effective for access checking for new
> directories, recursively.
>
> Your feedback prompted me to look into the inheritance flag
> computation more closely once again, and I found bugs. The steps of
> the algorithm are explained in the section "Permissions at
> file-creation time", by the way.
Hmmm... writing and refining documentation helps find code bugs.
Who knew? :-)
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
linux-cifs@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Linux API <linux-api@vger.kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
lkml <linux-kernel@vger.kernel.org>,
XFS Developers <xfs@oss.sgi.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
mtk.manpages@gmail.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jeff Layton <jlayton@poochiereds.net>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: richacl(7) man page review comments
Date: Sun, 21 Feb 2016 22:01:25 +0100 [thread overview]
Message-ID: <56CA25A5.2030100@gmail.com> (raw)
In-Reply-To: <CAHc6FU4CCrcrA6=oCiq2A5rGd9CCGELaTZq6tGpmd2jcV_Zp4A@mail.gmail.com>
On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote:
> Hi Michael,
>
> thanks again for all the feedback. I've followed all your suggestions;
> again, please see the github repo for the latest version:
>
> https://github.com/andreas-gruenbacher/richacl
>
> On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages)
> <mtk.manpages@gmail.com> wrote:
>> Hi Andreas,
>>
>> Here's a few more comments on the current richacl(7) page
>> that I fetched from the git repo.
>>
[...]
>>> .HP
>>> .BR dir_inherit "\ (" d ):
>>> The entry is inheritable for directories.
>>
>> "When this flag appears in the ACL entry of a directory, then that entry is
>> inherited by new subdirectories created in the directory."
>>
>> Is that text that I propose correct?
>
> It's not entirely wrong, but only a small part of the truth. Entries
> are inherited such that the permissions in file_inherit entries become
> effective for access checking for new files, and the permissions in
> dir_inherit entries become effective for access checking for new
> directories, recursively.
>
> Your feedback prompted me to look into the inheritance flag
> computation more closely once again, and I found bugs. The steps of
> the algorithm are explained in the section "Permissions at
> file-creation time", by the way.
Hmmm... writing and refining documentation helps find code bugs.
Who knew? :-)
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-21 21:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 16:28 RichACLs man-pages review Michael Kerrisk (man-pages)
2016-02-07 16:28 ` Michael Kerrisk (man-pages)
[not found] ` <56B770B6.7040803-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-07 16:29 ` Michael Kerrisk (man-pages)
2016-02-07 16:29 ` Michael Kerrisk (man-pages)
2016-02-07 16:29 ` Michael Kerrisk (man-pages)
2016-02-07 16:30 ` getrichacl(1) man page review comments Michael Kerrisk (man-pages)
2016-02-07 16:30 ` Michael Kerrisk (man-pages)
2016-02-07 16:30 ` Michael Kerrisk (man-pages)
2016-02-07 18:16 ` Martin Steigerwald
2016-02-07 18:16 ` Martin Steigerwald
[not found] ` <56B77139.4080209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-14 21:30 ` Michael Kerrisk (man-pages)
2016-02-14 21:30 ` Michael Kerrisk (man-pages)
2016-02-14 21:30 ` Michael Kerrisk (man-pages)
2016-02-07 16:31 ` setrichacl(1) " Michael Kerrisk (man-pages)
2016-02-07 16:31 ` Michael Kerrisk (man-pages)
2016-02-07 16:31 ` Michael Kerrisk (man-pages)
2016-02-14 21:29 ` Michael Kerrisk (man-pages)
2016-02-14 21:29 ` Michael Kerrisk (man-pages)
2016-02-07 16:35 ` richacl(7) " Michael Kerrisk (man-pages)
2016-02-07 16:35 ` Michael Kerrisk (man-pages)
2016-02-07 16:35 ` Michael Kerrisk (man-pages)
[not found] ` <56B77262.7090107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-10 19:34 ` J. Bruce Fields
2016-02-10 19:34 ` J. Bruce Fields
2016-02-10 19:34 ` J. Bruce Fields
2016-02-12 22:25 ` Andreas Gruenbacher
2016-02-12 22:25 ` Andreas Gruenbacher
2016-02-12 22:25 ` Andreas Gruenbacher
[not found] ` <CAHc6FU5__xbKm4mg8+fK_ZW5ZYsDoQcYBBvQg573Eq4ERDsROw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-14 21:27 ` Michael Kerrisk (man-pages)
2016-02-14 21:27 ` Michael Kerrisk (man-pages)
2016-02-14 21:27 ` Michael Kerrisk (man-pages)
2016-02-14 23:12 ` Andreas Gruenbacher
2016-02-14 23:12 ` Andreas Gruenbacher
2016-02-15 10:25 ` Michael Kerrisk (man-pages)
2016-02-15 10:25 ` Michael Kerrisk (man-pages)
[not found] ` <56C1A788.9020008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-15 11:35 ` Andreas Gruenbacher
2016-02-15 11:35 ` Andreas Gruenbacher
2016-02-15 11:35 ` Andreas Gruenbacher
[not found] ` <CAHc6FU69k2uRXjSSS+9K0cXzFs74DPsz6DDv8GN=hmh7RpPA-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-15 14:15 ` Michael Kerrisk (man-pages)
2016-02-15 14:15 ` Michael Kerrisk (man-pages)
2016-02-15 14:15 ` Michael Kerrisk (man-pages)
2016-02-14 21:31 ` Michael Kerrisk (man-pages)
2016-02-14 21:31 ` Michael Kerrisk (man-pages)
2016-02-14 21:31 ` Michael Kerrisk (man-pages)
[not found] ` <56C0F23C.7030902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-20 16:37 ` Andreas Gruenbacher
2016-02-20 16:37 ` Andreas Gruenbacher
2016-02-20 16:37 ` Andreas Gruenbacher
[not found] ` <CAHc6FU4CCrcrA6=oCiq2A5rGd9CCGELaTZq6tGpmd2jcV_Zp4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-21 21:01 ` Michael Kerrisk (man-pages) [this message]
2016-02-21 21:01 ` Michael Kerrisk (man-pages)
2016-02-21 21:01 ` Michael Kerrisk (man-pages)
2016-02-21 21:40 ` Michael Kerrisk (man-pages)
2016-02-21 21:40 ` Michael Kerrisk (man-pages)
2016-02-21 21:40 ` Michael Kerrisk (man-pages)
[not found] ` <56CA2EEB.9080504-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-22 14:46 ` Andreas Gruenbacher
2016-02-22 14:46 ` Andreas Gruenbacher
2016-02-22 14:46 ` Andreas Gruenbacher
2016-02-23 10:16 ` Michael Kerrisk (man-pages)
2016-02-23 10:16 ` Michael Kerrisk (man-pages)
[not found] ` <56CC3174.2060207-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-23 10:28 ` Andreas Gruenbacher
2016-02-23 10:28 ` Andreas Gruenbacher
2016-02-23 10:28 ` Andreas Gruenbacher
2016-02-28 22:11 ` Andreas Gruenbacher
2016-02-28 22:11 ` Andreas Gruenbacher
2016-02-28 22:11 ` Andreas Gruenbacher
2016-02-23 10:58 ` Michael Kerrisk (man-pages)
2016-02-23 10:58 ` Michael Kerrisk (man-pages)
2016-02-23 10:58 ` Michael Kerrisk (man-pages)
2016-02-23 11:14 ` Andreas Gruenbacher
2016-02-23 11:14 ` Andreas Gruenbacher
[not found] ` <56CC3B4A.7070204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-23 15:09 ` Andreas Gruenbacher
2016-02-23 15:09 ` Andreas Gruenbacher
2016-02-23 15:09 ` Andreas Gruenbacher
[not found] ` <CAHc6FU67LnV7-roofFe1y_uTfvgwonRZimyu7Wn1CDRzwHZJSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-23 19:01 ` Andreas Gruenbacher
2016-02-23 19:01 ` Andreas Gruenbacher
2016-02-23 19:01 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CA25A5.2030100@gmail.com \
--to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
--cc=xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.