From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com, will.deacon@arm.com,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, shannon.zhao@linaro.org
Subject: Re: [PATCH v11 19/21] KVM: ARM64: Add a new feature bit for PMUv3
Date: Mon, 22 Feb 2016 15:43:56 +0800 [thread overview]
Message-ID: <56CABC3C.8000304@huawei.com> (raw)
In-Reply-To: <20160208122957.GE620@cbox>
On 2016/2/8 20:29, Christoffer Dall wrote:
>> +bool kvm_arm_support_pmu_v3(void)
>> > +{
>> > + /* Check if HW_PERF_EVENTS are supported by checking the number of
>> > + * hardware performance counters. This could ensure physical PMU and
>> > + * PERF_EVENT driver existing.
>> > + */
> nit: coding style, opening comment block should be on its own line
>
> I don't understand the last sentence. Do you mean: "This ensures the
> presence of a physical PMU and that CONFIG_PERF_EVENT is selected." ?
Right.
--
Shannon
WARNING: multiple messages have this Message-ID (diff)
From: zhaoshenglong@huawei.com (Shannon Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 19/21] KVM: ARM64: Add a new feature bit for PMUv3
Date: Mon, 22 Feb 2016 15:43:56 +0800 [thread overview]
Message-ID: <56CABC3C.8000304@huawei.com> (raw)
In-Reply-To: <20160208122957.GE620@cbox>
On 2016/2/8 20:29, Christoffer Dall wrote:
>> +bool kvm_arm_support_pmu_v3(void)
>> > +{
>> > + /* Check if HW_PERF_EVENTS are supported by checking the number of
>> > + * hardware performance counters. This could ensure physical PMU and
>> > + * PERF_EVENT driver existing.
>> > + */
> nit: coding style, opening comment block should be on its own line
>
> I don't understand the last sentence. Do you mean: "This ensures the
> presence of a physical PMU and that CONFIG_PERF_EVENT is selected." ?
Right.
--
Shannon
next prev parent reply other threads:[~2016-02-22 7:43 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 7:13 [PATCH v11 00/21] KVM: ARM64: Add guest PMU support Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` [PATCH v11 01/21] ARM64: Move PMU register related defines to asm/pmu.h Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` [PATCH v11 02/21] KVM: ARM64: Define PMU data structure for each vcpu Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` [PATCH v11 03/21] KVM: ARM64: Add offset defines for PMU registers Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` [PATCH v11 04/21] KVM: ARM64: Add access handler for PMCR register Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:13 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 05/21] KVM: ARM64: Add access handler for PMSELR register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 06/21] KVM: ARM64: Add access handler for PMCEID0 and PMCEID1 register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-08 12:09 ` Christoffer Dall
2016-02-08 12:09 ` Christoffer Dall
2016-02-20 13:15 ` Shannon Zhao
2016-02-20 13:15 ` Shannon Zhao
2016-02-20 13:30 ` Peter Maydell
2016-02-20 13:30 ` Peter Maydell
2016-02-20 13:34 ` Shannon Zhao
2016-02-20 13:34 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 07/21] KVM: ARM64: PMU: Add perf event map and introduce perf event creating function Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 08/21] KVM: ARM64: Add access handler for event type register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 09/21] KVM: ARM64: Add access handler for event counter register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 10/21] KVM: ARM64: Add access handler for PMCNTENSET and PMCNTENCLR register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 11/21] KVM: ARM64: Add access handler for PMINTENSET and PMINTENCLR register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 12/21] KVM: ARM64: Add access handler for PMOVSSET and PMOVSCLR register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 13/21] KVM: ARM64: Add access handler for PMSWINC register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 14/21] KVM: ARM64: Add helper to handle PMCR register bits Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 15/21] KVM: ARM64: Add access handler for PMUSERENR register Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 16/21] KVM: ARM64: Add PMU overflow interrupt routing Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-08 12:26 ` Christoffer Dall
2016-02-08 12:26 ` Christoffer Dall
2016-02-20 13:32 ` Shannon Zhao
2016-02-20 13:32 ` Shannon Zhao
2016-02-22 7:35 ` Shannon Zhao
2016-02-22 7:35 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 17/21] KVM: ARM64: Reset PMU state when resetting vcpu Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 18/21] KVM: ARM64: Free perf event of PMU when destroying vcpu Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 19/21] KVM: ARM64: Add a new feature bit for PMUv3 Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-08 12:29 ` Christoffer Dall
2016-02-08 12:29 ` Christoffer Dall
2016-02-22 7:43 ` Shannon Zhao [this message]
2016-02-22 7:43 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 20/21] KVM: ARM: Introduce per-vcpu kvm device controls Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-08 12:40 ` Christoffer Dall
2016-02-08 12:40 ` Christoffer Dall
2016-02-20 13:38 ` Shannon Zhao
2016-02-20 13:38 ` Shannon Zhao
2016-02-05 7:14 ` [PATCH v11 21/21] KVM: ARM64: Add a new vcpu device control group for PMUv3 Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-05 7:14 ` Shannon Zhao
2016-02-08 12:52 ` Christoffer Dall
2016-02-08 12:52 ` Christoffer Dall
2016-02-22 7:45 ` Shannon Zhao
2016-02-22 7:45 ` Shannon Zhao
2016-02-22 7:45 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CABC3C.8000304@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=shannon.zhao@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.