All of lore.kernel.org
 help / color / mirror / Atom feed
From: nick <xerofoify@gmail.com>
To: Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	nsekhar@ti.com, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, ezequiel@vanguardiasur.com.ar,
	javier@dowhile0.org, computersforpeace@gmail.com,
	dwmw2@infradead.org, fcooper@ti.com
Subject: Re: [PATCH v5 00/26] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms
Date: Mon, 22 Feb 2016 15:12:52 -0500	[thread overview]
Message-ID: <56CB6BC4.7060806@gmail.com> (raw)
In-Reply-To: <56CB69F4.8040306@ti.com>



On 2016-02-22 03:05 PM, Roger Quadros wrote:
> On 22/02/16 18:42, Tony Lindgren wrote:
>> * Roger Quadros <rogerq@ti.com> [160222 02:16]:
>>> On 20/02/16 00:04, Tony Lindgren wrote:
>>>> * Roger Quadros <rogerq@ti.com> [160219 13:27]:
>>>>> Hi,
>>>>>
>>>>> @Tony
>>>>> Patches 15 and 24 are new and will need your review.
>>>>> I've modified patch 22 to include the new am335x boards introduced since v4.4.
>>>>>
>>>>> Patches are based on top of omap-for-v4.6/dt so that the DT changes apply cleanly.
>>>>
>>>> Looks OK to me. Can we merge the dts changes separately? Otherwise
>>>> we will easily end up with tons of conflicts..
>>>
>>> I agree. But we just need to keep in mind that NAND functionality will be
>>> broken till all the patches in this series are merged. We don't maintain
>>> backward compatibility with the old DT implementation.
>>
>> Please let's not do that! That breaks booting and git bisect.
>> It's better to have a minimal branch where each patch boots fine.
> 
> Understood. I'll send out a patch set with only the minimal DT changes
> that doesn't break anything. This should be a preparatory step for
> the DT clean up.
> 
Would you mind and try testing this on a few boards as even miminal DT
changes can break things and thus I would like to see you test it if
possible on the boards affected by the DT change.
>>
>> Also, I think you should at least print a warning for the old
>> binding. Otherwise people with out of tree boards will have
>> hard time updating their patches to send to mainline tree.
> 
Second that I agree with Tony on this it's just the reality.
Nick
> OK. I'll add this warning mechanism to the omap-gpmc driver.
> 
> cheers,
> -roger
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 

WARNING: multiple messages have this Message-ID (diff)
From: nick <xerofoify@gmail.com>
To: Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, computersforpeace@gmail.com,
	nsekhar@ti.com, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, ezequiel@vanguardiasur.com.ar,
	javier@dowhile0.org, linux-omap@vger.kernel.org,
	dwmw2@infradead.org, fcooper@ti.com
Subject: Re: [PATCH v5 00/26] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms
Date: Mon, 22 Feb 2016 15:12:52 -0500	[thread overview]
Message-ID: <56CB6BC4.7060806@gmail.com> (raw)
In-Reply-To: <56CB69F4.8040306@ti.com>



On 2016-02-22 03:05 PM, Roger Quadros wrote:
> On 22/02/16 18:42, Tony Lindgren wrote:
>> * Roger Quadros <rogerq@ti.com> [160222 02:16]:
>>> On 20/02/16 00:04, Tony Lindgren wrote:
>>>> * Roger Quadros <rogerq@ti.com> [160219 13:27]:
>>>>> Hi,
>>>>>
>>>>> @Tony
>>>>> Patches 15 and 24 are new and will need your review.
>>>>> I've modified patch 22 to include the new am335x boards introduced since v4.4.
>>>>>
>>>>> Patches are based on top of omap-for-v4.6/dt so that the DT changes apply cleanly.
>>>>
>>>> Looks OK to me. Can we merge the dts changes separately? Otherwise
>>>> we will easily end up with tons of conflicts..
>>>
>>> I agree. But we just need to keep in mind that NAND functionality will be
>>> broken till all the patches in this series are merged. We don't maintain
>>> backward compatibility with the old DT implementation.
>>
>> Please let's not do that! That breaks booting and git bisect.
>> It's better to have a minimal branch where each patch boots fine.
> 
> Understood. I'll send out a patch set with only the minimal DT changes
> that doesn't break anything. This should be a preparatory step for
> the DT clean up.
> 
Would you mind and try testing this on a few boards as even miminal DT
changes can break things and thus I would like to see you test it if
possible on the boards affected by the DT change.
>>
>> Also, I think you should at least print a warning for the old
>> binding. Otherwise people with out of tree boards will have
>> hard time updating their patches to send to mainline tree.
> 
Second that I agree with Tony on this it's just the reality.
Nick
> OK. I'll add this warning mechanism to the omap-gpmc driver.
> 
> cheers,
> -roger
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2016-02-22 20:13 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 21:15 [PATCH v5 00/26] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms Roger Quadros
2016-02-19 21:15 ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 01/26] ARM: OMAP2+: gpmc: Add platform data Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 02/26] ARM: OMAP2+: gpmc: Add gpmc timings and settings to " Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 03/26] memory: omap-gpmc: Introduce GPMC to NAND interface Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-03-05  1:35   ` Brian Norris
2016-03-07  8:55     ` Roger Quadros
2016-03-07  8:55       ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 04/26] mtd: nand: omap2: Use gpmc_omap_get_nand_ops() to get NAND registers Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 05/26] memory: omap-gpmc: Add GPMC-NAND ops to get writebufferempty status Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 06/26] mtd: nand: omap2: Switch to using GPMC-NAND ops for writebuffer empty check Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 07/26] memory: omap-gpmc: Implement IRQ domain for NAND IRQs Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 08/26] mtd: nand: omap: Copy platform data parameters to omap_nand_info data Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-03-05  2:10   ` Brian Norris
2016-03-07  9:06     ` Roger Quadros
2016-03-07  9:06       ` Roger Quadros
2016-03-05  2:28   ` Brian Norris
2016-03-05  2:28     ` Brian Norris
2016-03-07  9:02     ` Roger Quadros
2016-03-07  9:02       ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 10/26] mtd: nand: omap: Update DT binding documentation Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-23 19:41   ` Rob Herring
2016-02-24  9:55     ` Roger Quadros
2016-02-24  9:55       ` Roger Quadros
2016-03-05  2:04   ` Brian Norris
2016-03-05  2:04     ` Brian Norris
2016-03-07  9:46     ` Roger Quadros
2016-03-07  9:46       ` Roger Quadros
2016-03-07 18:58       ` Brian Norris
2016-03-07 18:58         ` Brian Norris
2016-03-07 10:32   ` [PATCH v6 " Roger Quadros
2016-03-07 10:32     ` Roger Quadros
2016-03-17 14:48     ` Rob Herring
2016-03-17 14:48       ` Rob Herring
2016-02-19 21:15 ` [PATCH v5 11/26] memory: omap-gpmc: Prevent mapping into 1st 16MB Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 12/26] memory: omap-gpmc: Move device tree binding to correct location Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-23 20:50   ` Rob Herring
2016-02-24  9:51     ` Roger Quadros
2016-02-24  9:51       ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 13/26] memory: omap-gpmc: Support general purpose input for WAITPINs Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-03-07  9:34   ` Boris Brezillon
2016-03-07  9:34     ` Boris Brezillon
2016-03-07  9:38     ` Boris Brezillon
2016-03-07  9:38       ` Boris Brezillon
2016-03-07 10:02     ` Roger Quadros
2016-03-07 10:02       ` Roger Quadros
2016-03-07 10:31       ` Boris Brezillon
2016-03-07 10:31         ` Boris Brezillon
2016-02-19 21:15 ` [PATCH v5 14/26] memory: omap-gpmc: Reserve WAITPIN if needed for WAIT monitoring Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 15/26] memory: omap-gpmc: Support WAIT pin edge interrupts Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 16/26] memory: omap-gpmc: Prevent GPMC_STATUS from being accessed via gpmc_regs Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 17/26] mtd: nand: omap2: Implement NAND ready using gpiolib Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-03-05  1:46   ` Brian Norris
2016-03-05  1:46     ` Brian Norris
2016-03-07  9:11     ` Roger Quadros
2016-03-07  9:11       ` Roger Quadros
2016-03-07  9:22   ` Boris Brezillon
2016-03-07  9:22     ` Boris Brezillon
2016-02-19 21:15 ` [PATCH v5 18/26] ARM: dts: dra7: Fix NAND device nodes Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 19/26] ARM: dts: dra7x-evm: Provide NAND ready pin Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 20/26] ARM: dts: am437x: Fix NAND device nodes Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 21/26] ARM: dts: am437x: Provide NAND ready pin Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 22/26] ARM: dts: am335x: Fix NAND device nodes Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 23/26] ARM: dts: am335x: Provide NAND ready pin Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 24/26] ARM: dts: dm814x: Fix gpmc and NAND node Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 25/26] ARM: dts: dm816x: " Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 21:15 ` [PATCH v5 26/26] ARM: dts: omap3: Fix gpmc and NAND nodes Roger Quadros
2016-02-19 21:15   ` Roger Quadros
2016-02-19 22:04 ` [PATCH v5 00/26] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms Tony Lindgren
2016-02-22 10:15   ` Roger Quadros
2016-02-22 10:15     ` Roger Quadros
2016-02-22 16:42     ` Tony Lindgren
2016-02-22 20:05       ` Roger Quadros
2016-02-22 20:05         ` Roger Quadros
2016-02-22 20:12         ` nick [this message]
2016-02-22 20:12           ` nick
2016-02-29 16:25 ` Roger Quadros
2016-02-29 16:25   ` Roger Quadros
2016-03-05  2:33   ` Brian Norris
2016-03-05  2:33     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CB6BC4.7060806@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=fcooper@ti.com \
    --cc=javier@dowhile0.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.