All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
	yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org,
	erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	david.ahern-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler
Date: Tue, 23 Feb 2016 10:54:23 +0200	[thread overview]
Message-ID: <56CC1E3F.9070500@mellanox.com> (raw)
In-Reply-To: <1456167558-10123-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 2/22/2016 8:59 PM, Nicholas Krause wrote:
> This fixes error handling in the function cm_lap_handler to properly
> check if the internal call to the function cm_init_av_for_response
> has failed by returning a error code and if so exit immediately from
> this particular function by freeing all previously allocated
> resources before returning the error code to this function's caller
> in order to allow the caller to handle the error properly in it's
>
> Signed-off-by: Nicholas Krause<xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

I think this is the longest sentence I have ever read in English, and it 
even doesn't have a end... please break it and tell us the (hopefully) 
happy end.

Use IB/core: prefix and point to the commit you are fixing

Fixes: xxx ('yyy')

where xxx is the 12 digit abbrev-iated git short log  and yyy the commit 
title

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: <dledford@redhat.com>, <sean.hefty@intel.com>,
	<hal.rosenstock@gmail.com>, <matanb@mellanox.com>,
	<haggaie@mellanox.com>, <ira.weiny@intel.com>,
	<jgunthorpe@obsidianresearch.com>, <yun.wang@profitbricks.com>,
	<erezsh@mellanox.com>, <david.ahern@oracle.com>,
	<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler
Date: Tue, 23 Feb 2016 10:54:23 +0200	[thread overview]
Message-ID: <56CC1E3F.9070500@mellanox.com> (raw)
In-Reply-To: <1456167558-10123-1-git-send-email-xerofoify@gmail.com>

On 2/22/2016 8:59 PM, Nicholas Krause wrote:
> This fixes error handling in the function cm_lap_handler to properly
> check if the internal call to the function cm_init_av_for_response
> has failed by returning a error code and if so exit immediately from
> this particular function by freeing all previously allocated
> resources before returning the error code to this function's caller
> in order to allow the caller to handle the error properly in it's
>
> Signed-off-by: Nicholas Krause<xerofoify@gmail.com>

I think this is the longest sentence I have ever read in English, and it 
even doesn't have a end... please break it and tell us the (hopefully) 
happy end.

Use IB/core: prefix and point to the commit you are fixing

Fixes: xxx ('yyy')

where xxx is the 12 digit abbrev-iated git short log  and yyy the commit 
title

       reply	other threads:[~2016-02-23  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1456167558-10123-1-git-send-email-xerofoify@gmail.com>
     [not found] ` <1456167558-10123-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-23  8:54   ` Or Gerlitz [this message]
2016-02-23  8:54     ` [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CC1E3F.9070500@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=david.ahern-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.