All of lore.kernel.org
 help / color / mirror / Atom feed
* 'mon_addr' vs 'public_addr'
@ 2016-02-23 18:07 Joao Eduardo Luis
  2016-02-23 18:16 ` Sage Weil
  0 siblings, 1 reply; 2+ messages in thread
From: Joao Eduardo Luis @ 2016-02-23 18:07 UTC (permalink / raw)
  To: ceph-devel@vger.kernel.org, Sage Weil, 'Gregory Farnum'

Hi all,

does anyone remember the rationale behind not simply relying on
'public_addr' instead of 'mon_addr' for the monitors?

I keep coming back to this, and I keep thinking this must be an artefact
of some long-gone era, during which public_addr maybe didn't exist? I
tried to backtrace its inception and ended up all the way in af870763
back from 2009, but the commit itself didn't help much.

Any thoughts?

  -Joao

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 'mon_addr' vs 'public_addr'
  2016-02-23 18:07 'mon_addr' vs 'public_addr' Joao Eduardo Luis
@ 2016-02-23 18:16 ` Sage Weil
  0 siblings, 0 replies; 2+ messages in thread
From: Sage Weil @ 2016-02-23 18:16 UTC (permalink / raw)
  To: Joao Eduardo Luis; +Cc: ceph-devel@vger.kernel.org, 'Gregory Farnum'

On Tue, 23 Feb 2016, Joao Eduardo Luis wrote:
> Hi all,
> 
> does anyone remember the rationale behind not simply relying on
> 'public_addr' instead of 'mon_addr' for the monitors?
> 
> I keep coming back to this, and I keep thinking this must be an artefact
> of some long-gone era, during which public_addr maybe didn't exist? I

Yes.

> tried to backtrace its inception and ended up all the way in af870763
> back from 2009, but the commit itself didn't help much.
> 
> Any thoughts?

It's slightly tricky because we need to make mon addr still work.. but we 
can move all the docs refer to public_addr instead and make mon_addr 
override that if it is non-empty.

sage

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-23 18:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 18:07 'mon_addr' vs 'public_addr' Joao Eduardo Luis
2016-02-23 18:16 ` Sage Weil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.