All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
@ 2016-01-30 17:05 Khem Raj
  2016-02-23 21:02 ` Anders Darander
  0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2016-01-30 17:05 UTC (permalink / raw)
  To: yocto

libexecdir has changed its location in latest OE core, it used to be
pointing to /usr/lib which was essentially same as libdir and when
hardcoded in do_rpiboot_mkimage it worked.

Fixes kernel build failures e.g.

DEBUG: Executing shell function do_rpiboot_mkimage
/a/builder/mnt/build-oe/tmp-musl/work/raspberrypi2-oe-linux-musleabi/linux-raspberrypi/1_4.1.10+gitAUTOINC+b74df9228c-r0/temp/run.do_rpiboot_mkimage.5543:
line 111:
/a/builder/mnt/build-oe/tmp-musl/sysroots/x86_64-linux/usr/lib/rpi-mkimage/mkknlimg: No such file or directory

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index 70e8bfe..0798788 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
     if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
         if test -n "${KERNEL_DEVICETREE}"; then
             # Add RPi bootloader trailer to kernel image to enable DeviceTree support
-            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
+            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
         fi
     fi
 }
-- 
2.7.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-01-30 17:05 [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes Khem Raj
@ 2016-02-23 21:02 ` Anders Darander
  2016-02-23 21:37   ` Andreas Müller
  0 siblings, 1 reply; 10+ messages in thread
From: Anders Darander @ 2016-02-23 21:02 UTC (permalink / raw)
  To: yocto

Ping?

We can't build on master branch without this fix...

Cheers,
Anders

* Khem Raj <raj.khem@gmail.com> [160130 18:07]:

> libexecdir has changed its location in latest OE core, it used to be
> pointing to /usr/lib which was essentially same as libdir and when
> hardcoded in do_rpiboot_mkimage it worked.

> Fixes kernel build failures e.g.

> DEBUG: Executing shell function do_rpiboot_mkimage
> /a/builder/mnt/build-oe/tmp-musl/work/raspberrypi2-oe-linux-musleabi/linux-raspberrypi/1_4.1.10+gitAUTOINC+b74df9228c-r0/temp/run.do_rpiboot_mkimage.5543:
> line 111:
> /a/builder/mnt/build-oe/tmp-musl/sysroots/x86_64-linux/usr/lib/rpi-mkimage/mkknlimg: No such file or directory

> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index 70e8bfe..0798788 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
>      if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
>          if test -n "${KERNEL_DEVICETREE}"; then
>              # Add RPi bootloader trailer to kernel image to enable DeviceTree support
> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>          fi
>      fi
>  }
-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-23 21:02 ` Anders Darander
@ 2016-02-23 21:37   ` Andreas Müller
  2016-02-24  4:21     ` Khem Raj
  2016-02-24 20:28     ` Anders Darander
  0 siblings, 2 replies; 10+ messages in thread
From: Andreas Müller @ 2016-02-23 21:37 UTC (permalink / raw)
  To: Yocto Project

On Tue, Feb 23, 2016 at 10:02 PM, Anders Darander <anders@chargestorm.se> wrote:
> Ping?
>
> We can't build on master branch without this fix...
>
> Cheers,
> Anders
>
> * Khem Raj <raj.khem@gmail.com> [160130 18:07]:
>
>> libexecdir has changed its location in latest OE core, it used to be
>> pointing to /usr/lib which was essentially same as libdir and when
>> hardcoded in do_rpiboot_mkimage it worked.
>
>> Fixes kernel build failures e.g.
>
>> DEBUG: Executing shell function do_rpiboot_mkimage
>> /a/builder/mnt/build-oe/tmp-musl/work/raspberrypi2-oe-linux-musleabi/linux-raspberrypi/1_4.1.10+gitAUTOINC+b74df9228c-r0/temp/run.do_rpiboot_mkimage.5543:
>> line 111:
>> /a/builder/mnt/build-oe/tmp-musl/sysroots/x86_64-linux/usr/lib/rpi-mkimage/mkknlimg: No such file or directory
>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>> index 70e8bfe..0798788 100644
>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
>>      if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
>>          if test -n "${KERNEL_DEVICETREE}"; then
>>              # Add RPi bootloader trailer to kernel image to enable DeviceTree support
>> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>>          fi
>>      fi
>>  }
> --
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB
> --
This patch is mandatory but there was a serial with additional fixes
send by Maciej Borzecki on Feb 2nd. I think this is worth taken into
account.

Andreas


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-23 21:37   ` Andreas Müller
@ 2016-02-24  4:21     ` Khem Raj
  2016-02-25 16:32       ` Trevor Woerner
  2016-02-24 20:28     ` Anders Darander
  1 sibling, 1 reply; 10+ messages in thread
From: Khem Raj @ 2016-02-24  4:21 UTC (permalink / raw)
  To: Andreas Müller; +Cc: Yocto Project

[-- Attachment #1: Type: text/plain, Size: 2403 bytes --]


> On Feb 23, 2016, at 4:37 PM, Andreas Müller <schnitzeltony@googlemail.com> wrote:
> 
> On Tue, Feb 23, 2016 at 10:02 PM, Anders Darander <anders@chargestorm.se> wrote:
>> Ping?
>> 
>> We can't build on master branch without this fix...
>> 
>> Cheers,
>> Anders
>> 
>> * Khem Raj <raj.khem@gmail.com> [160130 18:07]:
>> 
>>> libexecdir has changed its location in latest OE core, it used to be
>>> pointing to /usr/lib which was essentially same as libdir and when
>>> hardcoded in do_rpiboot_mkimage it worked.
>> 
>>> Fixes kernel build failures e.g.
>> 
>>> DEBUG: Executing shell function do_rpiboot_mkimage
>>> /a/builder/mnt/build-oe/tmp-musl/work/raspberrypi2-oe-linux-musleabi/linux-raspberrypi/1_4.1.10+gitAUTOINC+b74df9228c-r0/temp/run.do_rpiboot_mkimage.5543:
>>> line 111:
>>> /a/builder/mnt/build-oe/tmp-musl/sysroots/x86_64-linux/usr/lib/rpi-mkimage/mkknlimg: No such file or directory
>> 
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>>> index 70e8bfe..0798788 100644
>>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>>> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
>>>     if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
>>>         if test -n "${KERNEL_DEVICETREE}"; then
>>>             # Add RPi bootloader trailer to kernel image to enable DeviceTree support
>>> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>>> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>>>         fi
>>>     fi
>>> }
>> --
>> Anders Darander, Senior System Architect
>> ChargeStorm AB / eStorm AB
>> --
> This patch is mandatory but there was a serial with additional fixes
> send by Maciej Borzecki on Feb 2nd. I think this is worth taken into
> account.

You can try to use github.com/kraj/meta-raspberrypi kraj/master
I plan to test out more and more pending submissions on that branch

> 
> Andreas
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-23 21:37   ` Andreas Müller
  2016-02-24  4:21     ` Khem Raj
@ 2016-02-24 20:28     ` Anders Darander
  2016-02-24 21:44       ` Khem Raj
  2016-02-25 13:44       ` Trevor Woerner
  1 sibling, 2 replies; 10+ messages in thread
From: Anders Darander @ 2016-02-24 20:28 UTC (permalink / raw)
  To: yocto

* Andreas Müller <schnitzeltony@googlemail.com> [160223 22:38]:
> > * Khem Raj <raj.khem@gmail.com> [160130 18:07]:
> >
> >> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> >> index 70e8bfe..0798788 100644
> >> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> >> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> >> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
> >>      if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
> >>          if test -n "${KERNEL_DEVICETREE}"; then
> >>              # Add RPi bootloader trailer to kernel image to enable DeviceTree support
> >> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
> >> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
> >>          fi
> >>      fi
> >>  }
> This patch is mandatory but there was a serial with additional fixes
> send by Maciej Borzecki on Feb 2nd. I think this is worth taken into
> account.
> 

Yes, that's right.

If the rest of the patches in that series is non-controversial, could we
have them applied? Otherwise, could we have Khem's patch applied, and
the other series rebased upon that?

We've had the master branch non-building for quite a while now...

I'm just keen to get either of those patches applied to
meta-raspberrypi. I'd like to avoid having to use a local fork as much
as possible... 

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-24 20:28     ` Anders Darander
@ 2016-02-24 21:44       ` Khem Raj
  2016-02-26 11:35         ` Jonathan Liu
  2016-02-25 13:44       ` Trevor Woerner
  1 sibling, 1 reply; 10+ messages in thread
From: Khem Raj @ 2016-02-24 21:44 UTC (permalink / raw)
  To: yocto

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

On Feb 24, 2016 1:30 PM, "Anders Darander" <anders@chargestorm.se> wrote:
>
> * Andreas Müller <schnitzeltony@googlemail.com> [160223 22:38]:
> > > * Khem Raj <raj.khem@gmail.com> [160130 18:07]:
> > >
> > >> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc
> > >> index 70e8bfe..0798788 100644
> > >> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> > >> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> > >> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
> > >>      if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
> > >>          if test -n "${KERNEL_DEVICETREE}"; then
> > >>              # Add RPi bootloader trailer to kernel image to enable
DeviceTree support
> > >> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg
--dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
> > >> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok
${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
> > >>          fi
> > >>      fi
> > >>  }
> > This patch is mandatory but there was a serial with additional fixes
> > send by Maciej Borzecki on Feb 2nd. I think this is worth taken into
> > account.
> >
>
> Yes, that's right.
>
> If the rest of the patches in that series is non-controversial, could we
> have them applied? Otherwise, could we have Khem's patch applied, and
> the other series rebased upon that?
>

This will also make layer incompatible with jethro and older releases. So
before applying this patch jethro has to branch out

> We've had the master branch non-building for quite a while now...
>
> I'm just keen to get either of those patches applied to
> meta-raspberrypi. I'd like to avoid having to use a local fork as much
> as possible...
>
> Cheers,
> Anders
>
> --
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

[-- Attachment #2: Type: text/html, Size: 2863 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-24 20:28     ` Anders Darander
  2016-02-24 21:44       ` Khem Raj
@ 2016-02-25 13:44       ` Trevor Woerner
  1 sibling, 0 replies; 10+ messages in thread
From: Trevor Woerner @ 2016-02-25 13:44 UTC (permalink / raw)
  To: yocto



On 02/24/16 15:28, Anders Darander wrote:
> If the rest of the patches in that series is non-controversial, could we
> have them applied? Otherwise, could we have Khem's patch applied, and
> the other series rebased upon that?
>
> We've had the master branch non-building for quite a while now...
>
> I'm just keen to get either of those patches applied to
> meta-raspberrypi. I'd like to avoid having to use a local fork as much
> as possible...

+1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-24  4:21     ` Khem Raj
@ 2016-02-25 16:32       ` Trevor Woerner
  0 siblings, 0 replies; 10+ messages in thread
From: Trevor Woerner @ 2016-02-25 16:32 UTC (permalink / raw)
  To: Khem Raj, Andreas Müller; +Cc: Yocto Project

On 02/23/16 23:21, Khem Raj wrote:
> You can try to use github.com/kraj/meta-raspberrypi kraj/master
> I plan to test out more and more pending submissions on that branch

Thanks, and done.

It's too bad meta-raspberrypi didn't have a master-next branch :-)


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-24 21:44       ` Khem Raj
@ 2016-02-26 11:35         ` Jonathan Liu
  2016-02-26 15:40           ` Khem Raj
  0 siblings, 1 reply; 10+ messages in thread
From: Jonathan Liu @ 2016-02-26 11:35 UTC (permalink / raw)
  To: Khem Raj; +Cc: Yocto Project

Hi Khem,

I just posted another patch which does basically the same thing but
uses ${STAGING_LIBEXECDIR_NATIVE}.
I checked the expansion of ${STAGING_LIBEXECDIR_NATIVE} on daisy
branch and master.

daisy:
[...]/sysroots/x86_64-linux/usr/lib/rpi-mkimage/mkknlimg
which matches the previous hardcoded path before the patch

master:
[...]/sysroots/x86_64-linux/usr/libexec/mkknlimg

So it looks like my patch should work on older branches too...

Regards,
Jonathan

On 25 February 2016 at 08:44, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Feb 24, 2016 1:30 PM, "Anders Darander" <anders@chargestorm.se> wrote:
>>
>> * Andreas Müller <schnitzeltony@googlemail.com> [160223 22:38]:
>> > > * Khem Raj <raj.khem@gmail.com> [160130 18:07]:
>> > >
>> > >> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc
>> > >> b/recipes-kernel/linux/linux-raspberrypi.inc
>> > >> index 70e8bfe..0798788 100644
>> > >> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>> > >> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>> > >> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
>> > >>      if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
>> > >>          if test -n "${KERNEL_DEVICETREE}"; then
>> > >>              # Add RPi bootloader trailer to kernel image to enable
>> > >> DeviceTree support
>> > >> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg
>> > >> --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>> > >> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok
>> > >> ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>> > >>          fi
>> > >>      fi
>> > >>  }
>> > This patch is mandatory but there was a serial with additional fixes
>> > send by Maciej Borzecki on Feb 2nd. I think this is worth taken into
>> > account.
>> >
>>
>> Yes, that's right.
>>
>> If the rest of the patches in that series is non-controversial, could we
>> have them applied? Otherwise, could we have Khem's patch applied, and
>> the other series rebased upon that?
>>
>
> This will also make layer incompatible with jethro and older releases. So
> before applying this patch jethro has to branch out
>
>> We've had the master branch non-building for quite a while now...
>>
>> I'm just keen to get either of those patches applied to
>> meta-raspberrypi. I'd like to avoid having to use a local fork as much
>> as possible...
>>
>> Cheers,
>> Anders
>>
>> --
>> Anders Darander, Senior System Architect
>> ChargeStorm AB / eStorm AB
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes
  2016-02-26 11:35         ` Jonathan Liu
@ 2016-02-26 15:40           ` Khem Raj
  0 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2016-02-26 15:40 UTC (permalink / raw)
  To: Jonathan Liu; +Cc: Yocto Project

On Fri, Feb 26, 2016 at 3:35 AM, Jonathan Liu <net147@gmail.com> wrote:
> Hi Khem,
>
> I just posted another patch which does basically the same thing but
> uses ${STAGING_LIBEXECDIR_NATIVE}.
> I checked the expansion of ${STAGING_LIBEXECDIR_NATIVE} on daisy
> branch and master.
>
> daisy:
> [...]/sysroots/x86_64-linux/usr/lib/rpi-mkimage/mkknlimg
> which matches the previous hardcoded path before the patch
>
> master:
> [...]/sysroots/x86_64-linux/usr/libexec/mkknlimg
>
> So it looks like my patch should work on older branches too...
>

yes this approach is better. Therefore I have picked it into
kraj/master, I will test it out and push is
shortly.

> Regards,
> Jonathan
>
> On 25 February 2016 at 08:44, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Feb 24, 2016 1:30 PM, "Anders Darander" <anders@chargestorm.se> wrote:
>>>
>>> * Andreas Müller <schnitzeltony@googlemail.com> [160223 22:38]:
>>> > > * Khem Raj <raj.khem@gmail.com> [160130 18:07]:
>>> > >
>>> > >> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc
>>> > >> b/recipes-kernel/linux/linux-raspberrypi.inc
>>> > >> index 70e8bfe..0798788 100644
>>> > >> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>> > >> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>>> > >> @@ -60,7 +60,7 @@ do_rpiboot_mkimage() {
>>> > >>      if test "x${KERNEL_IMAGETYPE}" != "xuImage" ; then
>>> > >>          if test -n "${KERNEL_DEVICETREE}"; then
>>> > >>              # Add RPi bootloader trailer to kernel image to enable
>>> > >> DeviceTree support
>>> > >> -            ${STAGING_DIR_NATIVE}/usr/lib/rpi-mkimage/mkknlimg
>>> > >> --dtok ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>>> > >> +            ${STAGING_DIR_NATIVE}${libexecdir}/mkknlimg --dtok
>>> > >> ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}
>>> > >>          fi
>>> > >>      fi
>>> > >>  }
>>> > This patch is mandatory but there was a serial with additional fixes
>>> > send by Maciej Borzecki on Feb 2nd. I think this is worth taken into
>>> > account.
>>> >
>>>
>>> Yes, that's right.
>>>
>>> If the rest of the patches in that series is non-controversial, could we
>>> have them applied? Otherwise, could we have Khem's patch applied, and
>>> the other series rebased upon that?
>>>
>>
>> This will also make layer incompatible with jethro and older releases. So
>> before applying this patch jethro has to branch out
>>
>>> We've had the master branch non-building for quite a while now...
>>>
>>> I'm just keen to get either of those patches applied to
>>> meta-raspberrypi. I'd like to avoid having to use a local fork as much
>>> as possible...
>>>
>>> Cheers,
>>> Anders
>>>
>>> --
>>> Anders Darander, Senior System Architect
>>> ChargeStorm AB / eStorm AB
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
>>
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>>


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-02-26 15:40 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-30 17:05 [meta-raspberrypi][PATCH] linux-raspberrypi: Adjust for libexecdir changes Khem Raj
2016-02-23 21:02 ` Anders Darander
2016-02-23 21:37   ` Andreas Müller
2016-02-24  4:21     ` Khem Raj
2016-02-25 16:32       ` Trevor Woerner
2016-02-24 20:28     ` Anders Darander
2016-02-24 21:44       ` Khem Raj
2016-02-26 11:35         ` Jonathan Liu
2016-02-26 15:40           ` Khem Raj
2016-02-25 13:44       ` Trevor Woerner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.