From: Tirumalesh Chalamarla <tchalamarla@caviumnetworks.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: tj@kernel.org, stripathi@apm.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536
Date: Thu, 25 Feb 2016 12:31:53 -0800 [thread overview]
Message-ID: <56CF64B9.4080605@caviumnetworks.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1602171710350.19512@nanos>
On 02/17/2016 08:12 AM, Thomas Gleixner wrote:
> On Tue, 16 Feb 2016, tchalamarla@caviumnetworks.com wrote:
>> +#ifdef CONFIG_ARM64
>> +/* Due to ERRATA#22536, ThunderX need to handle
>> + * HOST_IRQ_STAT differently.
>> + * Work around is to make sure all pending IRQs
>> + * are served before leaving handler
>> + */
>> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance)
>> +{
>> + struct ata_host *host = dev_instance;
>> + struct ahci_host_priv *hpriv;
>> + unsigned int rc = 0;
>> + void __iomem *mmio;
>> + u32 irq_stat, irq_masked;
>> + unsigned int handled = 1;
>> +
>> + VPRINTK("ENTER\n");
>
> Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they
> already track the enter/exit of interrupt handlers ....
>
sure. waiting for some more comments if any.
> Thanks,
>
> tglx
>
>
WARNING: multiple messages have this Message-ID (diff)
From: tchalamarla@caviumnetworks.com (Tirumalesh Chalamarla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536
Date: Thu, 25 Feb 2016 12:31:53 -0800 [thread overview]
Message-ID: <56CF64B9.4080605@caviumnetworks.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1602171710350.19512@nanos>
On 02/17/2016 08:12 AM, Thomas Gleixner wrote:
> On Tue, 16 Feb 2016, tchalamarla at caviumnetworks.com wrote:
>> +#ifdef CONFIG_ARM64
>> +/* Due to ERRATA#22536, ThunderX need to handle
>> + * HOST_IRQ_STAT differently.
>> + * Work around is to make sure all pending IRQs
>> + * are served before leaving handler
>> + */
>> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance)
>> +{
>> + struct ata_host *host = dev_instance;
>> + struct ahci_host_priv *hpriv;
>> + unsigned int rc = 0;
>> + void __iomem *mmio;
>> + u32 irq_stat, irq_masked;
>> + unsigned int handled = 1;
>> +
>> + VPRINTK("ENTER\n");
>
> Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they
> already track the enter/exit of interrupt handlers ....
>
sure. waiting for some more comments if any.
> Thanks,
>
> tglx
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Tirumalesh Chalamarla <tchalamarla@caviumnetworks.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <tj@kernel.org>, <stripathi@apm.com>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536
Date: Thu, 25 Feb 2016 12:31:53 -0800 [thread overview]
Message-ID: <56CF64B9.4080605@caviumnetworks.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1602171710350.19512@nanos>
On 02/17/2016 08:12 AM, Thomas Gleixner wrote:
> On Tue, 16 Feb 2016, tchalamarla@caviumnetworks.com wrote:
>> +#ifdef CONFIG_ARM64
>> +/* Due to ERRATA#22536, ThunderX need to handle
>> + * HOST_IRQ_STAT differently.
>> + * Work around is to make sure all pending IRQs
>> + * are served before leaving handler
>> + */
>> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance)
>> +{
>> + struct ata_host *host = dev_instance;
>> + struct ahci_host_priv *hpriv;
>> + unsigned int rc = 0;
>> + void __iomem *mmio;
>> + u32 irq_stat, irq_masked;
>> + unsigned int handled = 1;
>> +
>> + VPRINTK("ENTER\n");
>
> Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they
> already track the enter/exit of interrupt handlers ....
>
sure. waiting for some more comments if any.
> Thanks,
>
> tglx
>
>
next prev parent reply other threads:[~2016-02-25 20:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 20:08 [PATCH V3] AHCI: Workaround for ThunderX Errata#22536 tchalamarla
2016-02-16 20:08 ` tchalamarla
2016-02-16 20:08 ` tchalamarla at caviumnetworks.com
2016-02-17 16:12 ` Thomas Gleixner
2016-02-17 16:12 ` Thomas Gleixner
2016-02-25 20:31 ` Tirumalesh Chalamarla [this message]
2016-02-25 20:31 ` Tirumalesh Chalamarla
2016-02-25 20:31 ` Tirumalesh Chalamarla
2016-02-29 21:12 ` Tejun Heo
2016-02-29 21:12 ` Tejun Heo
2016-02-24 0:00 ` Tirumalesh Chalamarla
2016-02-24 0:00 ` Tirumalesh Chalamarla
2016-02-24 0:00 ` Tirumalesh Chalamarla
2016-02-29 21:17 ` Tejun Heo
2016-02-29 21:17 ` Tejun Heo
2016-02-29 22:00 ` Tirumalesh Chalamarla
2016-02-29 22:00 ` Tirumalesh Chalamarla
2016-02-29 22:00 ` Tirumalesh Chalamarla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF64B9.4080605@caviumnetworks.com \
--to=tchalamarla@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stripathi@apm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.