From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com
Cc: dgibson@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls
Date: Tue, 01 Mar 2016 12:06:11 +0000 [thread overview]
Message-ID: <56D585B3.3000001@redhat.com> (raw)
In-Reply-To: <56D5823A.1050607@redhat.com>
On 01.03.2016 12:51, Laurent Vivier wrote:
>
>
> On 01/03/2016 11:08, Thomas Huth wrote:
>> Introduce a test for sPAPR hypercalls, starting with the
>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> A xouple of stupid questions:
>
> Is that normal they are all failing?
>
> FAIL: hypercall: h_set_sprg0: sprg0 = 0xcafebabedeadbeef
> FAIL: hypercall: h_set_sprg0: sprg0 = 0xaaaaaaaa55555555
> FAIL: hypercall: h_set_sprg0: sprg0 = 0x0
> FAIL: hypercall: h_page_init: h_zero_page
> FAIL: hypercall: h_page_init: h_copy_page
> FAIL: hypercall: h_page_init: h_copy_page+h_zero_page
> FAIL: hypercall: h_page_init: h_zero_page unaligned dst
> FAIL: hypercall: h_page_init: h_copy_page unaligned src
>
> SUMMARY: 8 tests, 8 unexpected failures
Did you use the very latest git version of QEMU? ... these two
hypercalls have just been added recently, so the tests fail if your QEMU
does not support them yet.
> Is it possible to have a message for the H_RANDOM test, something like
> "not supported"?
I initially had something like that in my code, but the output like
PASS: hypercall: h_random: not supported
then also looks somewhat strange ...
Is there already a common sense how to (not) report missing and thus
untestable features in kvm-unit-tests? Something like
SKIP: hypercall: h_random: not supported
would be posh, I think...
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com
Cc: dgibson@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls
Date: Tue, 1 Mar 2016 13:06:11 +0100 [thread overview]
Message-ID: <56D585B3.3000001@redhat.com> (raw)
In-Reply-To: <56D5823A.1050607@redhat.com>
On 01.03.2016 12:51, Laurent Vivier wrote:
>
>
> On 01/03/2016 11:08, Thomas Huth wrote:
>> Introduce a test for sPAPR hypercalls, starting with the
>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> A xouple of stupid questions:
>
> Is that normal they are all failing?
>
> FAIL: hypercall: h_set_sprg0: sprg0 = 0xcafebabedeadbeef
> FAIL: hypercall: h_set_sprg0: sprg0 = 0xaaaaaaaa55555555
> FAIL: hypercall: h_set_sprg0: sprg0 = 0x0
> FAIL: hypercall: h_page_init: h_zero_page
> FAIL: hypercall: h_page_init: h_copy_page
> FAIL: hypercall: h_page_init: h_copy_page+h_zero_page
> FAIL: hypercall: h_page_init: h_zero_page unaligned dst
> FAIL: hypercall: h_page_init: h_copy_page unaligned src
>
> SUMMARY: 8 tests, 8 unexpected failures
Did you use the very latest git version of QEMU? ... these two
hypercalls have just been added recently, so the tests fail if your QEMU
does not support them yet.
> Is it possible to have a message for the H_RANDOM test, something like
> "not supported"?
I initially had something like that in my code, but the output like
PASS: hypercall: h_random: not supported
then also looks somewhat strange ...
Is there already a common sense how to (not) report missing and thus
untestable features in kvm-unit-tests? Something like
SKIP: hypercall: h_random: not supported
would be posh, I think...
Thomas
next prev parent reply other threads:[~2016-03-01 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 10:08 [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls Thomas Huth
2016-03-01 10:08 ` Thomas Huth
2016-03-01 11:51 ` Laurent Vivier
2016-03-01 11:51 ` Laurent Vivier
2016-03-01 12:06 ` Thomas Huth [this message]
2016-03-01 12:06 ` Thomas Huth
2016-03-01 12:27 ` Andrew Jones
2016-03-01 12:27 ` Andrew Jones
2016-03-01 13:13 ` Thomas Huth
2016-03-01 13:13 ` Thomas Huth
2016-03-01 13:23 ` Laurent Vivier
2016-03-01 13:23 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D585B3.3000001@redhat.com \
--to=thuth@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.