Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls

[Laurent Vivier <lvivier@redhat.com>]

On 01/03/2016 13:06, Thomas Huth wrote:
> On 01.03.2016 12:51, Laurent Vivier wrote:
>>
>>
>> On 01/03/2016 11:08, Thomas Huth wrote:
>>> Introduce a test for sPAPR hypercalls, starting with the
>>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>
>> A xouple of stupid questions:
>>
>> Is that normal they are all failing?
>>
>> FAIL: hypercall: h_set_sprg0: sprg0 = 0xcafebabedeadbeef
>> FAIL: hypercall: h_set_sprg0: sprg0 = 0xaaaaaaaa55555555
>> FAIL: hypercall: h_set_sprg0: sprg0 = 0x0
>> FAIL: hypercall: h_page_init: h_zero_page
>> FAIL: hypercall: h_page_init: h_copy_page
>> FAIL: hypercall: h_page_init: h_copy_page+h_zero_page
>> FAIL: hypercall: h_page_init: h_zero_page unaligned dst
>> FAIL: hypercall: h_page_init: h_copy_page unaligned src
>>
>> SUMMARY: 8 tests, 8 unexpected failures
> 
> Did you use the very latest git version of QEMU? ... these two
> hypercalls have just been added recently, so the tests fail if your QEMU
> does not support them yet.

Thanks, these tests work fine with HEAD of master branch.

Laurent

>> Is it possible to have a message for the H_RANDOM test, something like
>> "not supported"?
> 
> I initially had something like that in my code, but the output like
> 
>  PASS: hypercall: h_random: not supported
> 
> then also looks somewhat strange ...
> 
> Is there already a common sense how to (not) report missing and thus
> untestable features in kvm-unit-tests? Something like
> 
>  SKIP: hypercall: h_random: not supported
> 
> would be posh, I think...
> 
>  Thomas
>